ab579f2511
Summary: Depends on D19155. Ref T13094. Ref T4340. We can't currently implement a strict `form-action 'self'` content security policy because some file downloads rely on a `<form />` which sometimes POSTs to the CDN domain. Broadly, stop generating these forms. We just redirect instead, and show an interstitial confirm dialog if no CDN domain is configured. This makes the UX for installs with no CDN domain a little worse and the UX for everyone else better. Then, implement the stricter Content-Security-Policy. This also removes extra confirm dialogs for downloading Harbormaster build logs and data exports. Test Plan: - Went through the plain data export, data export with bulk jobs, ssh key generation, calendar ICS download, Diffusion data, Paste data, Harbormaster log data, and normal file data download workflows with a CDN domain. - Went through all those workflows again without a CDN domain. - Grepped for affected symbols (`getCDNURI()`, `getDownloadURI()`). - Added an evil form to a page, tried to submit it, was rejected. - Went through the ReCaptcha and Stripe flows again to see if they're submitting any forms. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13094, T4340 Differential Revision: https://secure.phabricator.com/D19156
120 lines
3.8 KiB
PHP
120 lines
3.8 KiB
PHP
<?php
|
|
|
|
final class PhabricatorAuthSSHKeyGenerateController
|
|
extends PhabricatorAuthSSHKeyController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $this->getViewer();
|
|
|
|
$key = $this->newKeyForObjectPHID($request->getStr('objectPHID'));
|
|
if (!$key) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$cancel_uri = $key->getObject()->getSSHPublicKeyManagementURI($viewer);
|
|
|
|
$token = id(new PhabricatorAuthSessionEngine())->requireHighSecuritySession(
|
|
$viewer,
|
|
$request,
|
|
$cancel_uri);
|
|
|
|
if ($request->isFormPost()) {
|
|
$default_name = $key->getObject()->getSSHKeyDefaultName();
|
|
|
|
$keys = PhabricatorSSHKeyGenerator::generateKeypair();
|
|
list($public_key, $private_key) = $keys;
|
|
|
|
$key_name = $default_name.'.key';
|
|
|
|
$file = PhabricatorFile::newFromFileData(
|
|
$private_key,
|
|
array(
|
|
'name' => $key_name,
|
|
'ttl.relative' => phutil_units('10 minutes in seconds'),
|
|
'viewPolicy' => $viewer->getPHID(),
|
|
));
|
|
|
|
$public_key = PhabricatorAuthSSHPublicKey::newFromRawKey($public_key);
|
|
|
|
$type = $public_key->getType();
|
|
$body = $public_key->getBody();
|
|
$comment = pht('Generated');
|
|
|
|
$entire_key = "{$type} {$body} {$comment}";
|
|
|
|
$type_create = PhabricatorTransactions::TYPE_CREATE;
|
|
$type_name = PhabricatorAuthSSHKeyTransaction::TYPE_NAME;
|
|
$type_key = PhabricatorAuthSSHKeyTransaction::TYPE_KEY;
|
|
|
|
$xactions = array();
|
|
|
|
$xactions[] = id(new PhabricatorAuthSSHKeyTransaction())
|
|
->setTransactionType(PhabricatorTransactions::TYPE_CREATE);
|
|
|
|
$xactions[] = id(new PhabricatorAuthSSHKeyTransaction())
|
|
->setTransactionType($type_name)
|
|
->setNewValue($default_name);
|
|
|
|
$xactions[] = id(new PhabricatorAuthSSHKeyTransaction())
|
|
->setTransactionType($type_key)
|
|
->setNewValue($entire_key);
|
|
|
|
$editor = id(new PhabricatorAuthSSHKeyEditor())
|
|
->setActor($viewer)
|
|
->setContentSourceFromRequest($request)
|
|
->applyTransactions($key, $xactions);
|
|
|
|
$download_link = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $file->getDownloadURI(),
|
|
),
|
|
array(
|
|
id(new PHUIIconView())->setIcon('fa-download'),
|
|
' ',
|
|
pht('Download Private Key (%s)', $key_name),
|
|
));
|
|
$download_link = phutil_tag('strong', array(), $download_link);
|
|
|
|
// NOTE: We're disabling workflow on cancel so the page reloads, showing
|
|
// the new key.
|
|
|
|
return $this->newDialog()
|
|
->setTitle(pht('Download Private Key'))
|
|
->appendParagraph(
|
|
pht(
|
|
'A keypair has been generated, and the public key has been '.
|
|
'added as a recognized key.'))
|
|
->appendParagraph($download_link)
|
|
->appendParagraph(
|
|
pht(
|
|
'After you download the private key, it will be destroyed. '.
|
|
'You will not be able to retrieve it if you lose your copy.'))
|
|
->setDisableWorkflowOnCancel(true)
|
|
->addCancelButton($cancel_uri, pht('Done'));
|
|
}
|
|
|
|
try {
|
|
PhabricatorSSHKeyGenerator::assertCanGenerateKeypair();
|
|
|
|
return $this->newDialog()
|
|
->setTitle(pht('Generate New Keypair'))
|
|
->addHiddenInput('objectPHID', $key->getObject()->getPHID())
|
|
->appendParagraph(
|
|
pht(
|
|
'This workflow will generate a new SSH keypair, add the public '.
|
|
'key, and let you download the private key.'))
|
|
->appendParagraph(
|
|
pht('Phabricator will not retain a copy of the private key.'))
|
|
->addSubmitButton(pht('Generate New Keypair'))
|
|
->addCancelButton($cancel_uri);
|
|
} catch (Exception $ex) {
|
|
return $this->newDialog()
|
|
->setTitle(pht('Unable to Generate Keys'))
|
|
->appendParagraph($ex->getMessage())
|
|
->addCancelButton($cancel_uri);
|
|
}
|
|
}
|
|
|
|
}
|