b2890eeb0e
Summary: These are all unambiguously unextensible. Issues I hit: - Maniphest Change/Diff controllers, just consolidated them. - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects. - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962. Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1843
66 lines
1.9 KiB
PHP
66 lines
1.9 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialInlineCommentPreviewController
|
|
extends DifferentialController {
|
|
|
|
private $revisionID;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->revisionID = $data['id'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
// TODO: This is a reasonable approximation of the feature as it exists
|
|
// in Facebook trunk but we should probably pull filename data, sort these,
|
|
// figure out next/prev/edit/delete, deal with out-of-date inlines, etc.
|
|
|
|
$inlines = id(new DifferentialInlineComment())->loadAllWhere(
|
|
'authorPHID = %s AND revisionID = %d AND commentID IS NULL',
|
|
$user->getPHID(),
|
|
$this->revisionID);
|
|
|
|
$engine = PhabricatorMarkupEngine::newDifferentialMarkupEngine();
|
|
|
|
$phids = array($user->getPHID());
|
|
$handles = id(new PhabricatorObjectHandleData($phids))
|
|
->loadHandles();
|
|
|
|
$views = array();
|
|
foreach ($inlines as $inline) {
|
|
$view = new DifferentialInlineCommentView();
|
|
$view->setInlineComment($inline);
|
|
$view->setMarkupEngine($engine);
|
|
$view->setHandles($handles);
|
|
$view->setEditable(false);
|
|
$view->setPreview(true);
|
|
$views[] = $view->render();
|
|
}
|
|
$views = implode("\n", $views);
|
|
|
|
return id(new AphrontAjaxResponse())
|
|
->setContent($views);
|
|
}
|
|
|
|
|
|
}
|