fdf90b46eb
Summary: See T1963 for discussion of the Facebook-specific hack. Differential currently uses a one-stage cache (render -> postprocess -> save in cache) rather than the two-stage cache (render -> save in cache -> postprocess) offered by `PhabricatorMarkupInteface`. This breaks Differential comments coming out of cache for the lightbox, and makes various other things suboptimal (status of handles like @mentions and embeds are not displayed accurately). Instead, use the modern stuff. Test Plan: - Created preview comments and inlines in Differential. - Edited a Differential inline. - Submitted main and inline Differential comments. - Viewed and edited Differential summary and test plan. - Created preview comments and inlines in Diffusion. - Submitted comments and inlines in Diffusion. - Verified Differential now loads and saves to the generalized markup cache (Diffusion is close, but main comments still hold a single-stage cache). - Verified old Differential comments work correctly with the lightbox. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1963 Differential Revision: https://secure.phabricator.com/D3804
57 lines
1.6 KiB
PHP
57 lines
1.6 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/**
|
|
* Shared interface used by Differential and Diffusion inline comments.
|
|
*/
|
|
interface PhabricatorInlineCommentInterface extends PhabricatorMarkupInterface {
|
|
|
|
const MARKUP_FIELD_BODY = 'markup:body';
|
|
|
|
public function setChangesetID($id);
|
|
public function getChangesetID();
|
|
|
|
public function setIsNewFile($is_new);
|
|
public function getIsNewFile();
|
|
|
|
public function setLineNumber($number);
|
|
public function getLineNumber();
|
|
|
|
public function setLineLength($length);
|
|
public function getLineLength();
|
|
|
|
public function setContent($content);
|
|
public function getContent();
|
|
|
|
public function setCache($cache);
|
|
public function getCache();
|
|
|
|
public function setAuthorPHID($phid);
|
|
public function getAuthorPHID();
|
|
|
|
public function setSyntheticAuthor($synthetic_author);
|
|
public function getSyntheticAuthor();
|
|
|
|
public function isCompatible(PhabricatorInlineCommentInterface $inline);
|
|
public function isDraft();
|
|
|
|
public function save();
|
|
public function delete();
|
|
|
|
}
|