archive/pillar
0
0
Fork 0
Code Issues 42 Pull Requests Projects Releases Wiki Activity

Use str2id(x) instead of ObjectId(x)

Browse Source 
The latter produces an internal server error if 'x' is not a valid ObjectId,
whereas the fromer produces a 400 Bad Request.
This commit is contained in:
Sybren A. Stüvel
2017-05-24 16:31:15 +02:00
parent 4edbcd6a98
commit 85b6ff2d7f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pillar/api/projects/routes.py
View File

@@ -41,6 +41,8 @@ def project_manage_users():
No changes are done on the project itself. No changes are done on the project itself.
""" """
from pillar.api.utils import str2id
projects_collection = current_app.data.driver.db['projects'] projects_collection = current_app.data.driver.db['projects']
users_collection = current_app.data.driver.db['users'] users_collection = current_app.data.driver.db['users']
@@ -57,8 +59,8 @@ def project_manage_users():
# The request is not a form, since it comes from the API sdk # The request is not a form, since it comes from the API sdk
data = json.loads(request.data) data = json.loads(request.data)
project_id = ObjectId(data['project_id']) project_id = str2id(data['project_id'])
target_user_id = ObjectId(data['user_id']) target_user_id = str2id(data['user_id'])
action = data['action'] action = data['action']
current_user_id = g.current_user['user_id'] current_user_id = g.current_user['user_id']