archive/pillar
0
0
Fork 0
Code Issues 42 Pull Requests Projects Releases Wiki Activity

.container width overriden #48959

New Issue
Closed
opened 2016-07-28 01:25:42 +02:00 by nucularJohn · 4 comments
nucularJohn commented 2016-07-28 01:25:42 +02:00
Copy Link

Examples: From sizes 768px to 1100px

https://cloud.blender.org/blog/ - Affects page-body and footer.
https://cloud.blender.org/services - Affects footer.

Observed behaviour:

On resize: _base.sass:35 (see below) overrides all @media's width rules.

.container {
    min-width: 1100px;
}

So from width 768px to 1100px it stays as 1100px. An unexpected behavior I suppose.

Proposed solution:

The easiest way would be to just remove .container's min-width rule.

But usually on a "Mobile First" approach the rules you have on _utils.sass:167 (see below) would be the default rules and then you would resize with @media accordingly. I would suggest doing that.

// _utils.sass:167

@media (max-width: 767px)
.container {
    max-width: 100%;
    min-width: auto;
    padding-left: 0;
    padding-right: 0;
}
**Examples:** *From sizes 768px to 1100px* https://cloud.blender.org/blog/ - Affects page-body and footer. https://cloud.blender.org/services - Affects footer. --- **Observed behaviour:** On resize: `_base.sass:35` (see below) overrides all `@media`'s width rules. ``` .container { min-width: 1100px; } ``` So from width 768px to 1100px it stays as 1100px. An unexpected behavior I suppose. --- **Proposed solution:** The easiest way would be to just remove `.container`'s `min-width` rule. But usually on a "Mobile First" approach the rules you have on `_utils.sass:167` (see below) would be the default rules and then you would resize with `@media` accordingly. I would suggest doing that. ``` // _utils.sass:167 @media (max-width: 767px) .container { max-width: 100%; min-width: auto; padding-left: 0; padding-right: 0; } ```
nucularJohn commented 2016-07-28 01:25:42 +02:00
Author
Copy Link

Changed status to: 'Open'

Changed status to: 'Open'
nucularJohn commented 2016-07-28 01:25:42 +02:00
Author
Copy Link

Added subscriber: @nucularJohn

Added subscriber: @nucularJohn
Sergey Sharybin commented 2016-07-29 11:55:31 +02:00
Copy Link

Added subscribers: @dr.sybren, @fsiddi

Added subscribers: @dr.sybren, @fsiddi
Pablo Vazquez was assigned by Francesco Siddi 2016-07-29 11:57:53 +02:00
Pablo Vazquez commented 2016-07-29 12:30:46 +02:00
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Priority::High
Priority::Low
Priority::Normal
Status::Archived
Status::Confirmed
Status::Resolved
Type::Bug
Type::Design
Type::Patch
Type::Report
Type::To Do
legacy project
Infrastructure: Websites
legacy project
Pillar
legacy project
Pillar Framework
legacy project
Pillar Website
No Label
Priority::Normal
Status::Resolved
Type::Report
legacy project
Pillar
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
blender-admin
No Assignees Pablo Vazquez
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archive/pillar#48959
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?