archive/pillar
0
0
Fork 0
Code Issues 42 Pull Requests Projects Releases Wiki Activity

".node_index-collection" - content not centered #48993

New Issue
Closed
opened 2016-08-01 16:46:39 +02:00 by nucularJohn · 6 comments
nucularJohn commented 2016-08-01 16:46:39 +02:00
Copy Link

Examples:
https://cloud.blender.org/training
https://cloud.blender.org/open-projects

Observed behaviour:
Below 767px window's width, "node_index-collection-card project" is not centered because its width is 100% of its container's width plus 2*15px (left/right) margin, making it bigger than its container.

Over 767px content is not centered (expected behavior?).

Expected behaviour:
"node_index-collection-card project" total width (width + margin) should be equal (or inferior) to its container.

Proposed solutions:

/* For centered content on all sizes */
/* Set left-right margin to auto */

.node_index-collection-card project {
    /* margin: 12px; */
    margin: 12px auto;
}
**Examples:** https://cloud.blender.org/training https://cloud.blender.org/open-projects **Observed behaviour:** Below 767px window's width, "node_index-collection-card project" is not centered because its width is 100% of its container's width plus 2*15px (left/right) margin, making it bigger than its container. Over 767px content is not centered (expected behavior?). **Expected behaviour:** "node_index-collection-card project" total width (width + margin) should be equal (or inferior) to its container. **Proposed solutions:** ``` /* For centered content on all sizes */ /* Set left-right margin to auto */ .node_index-collection-card project { /* margin: 12px; */ margin: 12px auto; } ```
nucularJohn commented 2016-08-01 16:46:39 +02:00
Author
Copy Link

Changed status to: 'Open'

Changed status to: 'Open'
nucularJohn commented 2016-08-01 16:46:39 +02:00
Author
Copy Link

Added subscriber: @nucularJohn

Added subscriber: @nucularJohn
Francesco Siddi commented 2016-08-02 09:22:01 +02:00
Copy Link

Added subscriber: @fsiddi

Added subscriber: @fsiddi
Pablo Vazquez was assigned by Francesco Siddi 2016-08-02 09:22:01 +02:00
Francesco Siddi commented 2016-08-02 09:22:01 +02:00
Copy Link

Thanks for this, will investigate ASAP.

Thanks for this, will investigate ASAP.
Pablo Vazquez commented 2016-08-02 12:18:14 +02:00
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Pablo Vazquez commented 2016-08-02 12:21:50 +02:00
Copy Link

Thanks for the report! I've pushed the fix for mobile.

Over 767px indeed that's the expected behavior, because we want cards aligned to the left, not centered.

Thanks for the report! I've pushed the fix for mobile. Over 767px indeed that's the expected behavior, because we want cards aligned to the left, not centered.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Priority::High
Priority::Low
Priority::Normal
Status::Archived
Status::Confirmed
Status::Resolved
Type::Bug
Type::Design
Type::Patch
Type::Report
Type::To Do
legacy project
Infrastructure: Websites
legacy project
Pillar
legacy project
Pillar Framework
legacy project
Pillar Website
No Label
Priority::Normal
Status::Resolved
Type::Report
legacy project
Pillar
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
blender-admin
No Assignees Pablo Vazquez
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archive/pillar#48993
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?