archive/pillar
0
0
Fork 0
Code Issues 42 Pull Requests Projects Releases Wiki Activity

[Web] "learn more" buttons break history / back-button #49138

New Issue
Closed
opened 2016-08-22 13:40:42 +02:00 by Sybren A. Stüvel · 4 comments
Sybren A. Stüvel commented 2016-08-22 13:40:42 +02:00
Copy Link

The triplet-card buttons on the front page use window.location.replace(...), which actively prevents the use of the back button.

Another thing: we might want to use <a> tags for links as much as possible. This allows search engines like Google to actually understand the structure of the pages, and follow links. Let's just use <a href='...'>LEARN MORE</a> instead of <span class="triplet-cta">LEARN MORE</span>.

The `triplet-card` buttons on the front page use `window.location.replace(...)`, which [actively prevents the use of the back button](https://developer.mozilla.org/en-US/docs/Web/API/Location/replace). Another thing: we might want to use `<a>` tags for links as much as possible. This allows search engines like Google to actually understand the structure of the pages, and follow links. Let's just use `<a href='...'>LEARN MORE</a>` instead of `<span class="triplet-cta">LEARN MORE</span>`.
Sybren A. Stüvel commented 2016-08-22 13:40:42 +02:00
Author
Copy Link

Changed status to: 'Open'

Changed status to: 'Open'
Sybren A. Stüvel commented 2016-08-22 13:40:42 +02:00
Author
Copy Link

Added subscribers: @dr.sybren, @pablovazquez, @fsiddi

Added subscribers: @dr.sybren, @pablovazquez, @fsiddi
Sybren A. Stüvel was assigned by Francesco Siddi 2016-08-23 11:28:12 +02:00
blender-admin commented 2016-08-23 14:09:12 +02:00
Owner
Copy Link

This issue was referenced by 9d1181330b

This issue was referenced by 9d1181330bfabc14f82c40dadbb1998759cce1ea
Sybren A. Stüvel commented 2016-08-23 14:09:39 +02:00
Author
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Priority::High
Priority::Low
Priority::Normal
Status::Archived
Status::Confirmed
Status::Resolved
Type::Bug
Type::Design
Type::Patch
Type::Report
Type::To Do
legacy project
Infrastructure: Websites
legacy project
Pillar
legacy project
Pillar Framework
legacy project
Pillar Website
No Label
Priority::Normal
Status::Resolved
Type::Report
legacy project
Pillar
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
blender-admin
No Assignees Sybren A. Stüvel
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archive/pillar#49138
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?