Code issues in language support #53880

New Issue

Sybren A. Stüvel · 2018-01-24T11:49:04+01:00

Sybren A. Stüvel commented

2018-01-24 11:49:04 +01:00

There are a couple of issues in the PillarServer.set_languages() function:

It's placed between the _config_xxx() functions. Somewhere below them would be nicer.
The translations_folder parameter is unused, but there is no documentation on why that paramter is there.
self.default_locale and self.languages is set but not initialised in __init__()
This comment is rather strange:

        # Determine available languages.
        languages = list()

The initial sentence of the docstring doesn't end in a period.

There are a couple of issues in the `PillarServer.set_languages()` function: - It's placed between the `_config_xxx()` functions. Somewhere below them would be nicer. - The `translations_folder` parameter is unused, but there is no documentation on why that paramter is there. - `self.default_locale` and `self.languages` is set but not initialised in `__init__()` - This comment is rather strange: ``` # Determine available languages. languages = list() ``` - The initial sentence of the docstring doesn't [end in a period](https://www.python.org/dev/peps/pep-0257/).

Sybren A. Stüvel commented

2018-01-24 11:49:04 +01:00

Added subscribers: @dr.sybren, @dfelinto, @fsiddi

Dalai Felinto self-assigned this 2018-01-24 12:01:23 +01:00

Dalai Felinto removed their assignment 2019-12-23 16:36:21 +01:00

Sign in to join this conversation.