Deleting a node should delete its children #58013

New Issue

Sybren A. Stüvel · 2018-11-23T12:08:00+01:00

Sybren A. Stüvel commented

2018-11-23 12:08:00 +01:00

For example this asset on Spring is shown in search results because it has _deleted: false. However, visiting that link still shows "Not Found" because its parent group node was deleted.

Probably best to just delete child nodes when a parent is deleted. This would thus also include comments on an asset, notifications, etc.

It would be nice to have a visualisation of what'll be deleted when you delete a node.

We probably also want a CLI command to delete children of deleted nodes, so that we can clean up the current database.

For example [this asset on Spring](https:*cloud.blender.org/p/spring/5bf27aed527ba57cb3c48719) is shown in search results because [it has `_deleted: false`](https:*cloud.blender.org/api/nodes/5bf27aed527ba57cb3c48719). However, visiting that link still shows "Not Found" because [its parent group node](https://cloud.blender.org/api/nodes/5bf27ae4527ba57cb3c48717) was deleted. Probably best to just delete child nodes when a parent is deleted. This would thus also include comments on an asset, notifications, etc. It would be nice to have a visualisation of what'll be deleted when you delete a node. We probably also want a CLI command to delete children of deleted nodes, so that we can clean up the current database.

Sybren A. Stüvel commented

2018-11-23 12:08:01 +01:00

Added subscriber: @dr.sybren

Sign in to join this conversation.