archive/pillar
0
0
Fork 0
Code Issues 42 Pull Requests Projects Releases Wiki Activity

Deleting a node should delete its children #58013

New Issue
Open
opened 2018-11-23 12:08:00 +01:00 by Sybren A. Stüvel · 1 comment
Sybren A. Stüvel commented 2018-11-23 12:08:00 +01:00
Copy Link

For example this asset on Spring is shown in search results because it has _deleted: false. However, visiting that link still shows "Not Found" because its parent group node was deleted.

Probably best to just delete child nodes when a parent is deleted. This would thus also include comments on an asset, notifications, etc.

It would be nice to have a visualisation of what'll be deleted when you delete a node.

We probably also want a CLI command to delete children of deleted nodes, so that we can clean up the current database.

For example [this asset on Spring](https:*cloud.blender.org/p/spring/5bf27aed527ba57cb3c48719) is shown in search results because [it has `_deleted: false`](https:*cloud.blender.org/api/nodes/5bf27aed527ba57cb3c48719). However, visiting that link still shows "Not Found" because [its parent group node](https://cloud.blender.org/api/nodes/5bf27ae4527ba57cb3c48717) was deleted. Probably best to just delete child nodes when a parent is deleted. This would thus also include comments on an asset, notifications, etc. It would be nice to have a visualisation of what'll be deleted when you delete a node. We probably also want a CLI command to delete children of deleted nodes, so that we can clean up the current database.
Sybren A. Stüvel commented 2018-11-23 12:08:01 +01:00
Author
Copy Link

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Priority::High
Priority::Low
Priority::Normal
Status::Archived
Status::Confirmed
Status::Resolved
Type::Bug
Type::Design
Type::Patch
Type::Report
Type::To Do
legacy project
Infrastructure: Websites
legacy project
Pillar
legacy project
Pillar Framework
legacy project
Pillar Website
No Label
Priority::Normal
Status::Confirmed
Type::Report
legacy project
Pillar
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
blender-admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archive/pillar#58013
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?