blender/blender-addons-contrib
Archived
3
11
Fork 17
Code Pull Requests 3 Activity

Extensions: use a new structure for the server's JSON listing #29

Closed
Campbell Barton wants to merge 4 commits from test-refactor-server-json into main
pull from: test-refactor-server-json
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 4 Files Changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6e9b246865 - Show all commits

2
bl_pkg/cli/blender_ext.py
View File

@ -1138,7 +1138,7 @@ def repo_pkginfo_from_local(*, local_dir: str) -> Optional[Dict[str, Any]]:
def pkg_repo_dat_from_json(json_data: Dict[str, Any]) -> PkgRepoData: def pkg_repo_dat_from_json(json_data: Dict[str, Any]) -> PkgRepoData:
result_new = PkgRepoData( result_new = PkgRepoData(
version=json_data.get("version", "1"), version=json_data.get("version", "v1"),
ideasman42 marked this conversation as resolved Outdated
Oleg-Komarov commented 2024-04-09 14:36:01 +02:00
Outdated
Review
Copy Link

a minor concern, but let's finalize this before publishing the doc

in

extensions/views/api.py Line 105 in 11e2dea9f6
'version': 'v1',
(the branch for the server changes) I started using "v1" for the version string

I don't mind changing this to "1", but having a prefix makes it impossible to mistake the string for a number, and it also subjectively looks nicer in the explicitly versioned urls, such as https://extensions.blender.org/api/v1/extensions/

what do you think?

a minor concern, but let's finalize this before publishing the doc in https://projects.blender.org/infrastructure/extensions-website/src/commit/11e2dea9f6ad6f8d470f0d4d1aa335cca3900c89/extensions/views/api.py#L105 (the branch for the server changes) I started using `"v1"` for the version string I don't mind changing this to `"1"`, but having a prefix makes it impossible to mistake the string for a number, and it also subjectively looks nicer in the explicitly versioned urls, such as https://extensions.blender.org/api/v1/extensions/ what do you think?
Campbell Barton commented 2024-04-09 14:51:44 +02:00
Outdated
Review
Copy Link

That seems fine, I don't have such a strong opinion on this.

That seems fine, I don't have such a strong opinion on this.
blocklist=json_data.get("blocklist", []), blocklist=json_data.get("blocklist", []),
data=json_data.get("data", []), data=json_data.get("data", []),
) )