VRML import fails with ValueError: No closing quotation when VRML contains multi-line VRMLscript #101717

New Issue

Seth Gold · 2022-10-10T07:26:38+02:00

Seth Gold commented

2022-10-10 07:26:38 +02:00

System Information
Operating system: Windows 10
Graphics card: NVIDIA GeForce RTX 2070/PCIe/SSE2

Blender Version
Broken: version: 3.2.2, branch: master, commit date: 2022-08-02 18:15, hash: bcfdb14560e7, type: release
build date: 2022-08-02, 23:41:46
Worked: ???

Short description of error

Try to import a VRML file with an embedded VRML script that spans multiple lines

Error message of ValueError: No closing quotation

Sample taken from http://www.lighthouse3d.com/vrml/tutorial/script.shtml?sehl

I believe the importer is not including the closing quote

                    quote_count = l.count('"')
                    if quote_count % 2:  # odd number?
                        # print('MULTILINE')
                        while 1:
                            i += 1
                            l = lines[i]
                            quote_count = l.count('"')
                            if quote_count % 2:  # odd number?
                                value += '\n' + l[:l.rfind('"')]
                                break  # assume
                            else:
                                value += '\n' + l

                    # use shlex so we get '"a b" "b v"' --> '"a b"', '"b v"'
                    value_all = shlex.split(value, posix=False)

highligh3.wrl

**System Information** Operating system: Windows 10 Graphics card: NVIDIA GeForce RTX 2070/PCIe/SSE2 **Blender Version** Broken: version: 3.2.2, branch: master, commit date: 2022-08-02 18:15, hash: bcfdb14560e7, type: release build date: 2022-08-02, 23:41:46 Worked: ??? **Short description of error** Try to import a VRML file with an embedded VRML script that spans multiple lines Error message of ValueError: No closing quotation Sample taken from http://www.lighthouse3d.com/vrml/tutorial/script.shtml?sehl I believe the importer is not including the closing quote ``` quote_count = l.count('"') if quote_count % 2: # odd number? # print('MULTILINE') while 1: i += 1 l = lines[i] quote_count = l.count('"') if quote_count % 2: # odd number? value += '\n' + l[:l.rfind('"')] break # assume else: value += '\n' + l # use shlex so we get '"a b" "b v"' --> '"a b"', '"b v"' value_all = shlex.split(value, posix=False) ``` [highligh3.wrl](https://archive.blender.org/developer/F13646644/highligh3.wrl)

Seth Gold commented

2022-10-10 07:26:38 +02:00

Added subscriber: @Seth-Gold

Omar Emara commented

2022-10-10 15:34:17 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Full-Name-38 commented

2024-03-17 15:00:53 +01:00

It's not only for VRMLScript but also, at least, for "description" attributes. I imagine the problem is wider and concerns every multilines string.

      Anchor
      {
         description "W021 001 (Fenêtre à 1 vant
ail (#01))"

It's not only for VRMLScript but also, at least, for "description" attributes. I imagine the problem is wider and concerns every multilines string. ``` Anchor { description "W021 001 (Fenêtre à 1 vant ail (#01))" ```

Cedric Steiert referenced this issue from a commit

2024-07-20 18:07:54 +02:00

fix quote detection of multi-line VRMLscripts

Cedric Steiert referenced this issue from extensions/io_scene_x3d

2024-07-20 18:08:38 +02:00

fix quote detection of multi-line VRMLscripts #5

Cedric Steiert referenced this issue from a commit

2024-08-06 17:25:19 +02:00

fix quote detection of multi-line VRMLscripts (#5)

Sign in to join this conversation.