Regression: FBX Import error: AttributeError: 'Mesh' object has no attribute 'use_customdata_edge_crease' #102420

Closed
opened 2022-11-11 07:44:51 +01:00 by Giuliano · 10 comments

System Information
Operating system: Windows 10
Graphics card: NVIDIA GeForce GTX 1070Ti

Blender Version
Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) 3.4.0 ALpha
Worked: (newest version of Blender that worked as expected) 3.3.2, 3.3.1, 3.2, 3.1

Caused by blender/blender@a8a454287a

NOTE: https://wiki.blender.org/wiki/Reference/Release_Notes/3.4/Python_API#Internal_Mesh_Format

Short description of error

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

Importing the attached FBX file throws an error only in 3.4.0 Alpha. I know its an alpha release but just though you should know.
Imports fine in earlier versions.

**FBX version: 7200
Traceback (most recent call last):
  File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\__init__.py", line 207, in execute
    if import_fbx.load(self, context, filepath=path, **keywords) == {'FINISHED'}:
  File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\import_fbx.py", line 2604, in load
    _(); del _
  File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\import_fbx.py", line 2603, in _
    fbx_item[1] = blen_read_geom(fbx_tmpl, fbx_obj, settings)
  File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\import_fbx.py", line 1368, in blen_read_geom
    mesh.use_customdata_edge_crease = True
AttributeError: 'Mesh' object has no attribute 'use_customdata_edge_crease'**

slv426xp.fbx

**System Information** Operating system: **Windows 10** Graphics card: **NVIDIA GeForce GTX 1070Ti** **Blender Version** Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) **3.4.0 ALpha** Worked: (newest version of Blender that worked as expected) **3.3.2, 3.3.1, 3.2, 3.1** Caused by blender/blender@a8a454287a NOTE: https://wiki.blender.org/wiki/Reference/Release_Notes/3.4/Python_API#Internal_Mesh_Format **Short description of error** **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). Importing the attached FBX file throws an error only in 3.4.0 Alpha. I know its an alpha release but just though you should know. Imports fine in earlier versions. ``` **FBX version: 7200 Traceback (most recent call last): File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\__init__.py", line 207, in execute if import_fbx.load(self, context, filepath=path, **keywords) == {'FINISHED'}: File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\import_fbx.py", line 2604, in load _(); del _ File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\import_fbx.py", line 2603, in _ fbx_item[1] = blen_read_geom(fbx_tmpl, fbx_obj, settings) File "D:\FINE\Blender\__Versions__\blender-3.4.0-alpha+master.06abc9509dea-windows.amd64-release\3.4\scripts\addons\io_scene_fbx\import_fbx.py", line 1368, in blen_read_geom mesh.use_customdata_edge_crease = True AttributeError: 'Mesh' object has no attribute 'use_customdata_edge_crease'** ``` [slv426xp.fbx](https://archive.blender.org/developer/F13889995/slv426xp.fbx)
Author

Added subscriber: @Giuliano-3

Added subscriber: @Giuliano-3

#102573 was marked as duplicate of this issue

#102573 was marked as duplicate of this issue
Member

Added subscriber: @OmarEmaraDev

Added subscriber: @OmarEmaraDev
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

It seems this is a documented API change that needs to be updated. https://wiki.blender.org/wiki/Reference/Release_Notes/3.4/Python_API

It seems this is a documented API change that needs to be updated. https://wiki.blender.org/wiki/Reference/Release_Notes/3.4/Python_API
Member

Added subscribers: @Stay_Here, @PratikPB2123

Added subscribers: @Stay_Here, @PratikPB2123
Philipp Oeser changed title from FBX Import error: AttributeError: 'Mesh' object has no attribute 'use_customdata_edge_crease' to Regression: FBX Import error: AttributeError: 'Mesh' object has no attribute 'use_customdata_edge_crease' 2022-11-17 14:45:22 +01:00
Member

Added subscribers: @HooglyBoogly, @lichtwerk

Added subscribers: @HooglyBoogly, @lichtwerk
Member

@HooglyBoogly : please always check Addons for API changes.

Seems like the following is just enough (no need to enable this as a property anymore?)
P3321: T102420_snippet



diff --git a/io_scene_fbx/import_fbx.py b/io_scene_fbx/import_fbx.py
index 999161fb..6aa44317 100644
--- a/io_scene_fbx/import_fbx.py
+++ b/io_scene_fbx/import_fbx.py
@@ -1329,7 +1329,7 @@ def blen_read_geom(fbx_tmpl, fbx_obj, settings):
     # must be after edge, face loading.
     ok_smooth = blen_read_geom_layer_smooth(fbx_obj, mesh)
 
-    ok_crease = blen_read_geom_layer_edge_crease(fbx_obj, mesh)
+    blen_read_geom_layer_edge_crease(fbx_obj, mesh)
 
     ok_normals = False
     if settings.use_custom_normals:
@@ -1364,9 +1364,6 @@ def blen_read_geom(fbx_tmpl, fbx_obj, settings):
     if not ok_smooth:
         mesh.polygons.foreach_set("use_smooth", [True] * len(mesh.polygons))
 
-    if ok_crease:
-        mesh.use_customdata_edge_crease = True
-
     if settings.use_custom_props:
         blen_read_custom_properties(fbx_obj, mesh, settings)
 
@HooglyBoogly : please always check Addons for API changes. Seems like the following is just enough (no need to enable this as a property anymore?) [P3321: T102420_snippet](https://archive.blender.org/developer/P3321.txt) ``` diff --git a/io_scene_fbx/import_fbx.py b/io_scene_fbx/import_fbx.py index 999161fb..6aa44317 100644 --- a/io_scene_fbx/import_fbx.py +++ b/io_scene_fbx/import_fbx.py @@ -1329,7 +1329,7 @@ def blen_read_geom(fbx_tmpl, fbx_obj, settings): # must be after edge, face loading. ok_smooth = blen_read_geom_layer_smooth(fbx_obj, mesh) - ok_crease = blen_read_geom_layer_edge_crease(fbx_obj, mesh) + blen_read_geom_layer_edge_crease(fbx_obj, mesh) ok_normals = False if settings.use_custom_normals: @@ -1364,9 +1364,6 @@ def blen_read_geom(fbx_tmpl, fbx_obj, settings): if not ok_smooth: mesh.polygons.foreach_set("use_smooth", [True] * len(mesh.polygons)) - if ok_crease: - mesh.use_customdata_edge_crease = True - if settings.use_custom_props: blen_read_custom_properties(fbx_obj, mesh, settings) ```
Hans Goudey self-assigned this 2022-11-22 21:08:18 +01:00

This issue was referenced by 946b62da3f

This issue was referenced by 946b62da3f9c93b4add8596aef836bf3a29ea27c
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#102420
No description provided.