in 4.0 alpha, i cannot add bolts anymore... #104762

New Issue

Christoph Duyster · 2023-07-20T10:47:21+02:00

Christoph Duyster commented

2023-07-20 10:47:21 +02:00

System Information
Operating system: macOS-13.4.1-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M1 Max 1.2

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-13 22:52, hash: 474b492b3893
Worked: (newest version of Blender that worked as expected)

Addon Information
Name: BoltFactory (0, 4, 0)
Author: Aaron Keith

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

**System Information** Operating system: macOS-13.4.1-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M1 Max 1.2 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-13 22:52, hash: `474b492b3893` Worked: (newest version of Blender that worked as expected) **Addon Information** Name: BoltFactory (0, 4, 0) Author: Aaron Keith **Short description of error** [Please fill out a short description of the error here] **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] ![image](/attachments/9e3a1613-7943-4c1e-aff2-642450e75adc)

image.png

145 KiB

Christoph Duyster added the

labels 2023-07-20 10:47:21 +02:00

Philipp Oeser commented

2023-07-20 11:03:41 +02:00

Can confirm, will check...

Philipp Oeser added

and removed

labels 2023-07-20 11:03:48 +02:00

Philipp Oeser commented

2023-07-20 12:57:02 +02:00

This was caused by blender/blender@a280e8a68c, so it might actually a problem in blender itself (not the Addon).

The above commit enabled a check that was #ifdefed before (was marked "not strictly necessary" in blender/blender@30dcada24d)

So this might expose an error in the Addon code itself ("wrong data provided to polygons.foreach_set), but this seems to have never been a real problem afaict.

Will summon reviewers of blender/blender#109179 here (as well as the Addon author) to discuss...

CC @meermanr
CC @Baardaap
CC @brecht
CC @HooglyBoogly

Note: re-commenting the check makes both this report and blender/blender#107416 work :

diff --git a/source/blender/python/intern/bpy_rna.c b/source/blender/python/intern/bpy_rna.c
index da0a1dfeec9..d77d415c52b 100644
--- a/source/blender/python/intern/bpy_rna.c
+++ b/source/blender/python/intern/bpy_rna.c
@@ -5288,7 +5288,9 @@ static int foreach_parse_args(BPy_PropertyRNA *self,
                               bool *r_attr_signed)
 {
   int array_tot;
+#if 0
   int target_tot;
+#endif
 
   *r_size = *r_attr_tot = 0;
   *r_attr_signed = false;
@@ -5332,7 +5334,8 @@ static int foreach_parse_args(BPy_PropertyRNA *self,
       return -1;
     }
     *r_size = RNA_raw_type_sizeof(*r_raw_type);
-
+#if 0 /* Works fine, but not strictly needed. \
+       * we could allow RNA_property_collection_raw_* to do the checks */
     if ((*r_attr_tot) < 1) {
       *r_attr_tot = 1;
     }
@@ -5347,6 +5350,7 @@ static int foreach_parse_args(BPy_PropertyRNA *self,
                    target_tot);
       return -1;
     }
+#endif
   }
 
   /* Check 'r_attr_tot' otherwise we don't know if any values were set.

This was caused by blender/blender@a280e8a68c15ee3ec0978fb594b29d083fd2bcd6, so it _might_ actually a problem in blender itself (not the Addon). The above commit enabled a check that was #ifdefed before (was marked "not strictly necessary" in blender/blender@30dcada24d18) So this _might_ expose an error in the Addon code itself ("wrong data provided to `polygons.foreach_set`), but this seems to have never been a real problem afaict. Will summon reviewers of https://projects.blender.org/blender/blender/pulls/109179 here (as well as the Addon author) to discuss... CC @meermanr CC @Baardaap CC @brecht CC @HooglyBoogly Note: re-commenting the check makes both this report and https://projects.blender.org/blender/blender/issues/107416 work : ```diff diff --git a/source/blender/python/intern/bpy_rna.c b/source/blender/python/intern/bpy_rna.c index da0a1dfeec9..d77d415c52b 100644 --- a/source/blender/python/intern/bpy_rna.c +++ b/source/blender/python/intern/bpy_rna.c @@ -5288,7 +5288,9 @@ static int foreach_parse_args(BPy_PropertyRNA *self, bool *r_attr_signed) { int array_tot; +#if 0 int target_tot; +#endif *r_size = *r_attr_tot = 0; *r_attr_signed = false; @@ -5332,7 +5334,8 @@ static int foreach_parse_args(BPy_PropertyRNA *self, return -1; } *r_size = RNA_raw_type_sizeof(*r_raw_type); - +#if 0 /* Works fine, but not strictly needed. \ + * we could allow RNA_property_collection_raw_* to do the checks */ if ((*r_attr_tot) < 1) { *r_attr_tot = 1; } @@ -5347,6 +5350,7 @@ static int foreach_parse_args(BPy_PropertyRNA *self, target_tot); return -1; } +#endif } /* Check 'r_attr_tot' otherwise we don't know if any values were set. ```

Philipp Oeser added

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

in 4.0 alpha, i cannot add bolts anymore... #104762