Node Wrangler: Using undefined variable prevents preview of any node in the node group #105067

New Issue

IvanIvanov-1 · 2023-12-15T21:19:46+01:00

IvanIvanov-1 commented

2023-12-15 21:19:46 +01:00

System Information
Operating system: Linux-6.5.0-14-generic-x86_64-with-glibc2.38 64 Bits, X11 UI
Graphics card: Mesa Intel(R) UHD Graphics (ADL-S GT1) Intel 4.6 (Core Profile) Mesa 23.2.1-1ubuntu3.1

Blender Version
Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: 9be62e85b727
Worked: not sure; I have only 4.0.1 and 4.0.2 - in both the bug exists

Addon Information
Name: Node Wrangler (3, 47)
Author: Bartek Skorupa, Greg Zaal, Sebastian Koenig, Christian Brinkmann, Florian Meyer

Short description of error
On line 529 in "[path_for_default_addons]/4.0/scripts/addons/node_wrangler/operators.py" in the ensure_viewer_socket (called by the invoke, line 795) function:
groupout_input = groupout.inputs[i] the variable i is undefined
Unfortunately I closed the blender before taking the exact stacktrace.

Exact steps for others to reproduce the error

Use the Ctrl+Shift+T to preview a node in a node group
Shows error for the undefined variable: i
Ever since I saw the problem I can not reproduce it, so I'm not sure what triggered using the buggy code

**System Information** Operating system: Linux-6.5.0-14-generic-x86_64-with-glibc2.38 64 Bits, X11 UI Graphics card: Mesa Intel(R) UHD Graphics (ADL-S GT1) Intel 4.6 (Core Profile) Mesa 23.2.1-1ubuntu3.1 **Blender Version** Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: `9be62e85b727` Worked: not sure; I have only 4.0.1 and 4.0.2 - in both the bug exists **Addon Information** Name: Node Wrangler (3, 47) Author: Bartek Skorupa, Greg Zaal, Sebastian Koenig, Christian Brinkmann, Florian Meyer **Short description of error** On line 529 in "[path_for_default_addons]/4.0/scripts/addons/node_wrangler/operators.py" in the `ensure_viewer_socket` (called by the `invoke`, line 795) function: `groupout_input = groupout.inputs[i]` the variable `i` is undefined Unfortunately I closed the blender before taking the exact stacktrace. **Exact steps for others to reproduce the error** 1. Use the Ctrl+Shift+T to preview a node in a node group 2. Shows error for the undefined variable: `i` 3. Ever since I saw the problem I can not reproduce it, so I'm not sure what triggered using the buggy code

IvanIvanov-1 added the

labels 2023-12-15 21:19:47 +01:00

Damien Picard added

and removed

labels 2023-12-15 21:46:52 +01:00

Damien Picard commented

2023-12-15 21:51:32 +01:00

Hi, thanks for the report.

This happens if multiple materials use the same node group.

nw_bug_105067.blend

Open the attached .blend file
Enable Node Wrangler
Select the Cube
Go into NodeGroup in the Shader Editor
Ctrl + Shift + RMB on any node

It was introduced in my refactor commit 1c308ec742, I’ll have a look.

Hi, thanks for the report. This happens if multiple materials use the same node group. [nw_bug_105067.blend](/attachments/27bcb73a-df36-4822-8904-fb9a1016a16f) - Open the attached .blend file - Enable Node Wrangler - Select the Cube - Go into NodeGroup in the Shader Editor - Ctrl + Shift + RMB on any node It was introduced in my refactor commit 1c308ec742, I’ll have a look.

nw_bug_105067.blend

122 KiB

Damien Picard referenced this issue from a commit

2023-12-17 14:13:36 +01:00

Fix #105067: Node Wrangler: cannot preview multi-user material group

Damien Picard closed this issue

2023-12-17 14:13:37 +01:00

Blender Bot added

Status

Resolved

and removed

Status