blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Node Wrangler: Using undefined variable prevents preview of any node in the node group #105067

New Issue
Closed
opened 2023-12-15 21:19:46 +01:00 by IvanIvanov-1 · 1 comment
IvanIvanov-1 commented 2023-12-15 21:19:46 +01:00
Copy Link

System Information
Operating system: Linux-6.5.0-14-generic-x86_64-with-glibc2.38 64 Bits, X11 UI
Graphics card: Mesa Intel(R) UHD Graphics (ADL-S GT1) Intel 4.6 (Core Profile) Mesa 23.2.1-1ubuntu3.1

Blender Version
Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: 9be62e85b727
Worked: not sure; I have only 4.0.1 and 4.0.2 - in both the bug exists

Addon Information
Name: Node Wrangler (3, 47)
Author: Bartek Skorupa, Greg Zaal, Sebastian Koenig, Christian Brinkmann, Florian Meyer

Short description of error
On line 529 in "[path_for_default_addons]/4.0/scripts/addons/node_wrangler/operators.py" in the ensure_viewer_socket (called by the invoke, line 795) function:
groupout_input = groupout.inputs[i] the variable i is undefined
Unfortunately I closed the blender before taking the exact stacktrace.

Exact steps for others to reproduce the error

  1. Use the Ctrl+Shift+T to preview a node in a node group
  2. Shows error for the undefined variable: i
  3. Ever since I saw the problem I can not reproduce it, so I'm not sure what triggered using the buggy code
**System Information** Operating system: Linux-6.5.0-14-generic-x86_64-with-glibc2.38 64 Bits, X11 UI Graphics card: Mesa Intel(R) UHD Graphics (ADL-S GT1) Intel 4.6 (Core Profile) Mesa 23.2.1-1ubuntu3.1 **Blender Version** Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: `9be62e85b727` Worked: not sure; I have only 4.0.1 and 4.0.2 - in both the bug exists **Addon Information** Name: Node Wrangler (3, 47) Author: Bartek Skorupa, Greg Zaal, Sebastian Koenig, Christian Brinkmann, Florian Meyer **Short description of error** On line 529 in "[path_for_default_addons]/4.0/scripts/addons/node_wrangler/operators.py" in the `ensure_viewer_socket` (called by the `invoke`, line 795) function: `groupout_input = groupout.inputs[i]` the variable `i` is undefined Unfortunately I closed the blender before taking the exact stacktrace. **Exact steps for others to reproduce the error** 1. Use the Ctrl+Shift+T to preview a node in a node group 2. Shows error for the undefined variable: `i` 3. Ever since I saw the problem I can not reproduce it, so I'm not sure what triggered using the buggy code
IvanIvanov-1 added the
Status
Needs Triage
Priority
Normal
Type
Report
 labels 2023-12-15 21:19:47 +01:00
Damien Picard added
Status
Confirmed
 and removed
Status
Needs Triage
 labels 2023-12-15 21:46:52 +01:00
Damien Picard commented 2023-12-15 21:51:32 +01:00
Member
Copy Link

Hi, thanks for the report.

This happens if multiple materials use the same node group.

nw_bug_105067.blend

  • Open the attached .blend file
  • Enable Node Wrangler
  • Select the Cube
  • Go into NodeGroup in the Shader Editor
  • Ctrl + Shift + RMB on any node

It was introduced in my refactor commit 1c308ec742, I’ll have a look.

Hi, thanks for the report. This happens if multiple materials use the same node group. [nw_bug_105067.blend](/attachments/27bcb73a-df36-4822-8904-fb9a1016a16f) - Open the attached .blend file - Enable Node Wrangler - Select the Cube - Go into NodeGroup in the Shader Editor - Ctrl + Shift + RMB on any node It was introduced in my refactor commit 1c308ec742, I’ll have a look.
nw_bug_105067.blend
122 KiB
Blender Bot added
Status
Resolved
 and removed
Status
Confirmed
 labels 2023-12-17 14:13:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105067
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?