FBX importer with Force Connect Children doesn't work properly with objects parented to the bones #105217

New Issue

Ivaylo-Haralampiev · 2024-03-05T14:24:17+01:00

2024-03-05 14:24:17 +01:00

System Information
Operating system: Windows 10 Pro
Graphics card: NVIDIA GeForce GTX 1650 Ti

Blender Version
Broken: 3.6.9 and 4.0.2
Worked: none

Short description of error
This problem occurs when you import an FBX file containing meshes parented to bones with the following option set:
Armature -> Force Connect Children

I made this very simple example model to illustrate the problem. It's just a cube attached to the second bone.

This is what I get on import in the current version.

This is what I expected:

I could narrow down the problem to this line in the source of "import_fbx.py":

# Correction for children attached to a bone. FBX expects to attach to the head of a bone,
# while Blender attaches to the tail.
self.bone_child_matrix = Matrix.Translation(-bone_tail)

This doesn't take into account that bone.tail is changed in "child_connect_finalize" later on.
To fix this, remove the line above and add this after "child_connect_finalize(bone, connect_ctx)".

self.bone_child_matrix = (Matrix.Translation(bone.tail-bone.head) @ bone.matrix).inverted() @ bone_matrix

The problem seems to disappear.

Exact steps for others to reproduce the error
Open the attached Blender file and export it as FBX.
Import it back into blender without "Force Connect Childen". It works fine.
Import it back into blender with "Force Connect Childen". It looks wrong.

**System Information** Operating system: Windows 10 Pro Graphics card: NVIDIA GeForce GTX 1650 Ti **Blender Version** Broken: 3.6.9 and 4.0.2 Worked: none **Short description of error** This problem occurs when you import an FBX file containing meshes parented to bones with the following option set: Armature -> Force Connect Children I made this very simple example model to illustrate the problem. It's just a cube attached to the second bone. ![OriginalModel.png](/attachments/6d07c369-e4c8-4449-b825-9226322040a7) This is what I get on import in the current version. ![ForceConnect-Error.png](/attachments/e099a3f6-ee31-421e-aece-436215e0466f) This is what I expected: ![ForceConnect-OK.png](/attachments/6e23bc95-f813-44f0-afde-0a2117b25f76) I could narrow down the problem to this line in the source of "import_fbx.py": ``` # Correction for children attached to a bone. FBX expects to attach to the head of a bone, # while Blender attaches to the tail. self.bone_child_matrix = Matrix.Translation(-bone_tail) ``` This doesn't take into account that bone.tail is changed in "child_connect_finalize" later on. To fix this, remove the line above and add this after "child_connect_finalize(bone, connect_ctx)". ``` self.bone_child_matrix = (Matrix.Translation(bone.tail-bone.head) @ bone.matrix).inverted() @ bone_matrix ``` The problem seems to disappear. **Exact steps for others to reproduce the error** Open the attached Blender file and export it as FBX. Import it back into blender without "Force Connect Childen". It works fine. Import it back into blender with "Force Connect Childen". It looks wrong.

OriginalModel.png

213 KiB

ForceConnect-Error.png

208 KiB

ForceConnect-OK.png

154 KiB

ForceConnectError.blend

840 KiB

Ivaylo-Haralampiev added the

labels 2024-03-05 14:24:18 +01:00

Pratik Borhade commented

2024-03-08 10:12:00 +01:00

Hi, thanks for the report. Can confirm.
@Mysteryem maybe interested to check this further? :)

Hi, thanks for the report. Can confirm. @Mysteryem maybe interested to check this further? :)

Pratik Borhade added

and removed

labels 2024-03-08 10:12:10 +01:00

Thomas Barlow commented

2024-03-17 15:07:11 +01:00

Considering how Force Connect Children doesn't affect rigged meshes, I guess Objects parented to bones should also not be affected.

Either with or without this change, Force Connect Children breaks imported animations, so I don't think the effect on imported animations needs to be considered too much.

Considering how `Force Connect Children` doesn't affect rigged meshes, I guess Objects parented to bones should also not be affected. Either with or without this change, `Force Connect Children` breaks imported animations, so I don't think the effect on imported animations needs to be considered too much.

Thomas Barlow referenced a pull request that will close this issue

2024-03-21 02:15:16 +01:00

Fix #105217: FBX Force Connect Children transforms Objects parented to Bones #105249

Thomas Barlow referenced this issue from a commit

2024-03-22 13:53:55 +01:00

Fix #105217: FBX Force Connect Children transforms Objects parented to Bones

Thomas Barlow closed this issue

2024-03-22 13:53:56 +01:00

Thomas Barlow closed this issue

2024-03-22 13:53:56 +01:00

Blender Bot added

Status