GP allows to access pie menus out of context #48200

New Issue

Aaron Carlisle · 2016-04-19T22:21:15+02:00

Aaron Carlisle commented

2016-04-19 22:21:15 +02:00

System Information
Windows 10
Intel HD 4600

Blender Version
Broken: 2.77a
Worked: N/A

Short description of error
GP allows to access pie menus put of context. To reproduce this you must have pie menus add-on enabled.

Exact steps for others to reproduce the error

Go to node editor with node enabled
CTRL+D to draw GP
enable GP editing (tool shelf)
hit tab

Video: https://drive.google.com/file/d/0B4CLCL8cP5lSeWxFWEx6NVZJWWs/view?usp=sharing

**System Information** Windows 10 Intel HD 4600 **Blender Version** Broken: 2.77a Worked: N/A **Short description of error** GP allows to access pie menus put of context. To reproduce this you must have pie menus add-on enabled. **Exact steps for others to reproduce the error** 1. Go to node editor with node enabled 2. CTRL+D to draw GP 3. enable GP editing (tool shelf) 4. hit tab Video: https://drive.google.com/file/d/0B4CLCL8cP5lSeWxFWEx6NVZJWWs/view?usp=sharing

Aaron Carlisle commented

2016-04-19 22:21:15 +02:00

Changed status to: 'Open'

Aaron Carlisle commented

2016-04-19 22:21:15 +02:00

Added subscriber: @Blendify

Aaron Carlisle commented

2016-04-19 22:22:22 +02:00

Added subscriber: @JulianEisel

Aaron Carlisle changed title from ~~GP allows to access pie menus put of context~~ to GP allows to access pie menus out of context

2016-04-19 23:05:15 +02:00

Julian Eisel self-assigned this 2016-04-20 01:11:50 +02:00

Julian Eisel commented

2016-04-20 01:11:51 +02:00

Think this needs a two-step fix:

Poll pie to only allow creation in 3D views

diff --git a/ui_pie_menus_official.py b/ui_pie_menus_official.py
index d78aeaf..6ead176 100644
--- a/ui_pie_menus_official.py
+++ b/ui_pie_menus_official.py
@@ -37,6 +37,10 @@ from bpy.props import EnumProperty
 class VIEW3D_PIE_object_mode(Menu):
     bl_label = "Mode"
 
+    @classmethod
+    def poll(cls, context):
+        return (context.space_data.type == 'VIEW_3D')
+
     def draw(self, context):
         layout = self.layout

Allow event to pass through so that toggling out of GPencil edit mode using tab works:

diff --git a/source/blender/editors/interface/interface_regions.c b/source/blender/editors/interface/interface_regions.c
index b3972be..17fa7ed 100644
--- a/source/blender/editors/interface/interface_regions.c
+++ b/source/blender/editors/interface/interface_regions.c
@@ -3006,7 +3006,7 @@ int UI_pie_menu_invoke(struct bContext *C, const char *idname, const wmEvent *ev
        }
 
        if (mt->poll && mt->poll(C, mt) == 0)
-               return OPERATOR_CANCELLED;
+               return (OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH);
 
        pie = UI_pie_menu_begin(C, IFACE_(mt->label), ICON_NONE, event);
        layout = UI_pie_menu_layout(pie);
@@ -3237,7 +3237,7 @@ int UI_popup_menu_invoke(bContext *C, const char *idname, ReportList *reports)
        }
 
        if (mt->poll && mt->poll(C, mt) == 0)
-               return OPERATOR_CANCELLED;
+               return (OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH);
 
        pup = UI_popup_menu_begin(C, IFACE_(mt->label), ICON_NONE);
        layout = UI_popup_menu_layout(pup);

Hard to predict how safe second change is, guess we just have to try it.

Note that it was also possible to recreate in other editors with GPencil support.

Think this needs a two-step fix: 1. Poll pie to only allow creation in 3D views ``` diff --git a/ui_pie_menus_official.py b/ui_pie_menus_official.py index d78aeaf..6ead176 100644 --- a/ui_pie_menus_official.py +++ b/ui_pie_menus_official.py @@ -37,6 +37,10 @@ from bpy.props import EnumProperty class VIEW3D_PIE_object_mode(Menu): bl_label = "Mode" + @classmethod + def poll(cls, context): + return (context.space_data.type == 'VIEW_3D') + def draw(self, context): layout = self.layout ``` 2. Allow event to pass through so that toggling out of GPencil edit mode using tab works: ``` diff --git a/source/blender/editors/interface/interface_regions.c b/source/blender/editors/interface/interface_regions.c index b3972be..17fa7ed 100644 --- a/source/blender/editors/interface/interface_regions.c +++ b/source/blender/editors/interface/interface_regions.c @@ -3006,7 +3006,7 @@ int UI_pie_menu_invoke(struct bContext *C, const char *idname, const wmEvent *ev } if (mt->poll && mt->poll(C, mt) == 0) - return OPERATOR_CANCELLED; + return (OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH); pie = UI_pie_menu_begin(C, IFACE_(mt->label), ICON_NONE, event); layout = UI_pie_menu_layout(pie); @@ -3237,7 +3237,7 @@ int UI_popup_menu_invoke(bContext *C, const char *idname, ReportList *reports) } if (mt->poll && mt->poll(C, mt) == 0) - return OPERATOR_CANCELLED; + return (OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH); pup = UI_popup_menu_begin(C, IFACE_(mt->label), ICON_NONE); layout = UI_popup_menu_layout(pup); ``` Hard to predict how safe second change is, guess we just have to try it. Note that it was also possible to recreate in other editors with GPencil support.

Brendon Murphy commented

2016-04-21 06:46:35 +02:00

Added subscriber: @BrendonMurphy

Brendon Murphy commented

2016-04-21 06:46:35 +02:00

hi, the main issue here is context sensitivity. Rather than try to find workarounds, the menu needs to be re-written with proper per mode polls & menu's added in most operators.

Julian Eisel commented

2016-04-21 11:17:45 +02:00

@BrendonMurphy ? What I proposed is adding a poll function to the menu. Plus an event system correction for something that looks incorrect to me. It's definitely not just a workaround ;)

@BrendonMurphy ? What I proposed *is* adding a poll function to the menu. Plus an event system correction for something that looks incorrect to me. It's definitely not just a workaround ;)

Brendon Murphy commented

2016-04-22 02:02:01 +02:00

Hi, @JulianEisel sorry if that was a little abrupt. You are right, what you did is not a workaround. however I don't think it takes it far enough, from my too brief look at this, there's edit mode pies in object mode & generally no context sensitivity throughout.

Brendon Murphy commented

2016-04-23 01:23:04 +02:00

@JulianEisel hi, I'm tempted to rewrite this addon, your poll is a good start, just need context sensitivity elsewhere to refine the addon, this should be easily solvable with operator context polls. I'll make a patch for this soon.
I wouldn't be adding exceptions in C just yet, (would it affect other addons?) might need more discuss, it may be useful, unsure.

@JulianEisel hi, I'm tempted to rewrite this addon, your poll is a good start, just need context sensitivity elsewhere to refine the addon, this should be easily solvable with operator context polls. I'll make a patch for this soon. I wouldn't be adding exceptions in C just yet, (would it affect other addons?) might need more discuss, it may be useful, unsure.

blender-admin commented

2016-04-23 16:47:41 +02:00

This issue was referenced by 7c3a79b484

This issue was referenced by 7c3a79b484179e34f0d5504ea6a9bdd331e686a1

Julian Eisel commented

2016-04-23 17:27:22 +02:00

Changed status from 'Open' to: 'Resolved'

Julian Eisel closed this issue

2016-04-23 17:27:22 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GP allows to access pie menus out of context #48200