Changing Renderlayer Compositor node Layer does not update enabled outputs until script is finished #48760

New Issue

bassam kurdali · 2016-06-29T02:24:12+02:00

bassam kurdali commented

2016-06-29 02:24:12 +02:00

System Information
GNU/Linux 64 bit (Fedora 23), Intel CPU, Nvidia GPU

Blender Version
Broken: 2.77.1 2af4c80
Worked: maybe never

Short description of error
If you add change a renderlayer node's scene layer, the enabled output sockets change to reflect the scene layer's enabled passes. But if you do this within a python script or function, this does not happen until after the script has finished running, making it extremely cumbersome to use this node in your script (scene layer passes are not 1 to 1 the same as node layer output names, e.g. Combined -> Image, Alpha, Object Index ->IndexOB etc.)

Exact steps for others to reproduce the error

First download bug.blend the included .blend
Start Blender from a terminal so you can see the script output
Now run the included test.py and look at the output.
Note that both print_enabled_sockets() commands give the same enabled sockets, even though the layer has changed

Note that the two renderlayers in the scene (A and B) have different passes

What I Expect to Happen

At least with some type of refreshing (note the overkill_update() function in the script) I would expect the output to change on the second print_enabled_sockets() command to reflect the renderlayer change.

**System Information** GNU/Linux 64 bit (Fedora 23), Intel CPU, Nvidia GPU **Blender Version** Broken: 2.77.1 2af4c80 Worked: maybe never **Short description of error** If you add change a renderlayer node's scene layer, the enabled output sockets change to reflect the scene layer's enabled passes. But if you do this within a python script or function, this does not happen until *after* the script has finished running, making it extremely cumbersome to use this node in your script (scene layer passes are not 1 to 1 the same as node layer output names, e.g. Combined -> Image, Alpha, Object Index ->IndexOB etc.) **Exact steps for others to reproduce the error** - First download [bug.blend](https://archive.blender.org/developer/F318963/bug.blend) the included .blend - Start Blender from a terminal so you can see the script output - Now run the included test.py and look at the output. - Note that both print_enabled_sockets() commands give the same enabled sockets, even though the layer has changed # Note that the two renderlayers in the scene (A and B) have different passes **What I Expect to Happen** At least with some type of refreshing (note the overkill_update() function in the script) I would expect the output to change on the second print_enabled_sockets() command to reflect the renderlayer change.

bassam kurdali commented

2016-06-29 02:24:12 +02:00

Changed status to: 'Open'

bassam kurdali commented

2016-06-29 02:24:12 +02:00

Added subscriber: @BassamKurdali

bassam kurdali commented

2016-06-29 02:45:48 +02:00

bug2.blend
I added a bpy.context.scene.node_tree.update_tag()
bpy.context.scene.update()
just in case, to the overkill_update() function. Same result.

[bug2.blend](https://archive.blender.org/developer/F318967/bug2.blend) I added a bpy.context.scene.node_tree.update_tag() bpy.context.scene.update() just in case, to the overkill_update() function. Same result.

Bastien Montagne commented

2016-07-16 09:11:39 +02:00

Added subscribers: @monique, @Sergey, @Jeroen-Bakker, @mont29

Bastien Montagne commented

2016-07-16 09:11:39 +02:00

Can confirm the issue, it comes from the fact that your newly added node has no output (ED_node_tag_update_nodetree is called from RNA update callback, but does nothing in case node is not connected somehow to output - i.e. node has no effect on result). And RenderLayer node has no update() callback registered either, afaict.

Not sure how to handle this, @Jeroen-Bakker, @monique, @Sergey?

Can confirm the issue, it comes from the fact that your newly added node has no output (`ED_node_tag_update_nodetree` is called from RNA update callback, but does nothing in case node is not connected somehow to output - i.e. node has no effect on result). And RenderLayer node has no update() callback registered either, afaict. Not sure how to handle this, @Jeroen-Bakker, @monique, @Sergey?

Sergey Sharybin commented

2016-07-27 15:15:23 +02:00

@mont29, ED_node_tag_update_nodetree updates nodetree itself (aka, executes the tree to get new result).

The actual issue here is that currently sockets gets hidden on every redraw of compositor. This is weak, but it is how it is. Tweaking render passes forces updates of hidden sockets, so guess it'll be fine to do same for layer in Image and Scene compositor nodes.

@mont29, `ED_node_tag_update_nodetree` updates nodetree itself (aka, executes the tree to get new result). The actual issue here is that currently sockets gets hidden on _every_ _redraw_ of compositor. This is weak, but it is how it is. Tweaking render passes forces updates of hidden sockets, so guess it'll be fine to do same for layer in Image and Scene compositor nodes.

blender-admin commented

2016-07-27 15:17:15 +02:00

This issue was referenced by blender/blender@ae881ddf43

This issue was referenced by blender/blender@ae881ddf43af248ce4f5b69037dd340fa1db90b3

Sergey Sharybin commented

2016-07-27 15:17:47 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2016-07-27 15:17:47 +02:00

bassam kurdali commented

2016-07-27 17:31:16 +02:00

wow! thanks sergey and mont, that was an interesting/ difficult case!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Changing Renderlayer Compositor node Layer does not update enabled outputs until script is finished #48760

Note that the two renderlayers in the scene (A and B) have different passes