Bool Tool: Error with Remove Brush after Canvas Apply All #49205

Closed
opened 2016-08-30 19:54:46 +02:00 by Vuk Gardašević · 8 comments

To replicate the error:

  1. Make two objects, select them, pick one option from the Bool Tool Panel > Brush Boolean (for instance Difference)
  2. With the two objects still selected go to Properties > Canvas > Apply All
  3. Select the brush object (it's drawn as a bounding box in the 3D view) go to Properties > Brush > Remove Brush

Error log:

scripts\addons\object_boolean_tools.py", line 263, in Remove
    for mod in Canvas.modifiers:
AttributeError: 'NoneType' object has no attribute 'modifiers'

Seems that since the brushes from the Canvas being applied there's nothing to cycle through the loop of the removal function. The remove the brush object, it needs to be deleted manually.

To replicate the error: 1) Make two objects, select them, pick one option from the Bool Tool Panel > Brush Boolean (for instance Difference) 2) With the two objects still selected go to Properties > Canvas > Apply All 3) Select the brush object (it's drawn as a bounding box in the 3D view) go to Properties > Brush > Remove Brush Error log: ``` scripts\addons\object_boolean_tools.py", line 263, in Remove for mod in Canvas.modifiers: AttributeError: 'NoneType' object has no attribute 'modifiers' ``` Seems that since the brushes from the Canvas being applied there's nothing to cycle through the loop of the removal function. The remove the brush object, it needs to be deleted manually.
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @VukGardasevic

Added subscriber: @VukGardasevic
Added subscribers: @tynkatopi, @MikhailRachinskiy, @BrendonMurphy, @Sergey
Vitor Balbio was assigned by Sergey Sharybin 2016-08-31 11:34:22 +02:00

@VukGardasevic, it is always a really good idea to mention what Blender version you're using.

@MikhailRachinskiy, @tynkatopi, @BrendonMurphy who's desk this should go onto? :)

@VukGardasevic, it is always a really good idea to mention what Blender version you're using. @MikhailRachinskiy, @tynkatopi, @BrendonMurphy who's desk this should go onto? :)
Vitor Balbio was unassigned by Brendon Murphy 2016-09-01 00:25:37 +02:00
Mikhail Rachinskiy was assigned by Brendon Murphy 2016-09-01 00:25:37 +02:00
Member

Added subscriber: @vitorbalbio-3

Added subscriber: @vitorbalbio-3

This issue was referenced by 3b719f3f88

This issue was referenced by 3b719f3f88f28fb61b982022774e124bbfb8d297

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Looks like someone commented the code where brush object should be deleted on Apply All action.
Tweak Remove Brush operator anyway, since it will give an error if canvas object is deleted before Apply All.

@BrendonMurphy, BTW I didn't wrote this part of the add-on (which looks dreadful by the way). So it is better to assign to the person responsible for this mess thousand yard stare.

Looks like someone commented the code where brush object should be deleted on Apply All action. Tweak Remove Brush operator anyway, since it will give an error if canvas object is deleted before Apply All. @BrendonMurphy, BTW I didn't wrote this part of the add-on (which looks dreadful by the way). So it is better to assign to the person responsible for this mess *thousand yard stare*.
Sign in to join this conversation.
No Milestone
No project
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#49205
No description provided.