LoopTools 4.6.6 disables global undo on 2.78 #49346

Closed
opened 2016-09-14 00:54:28 +02:00 by JA 12 · 9 comments

Ubuntu 14.04, gnome 3 classic, nvidia graphics.

Blender Version
Broken: 2.78 620724d
Worked: 2.77a

Also tested with 2.78 RC1 0e5089c on Windows by another user.

LoopTools 4.6.6

Short description of error
Any LoopTools operator disables global undo in user preferences -> editing

Exact steps for others to reproduce the error
Default cube, edit mode, select a vertex or anything, W -> looptools -> circle.
If the user preferences are open, move your mouse cursor over the editor to activate/update it.

https://dl.dropboxusercontent.com/u/26346140/looptools_global_undo278.mp4

Update:
Global undo gets disabled on line 830, changing it to

    bpy.context.user_preferences.edit.use_global_undo = global_undo

like it was in LoopTools with 2.77a seems to work

Ubuntu 14.04, gnome 3 classic, nvidia graphics. **Blender Version** Broken: 2.78 620724d Worked: 2.77a Also tested with 2.78 RC1 0e5089c on Windows by another user. LoopTools 4.6.6 **Short description of error** Any LoopTools operator disables global undo in user preferences -> editing **Exact steps for others to reproduce the error** Default cube, edit mode, select a vertex or anything, W -> looptools -> circle. If the user preferences are open, move your mouse cursor over the editor to activate/update it. https://dl.dropboxusercontent.com/u/26346140/looptools_global_undo278.mp4 Update: Global undo gets disabled on line 830, changing it to ``` bpy.context.user_preferences.edit.use_global_undo = global_undo ``` like it was in LoopTools with 2.77a seems to work
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @ja12

Added subscriber: @ja12
Member

Added subscriber: @BrendonMurphy

Added subscriber: @BrendonMurphy
Brendon Murphy self-assigned this 2016-09-14 01:13:16 +02:00
Member

hi, tested, I think:
bpy.context.user_preferences.edit.use_global_undo = True
is the better solution here. will commit shortly

hi, tested, I think: bpy.context.user_preferences.edit.use_global_undo = True is the better solution here. will commit shortly
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Member

Without knowing any details - just setting use_global_undo to True seems wrong? It should be set back to whatever it was set to initially, which is stored in global_undo.

Without knowing any details - just setting `use_global_undo` to `True` seems wrong? It should be set back to whatever it was set to initially, which is stored in `global_undo`.
Member

@JulianEisel
yes testing now

@JulianEisel yes testing now
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Member

committed fix for undo, initial fix for gpencil delete

committed fix for undo, initial fix for gpencil delete
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#49346
No description provided.