Rename file #52040

Closed
opened 2017-07-12 23:58:15 +02:00 by Anders Lindén · 12 comments

Rename file from space_view3d_toolbar.py to space_view3d_toolshelf.py.0001-Rename-file-from-space_view3d_toolbar.py-to-space_vi.patch

As I understand it, this panel was called toolbar before and toolshelf now, but the naming did not change.

Rename file from space_view3d_toolbar.py to space_view3d_toolshelf.py.[0001-Rename-file-from-space_view3d_toolbar.py-to-space_vi.patch](https://archive.blender.org/developer/F661482/0001-Rename-file-from-space_view3d_toolbar.py-to-space_vi.patch) As I understand it, this panel was called toolbar before and toolshelf now, but the naming did not change.
Author

Changed status to: 'Resolved'

Changed status to: 'Resolved'
Author

Added subscriber: @AndersBillLinden

Added subscriber: @AndersBillLinden
Author

Changed status from 'Resolved' to: 'Open'

Changed status from 'Resolved' to: 'Open'

Added subscriber: @VukGardasevic

Added subscriber: @VukGardasevic

Please can you make a differential for this patch?
Add a small description explaining the purpose of the proposed changes. After possible approval / code review it can be included in future versions (2.80 series) since we are really close to 2.79.

https://developer.blender.org/differential/diff/create/

Please can you make a differential for this patch? Add a small description explaining the purpose of the proposed changes. After possible approval / code review it can be included in future versions (2.80 series) since we are really close to 2.79. https://developer.blender.org/differential/diff/create/
Author

I already provided a unified diff. Please tell me what more to provide!

I already provided a unified diff. Please tell me what more to provide!

For submitting patches to blender please consult this page:
https://wiki.blender.org/index.php/Dev:Doc/Process/Contributing_Code

The differential page is pretty straightforward to create - you can copy the diff in the field > create diff and enter the information in the next page.
This is easier for the developers to review and comment on.

For submitting patches to blender please consult this page: https://wiki.blender.org/index.php/Dev:Doc/Process/Contributing_Code The differential page is pretty straightforward to create - you can copy the diff in the field > create diff and enter the information in the next page. This is easier for the developers to review and comment on.
Author

Differential at https://developer.blender.org/differential/diff/9010/ please let me know if I should add it somewhere to this task.

Differential at https://developer.blender.org/differential/diff/9010/ please let me know if I should add it somewhere to this task.

Half way there:) Press the continue button and fill up the title and the summary fields and create the differential.
You don't need to assign any developer as reviewer if you are not sure who to add.

The newly created entry will be in the specific section designated for code review of patches and contributions and will get a code/link starting with D followed by 4 digits.

This is an example how an Differential looks like in Phabricator.
https://developer.blender.org/D2561

I know that dealing with a foreign workflow can be a bit confusing sometimes, but the more difficult part is making the diff and patch itself . Anyway, thanks for contributing:)

Half way there:) Press the continue button and fill up the title and the summary fields and create the differential. You don't need to assign any developer as reviewer if you are not sure who to add. The newly created entry will be in the specific section designated for code review of patches and contributions and will get a code/link starting with D followed by 4 digits. This is an example how an Differential looks like in Phabricator. https://developer.blender.org/D2561 I know that dealing with a foreign workflow can be a bit confusing sometimes, but the more difficult part is making the diff and patch itself . Anyway, thanks for contributing:)
Member

Added subscriber: @Blendify

Added subscriber: @Blendify
Member

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Aaron Carlisle self-assigned this 2017-07-15 22:29:31 +02:00
Member

Thanks for the suggestion but the naming is still being discussed see blender/blender#43623 so I would rather not make noisy commits until this is finalized on.

Thanks for the suggestion but the naming is still being discussed see blender/blender#43623 so I would rather not make noisy commits until this is finalized on.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#52040
No description provided.