Paint palletes import robustness #53136

Closed
opened 2017-10-23 16:33:20 +02:00 by Jesus Balbastro · 13 comments

System Information
All platforms

Blender Version
2.79 8ef39d5c882

Short description of error
The paint pallete plugin cannot handle tabs or numbers that aren't 3 digits

Exact steps for others to reproduce the error
Plugin can't handle pallet files that don't strictly conform to ###\s###\s###\sSTRING
Where # is a single digit, \s represents a space and STRING is string.
This is due to using array indexing, instead of, for instance, using split() to separate each value.
This isn't a bug of the pluging, as it's palette creating programs or methods that aren't conforming to the format(Specifically Gpick). But I think it would be easier to managed it plugin side.

**System Information** All platforms **Blender Version** 2.79 8ef39d5c882 **Short description of error** The paint pallete plugin cannot handle tabs or numbers that aren't 3 digits **Exact steps for others to reproduce the error** Plugin can't handle pallet files that don't strictly conform to ###\s###\s###\sSTRING Where # is a single digit, \s represents a space and STRING is string. This is due to using array indexing, instead of, for instance, using split() to separate each value. This isn't a bug of the pluging, as it's palette creating programs or methods that aren't conforming to the format(Specifically Gpick). But I think it would be easier to managed it plugin side.
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @JesusBalbastro

Added subscriber: @JesusBalbastro

Added subscriber: @brecht

Added subscriber: @brecht

Blender 2.69 and blender/blender@4b206af are almost 4 years old now. Is that really the version you tested? If so, please test the latest 2.79 release: https://www.blender.org/download/

If the bug still happens, please attach an example palette file that fails to load.

Blender 2.69 and blender/blender@4b206af are almost 4 years old now. Is that really the version you tested? If so, please test the latest 2.79 release: https://www.blender.org/download/ If the bug still happens, please attach an example palette file that fails to load.
Author
Member

My mistake, I edited in the version I use.
Here's the google material pallet exported as a gpl with gpick that gives errors{F1069766}

My mistake, I edited in the version I use. Here's the google material pallet exported as a gpl with gpick that gives errors{[F1069766](https://archive.blender.org/developer/F1069766/Faulty.gpl)}

Added subscriber: @VukGardasevic

Added subscriber: @VukGardasevic

@JesusBalbastro
Please try this version if it works for you. It loads the .gpl file you provided also some of the Krita ones.
However i'm not sure it will work always on other gpl files, but it should be more robust.

paint_palette.py

test_loading_gpl_palettes.jpg

@JesusBalbastro Please try this version if it works for you. It loads the .gpl file you provided also some of the Krita ones. However i'm not sure it will work always on other gpl files, but it should be more robust. [paint_palette.py](https://archive.blender.org/developer/F1077114/paint_palette.py) ![test_loading_gpl_palettes.jpg](https://archive.blender.org/developer/F1077116/test_loading_gpl_palettes.jpg)

Added subscriber: @Harvester

Added subscriber: @Harvester

The information about this add-on on the Wiki page https://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Paint/Palettes is outdated and still referencing version 0.9 and Blender 2.58 while current version is 0.9.2 and Blender 2.63. Thank you.

The information about this add-on on the Wiki page https://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Paint/Palettes is outdated and still referencing version 0.9 and Blender 2.58 while current version is 0.9.2 and Blender 2.63. Thank you.

@Harvester I agree it needs to be updated a bit. The basic functionality is explained, albeit the add-on has changed meanwhile.

@Harvester I agree it needs to be updated a bit. The basic functionality is explained, albeit the add-on has changed meanwhile.

This issue was referenced by f09e66a393

This issue was referenced by f09e66a3936396251310d56c4e76b51d6f560ae1

This issue was referenced by 7a75719ec3

This issue was referenced by 7a75719ec322cd52d976a71b8e61006716eb7697

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#53136
No description provided.