mesh_f2 Blender 2.8 Patch #58866

New Issue

Fahad Hasan · 2018-12-06T14:10:56+01:00

Fahad Hasan commented

2018-12-06 14:10:56 +01:00

mesh_f2.py
Here is a working patch for mesh_f2 in Blender 2.8.
Working without texture slot. Please See: line 51 to 61

[mesh_f2.py](https://archive.blender.org/developer/F5856896/mesh_f2.py) Here is a working patch for mesh_f2 in Blender 2.8. Working without texture slot. Please See: line 51 to 61

Campbell Barton was assigned by Fahad Hasan

2018-12-06 14:10:56 +01:00

Fahad Hasan commented

2018-12-06 14:10:56 +01:00

Added subscriber: @MD.FahadHassan

Philipp Oeser commented

2018-12-06 14:36:25 +01:00

Added subscribers: @ideasman42, @lichtwerk

Campbell Barton was unassigned by Philipp Oeser

2018-12-06 14:36:25 +01:00

Philipp Oeser self-assigned this 2018-12-06 14:36:25 +01:00

Philipp Oeser commented

2018-12-06 14:36:25 +01:00

following the discussion in F5856198:

still not mentioned what problem this actually solves (would be nice to mention this just like in a bug report...)?
still not a diff, have you had a look at how to create patches? https://wiki.blender.org/wiki/Tools/Patches
having a look now (this seems to remove necessary code though?)...

following the discussion in F5856198: - still not mentioned what problem this actually solves (would be nice to mention this just like in a bug report...)? - still not a diff, have you had a look at how to create patches? https://wiki.blender.org/wiki/Tools/Patches - having a look now (this seems to remove necessary code though?)...

Fahad Hasan commented

2018-12-06 14:53:42 +01:00

This is a conversion from 2.79 to 2.8. This is my first patch submission to Blender. Sorry if it's a wrong type of post.
Although I am familiar with git but can't understand how should I create a diff as I can't make my repository/fork here.
It seems that texture slot has been updated in 2.8. Not sure about the inner workings of texture panel of 2.8.

- This is a conversion from 2.79 to 2.8. This is my first patch submission to Blender. Sorry if it's a wrong type of post. - Although I am familiar with git but can't understand how should I create a diff as I can't make my repository/fork here. - It seems that texture slot has been updated in 2.8. Not sure about the inner workings of texture panel of 2.8.

Philipp Oeser commented

2018-12-06 15:14:48 +01:00

regarding texture_slots / uv_textures removal: I think this needs a different fix though (otherwise the whole Adjust UV functionality of the addon is broken/obsolete...)

without looking in depth, I assume it is probably best to go with ob.data.uv_layers.active
(will doublecheck later...)

Sorry, didnt want to sound harsh btw and thx for the patch [well, not a patch, but.... you get what I mean...].

regarding `texture_slots` / `uv_textures` removal: I think this needs a different fix though (otherwise the whole `Adjust UV` functionality of the addon is broken/obsolete...) without looking in depth, I assume it is probably best to go with `ob.data.uv_layers.active` (will doublecheck later...) Sorry, didnt want to sound harsh btw and thx for the patch [well, not a patch, but.... you get what I mean...].

Fahad Hasan commented

2018-12-06 15:39:54 +01:00

No problem, F2 and Bsurface are two of the most important and unique tools for retopo in Blender. And it should be included in 2.8 officially. Let me know if there are more fix please. Would be great for the entire community.

Brecht Van Lommel commented

2018-12-06 15:56:04 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2018-12-06 15:56:04 +01:00

This should loop over ob.data.uv_layers and adjust all uv layers. There is no need to tie this to materials or textures, it's not clear why the original code did that.

This should loop over `ob.data.uv_layers` and adjust all uv layers. There is no need to tie this to materials or textures, it's not clear why the original code did that.

Philipp Oeser commented

2018-12-06 16:01:38 +01:00

@brecht: doing it for all UV layers: +1
@MD.FahadHassan : there are some other minor things (e.g. annotations), will do as well...

(will commit tomorrow, gtg now...)

@brecht: doing it for all UV layers: +1 @MD.FahadHassan : there are some other minor things (e.g. annotations), will do as well... (will commit tomorrow, gtg now...)

Fahad Hasan commented

2018-12-06 16:12:17 +01:00

Alright, Thanks folks for taking care of it. Lots of love.