Rewrote VSE Sound Crossfade script to support unlimited input strips and fix bugs #61923

New Issue

Jon Seigel · 2019-02-25T07:22:11+01:00

Jon Seigel commented

2019-02-25 07:22:11 +01:00

I'm having trouble creating a diff through the system ("Unhandled Exception ("AphrontQueryException") #1048: Column 'filename' cannot be null"), so I've attached it here. Sorry.

The changes here are driven by my own needs for this functionality in Blender, and are an extension of the existing functionality, mostly for time savings reasons. Tested on 2.79b on Windows.

New functionality:

Support unlimited sound strips
Improved strip position validation
Explicit error feedback so users can identify exact problem spots

Bugs fixed:

Re-running the script with the same strips selected may have resulted in one of the curves being flattened to zero (which one depended on the current frame). I determined this was a result of using context.scene.frame_current instead of context.scene.frame_set(), and a simple replacement fixed the issue.
Handled the case where the strip on the right side of the transition already had a keyframe set on the volume property. Previously, this resulted in an incorrect keyframe value being set on that strip due to an unexpected intermediate keyframe state.

sequencer.py.diff

I'm having trouble creating a diff through the system ("Unhandled Exception ("AphrontQueryException") #1048: Column 'filename' cannot be null"), so I've attached it here. Sorry. The changes here are driven by my own needs for this functionality in Blender, and are an extension of the existing functionality, mostly for time savings reasons. Tested on 2.79b on Windows. New functionality: - Support unlimited sound strips - Improved strip position validation - Explicit error feedback so users can identify exact problem spots Bugs fixed: - Re-running the script with the same strips selected may have resulted in one of the curves being flattened to zero (which one depended on the current frame). I determined this was a result of using context.scene.frame_current instead of context.scene.frame_set(), and a simple replacement fixed the issue. - Handled the case where the strip on the right side of the transition already had a keyframe set on the volume property. Previously, this resulted in an incorrect keyframe value being set on that strip due to an unexpected intermediate keyframe state. [sequencer.py.diff](https://archive.blender.org/developer/F6709306/sequencer.py.diff)

Campbell Barton was assigned by Jon Seigel

2019-02-25 07:22:11 +01:00

Jon Seigel commented

2019-02-25 07:22:11 +01:00

Added subscriber: @jseigelis

Richard Antalik commented

2019-02-25 10:00:19 +01:00

Added subscribers: @ideasman42, @iss

Campbell Barton was unassigned by Richard Antalik

2019-02-25 10:00:19 +01:00

Richard Antalik self-assigned this 2019-02-25 10:00:19 +01:00

Richard Antalik commented

2019-02-25 10:00:19 +01:00

I also rewrote this operator in patch D4290: VSE new python operators

Will look at other fixes and include them if appropriate

I also rewrote this operator in patch [D4290: VSE new python operators](https://archive.blender.org/developer/D4290) Will look at other fixes and include them if appropriate

Jon Seigel commented

2019-02-26 07:02:27 +01:00

Oh, my bad, I didn't mean to step on your toes.

I'm a little unclear what your plan for this is based on your comment, but I had a look at the code you wrote, and TBH it will probably save time to start with the code in my patch and integrate into that instead of the other way around.

Feel free to ping me when there's a finalized version that needs testing, and I'll be happy to help out. Thanks.

Oh, my bad, I didn't mean to step on your toes. I'm a little unclear what your plan for this is based on your comment, but I had a look at the code you wrote, and TBH it will probably save time to start with the code in my patch and integrate into that instead of the other way around. Feel free to ping me when there's a finalized version that needs testing, and I'll be happy to help out. Thanks.

Richard Antalik commented

2019-02-26 18:46:47 +01:00

In #61923#627800, @jseigelis wrote:
Oh, my bad, I didn't mean to step on your toes.

Naah.

I haven't looked at your code yet.

I will probably wait until I see how this discussion goes https://devtalk.blender.org/t/python-based-operators-for-vse/5788/

As it may mean a major rewrite of all operators.

> In #61923#627800, @jseigelis wrote: > Oh, my bad, I didn't mean to step on your toes. Naah. I haven't looked at your code yet. I will probably wait until I see how this discussion goes https://devtalk.blender.org/t/python-based-operators-for-vse/5788/ As it may mean a major rewrite of all operators.

Dalai Felinto commented

2019-12-23 18:37:23 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2019-12-23 18:37:23 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Dalai Felinto closed this issue

2019-12-23 18:37:23 +01:00

Dalai Felinto commented

2019-12-23 18:37:23 +01:00

Hi, thanks for your patch.

We are undergoing a Tracker Curfew where we are automatically closing old patches.

If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.

Hi, thanks for your patch. We are undergoing a [Tracker Curfew ](https://code.blender.org/?p=3861) where we are automatically closing old patches. If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Rewrote VSE Sound Crossfade script to support unlimited input strips and fix bugs #61923