Node Wrangler emission viewer broken with cycles disabled #64584

Closed
opened 2019-05-14 07:11:40 +02:00 by Adrian Guerra · 7 comments

Operating system: Windows 10
Graphics card: NVIDIA GeForce GTX 980M

Broken: (2.80, a5b5bd2c24e0, master, 2019-05-13)

When the cycles addon is disabled, the 'Emission Viewer' feature of node wrangler fails

Steps to reproduce:

  • Disable the cycles addon
  • Switch to shading view, create a new material
  • Add in any node other than a shader (since shader outputs are handled differently)
  • Hover your mouse over the node and trigger the emission viewer (default shortcut is ctrl + shift + left mouse)

you should get an error like this:

Traceback (most recent call last):
  File "...scripts/addons/node_wrangler.py", line 1704, in invoke
    intensity = 1/context.scene.cycles.film_exposure  # Film exposure is a multiplier
AttributeError: 'Scene' object has no attribute 'cycles'
Operating system: Windows 10 Graphics card: NVIDIA GeForce GTX 980M Broken: (2.80, a5b5bd2c24e0, master, 2019-05-13) When the cycles addon is disabled, the 'Emission Viewer' feature of node wrangler fails Steps to reproduce: - Disable the cycles addon - Switch to shading view, create a new material - Add in any node other than a shader (since shader outputs are handled differently) - Hover your mouse over the node and trigger the emission viewer (default shortcut is `ctrl + shift + left mouse`) you should get an error like this: ``` Traceback (most recent call last): File "...scripts/addons/node_wrangler.py", line 1704, in invoke intensity = 1/context.scene.cycles.film_exposure # Film exposure is a multiplier AttributeError: 'Scene' object has no attribute 'cycles' ```
Author

Added subscriber: @amgg

Added subscriber: @amgg
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2019-05-14 09:44:13 +02:00
Member

Confirmed, will have a look...

Confirmed, will have a look...
Member

Added subscriber: @BrendonMurphy

Added subscriber: @BrendonMurphy
Member

line 547 is the issue

def is_cycles_or_eevee(context):
    return context.scene.render.engine in {'CYCLES', 'BLENDER_EEVEE'}

Possibly this could be better written to handle this.

line 547 is the issue ``` def is_cycles_or_eevee(context): return context.scene.render.engine in {'CYCLES', 'BLENDER_EEVEE'} ``` Possibly this could be better written to handle this.
Philipp Oeser was unassigned by Dalai Felinto 2019-12-23 16:34:24 +01:00

This issue was referenced by 8130de948d

This issue was referenced by 8130de948d78704db21b0b1e1e3aaadcd12a0c3f

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Brecht Van Lommel self-assigned this 2020-02-12 11:33:41 +01:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#64584
No description provided.