invoke_props_dialog ignores height #68749

New Issue

Adam Stankiewicz · 2019-08-16T22:38:41+02:00

Adam Stankiewicz commented

2019-08-16 22:38:41 +02:00

System Information
Operating system: MacOS Mojave 10.14.4
Graphics card: None

Blender Version
Broken: Version 2.80 (2.80 2019-07-29)

Short description of error

invoke_props_dialog ignores passed height of window

Exact steps for others to reproduce the error

Create operator with invoke method:

 def invoke(self, context, event):
      return context.window_manager.invoke_props_dialog(self, width=500, height=500)

Result:

Dialog window is opened with width 500 and low height

Expected

Dialog window is opened with width 500 and height 500.

**System Information** Operating system: MacOS Mojave 10.14.4 Graphics card: None **Blender Version** Broken: Version 2.80 (2.80 2019-07-29) **Short description of error** invoke_props_dialog ignores passed height of window **Exact steps for others to reproduce the error** Create operator with invoke method: ``` def invoke(self, context, event): return context.window_manager.invoke_props_dialog(self, width=500, height=500) ``` Result: Dialog window is opened with width 500 and low height Expected Dialog window is opened with width 500 and height 500.

Adam Stankiewicz commented

2019-08-16 22:38:41 +02:00

Added subscriber: @sheerun

Jacques Lucke commented

2019-08-20 17:00:42 +02:00

Added subscribers: @ideasman42, @JacquesLucke

Jacques Lucke commented

2019-08-20 17:00:42 +02:00

Hmm, not sure if the height is actually ever used. The height of things is probably always determined by the content. Not sure why there is a height parameter.

@ideasman42 should the height parameter do something currently?

@sheerun, can you provide a small script that we can just copy into the text editor to test this bug, please?

Hmm, not sure if the height is actually ever used. The height of things is probably always determined by the content. Not sure why there is a height parameter. @ideasman42 should the height parameter do something currently? @sheerun, can you provide a small script that we can just copy into the text editor to test this bug, please?

Adam Stankiewicz commented

2019-08-20 18:41:12 +02:00

import bpy
 
class MessageBox(bpy.types.Operator):
    bl_idname = "message.messagebox"
    bl_label = ""
 
    def execute(self, context):
        return {'FINISHED'}
 
    def invoke(self, context, event):
        return context.window_manager.invoke_props_dialog(self, width = 500, height = 500)
 
class Test_PT_Panel(bpy.types.Panel):
    bl_idname = "object.custom_panel"
    bl_label = "My Plugin"
    bl_category = "YAY3"
    bl_space_type = "VIEW_3D"
    bl_region_type = "UI"

    def draw(self, context):
        layout = self.layout
        row = layout.row()
        row.operator("message.messagebox", text = "Message")
        
def register():
    bpy.utils.register_class(MessageBox)
    bpy.utils.register_class(Test_PT_Panel)
    
 
def unregister():
    bpy.utils.unregister_class(Test_PT_Panel)
    bpy.utils.unregister_class(MessageBox)
    
register()

``` import bpy class MessageBox(bpy.types.Operator): bl_idname = "message.messagebox" bl_label = "" def execute(self, context): return {'FINISHED'} def invoke(self, context, event): return context.window_manager.invoke_props_dialog(self, width = 500, height = 500) class Test_PT_Panel(bpy.types.Panel): bl_idname = "object.custom_panel" bl_label = "My Plugin" bl_category = "YAY3" bl_space_type = "VIEW_3D" bl_region_type = "UI" def draw(self, context): layout = self.layout row = layout.row() row.operator("message.messagebox", text = "Message") def register(): bpy.utils.register_class(MessageBox) bpy.utils.register_class(Test_PT_Panel) def unregister(): bpy.utils.unregister_class(Test_PT_Panel) bpy.utils.unregister_class(MessageBox) register() ```

Campbell Barton commented

2019-08-20 19:48:59 +02:00

Looked into it, while the height is used internally, the UI_block_bounds_set_popup call causes the height to be ignored.

Using the height could be used to add padding to the dialog but don't see this as being useful.

Unfortunately removing this argument will break scripts.

Unless there is a good reason to support empty space, I think this argument could be deprecated.

Looked into it, while the height is used internally, the `UI_block_bounds_set_popup` call causes the height to be ignored. Using the height could be used to add padding to the dialog but don't see this as being useful. Unfortunately removing this argument will break scripts. Unless there is a good reason to support empty space, I think this argument could be deprecated.

Jacques Lucke commented

2019-08-20 19:51:41 +02:00

Thanks for looking into it. I'm fine with deprecating the argument.

blender-admin commented

2020-01-28 10:49:05 +01:00

This issue was referenced by blender/blender@e64166652b

This issue was referenced by blender/blender@e64166652b17631e9c2a5b64bd54e7cf38af8ebb

Jeroen Bakker commented

2020-01-28 10:51:28 +01:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2020-01-28 10:51:28 +01:00

the width and height are set in rna_generic_op_invoke when the WM_GEN_INVOKE_SIZE option is set. WM_GEN_INVOKE_SIZE is used for invoke_props_dialog and invoke_popup. In our add-ons only create prim uses the height option. Both ignore the height option.

the `width` and `height` are set in `rna_generic_op_invoke` when the `WM_GEN_INVOKE_SIZE` option is set. `WM_GEN_INVOKE_SIZE` is used for `invoke_props_dialog` and `invoke_popup`. In our add-ons only `create prim` uses the height option. Both ignore the height option.

Jeroen Bakker commented

2020-02-17 15:04:58 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-02-17 15:04:58 +01:00

Jeroen Bakker self-assigned this 2020-02-17 15:04:58 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

invoke_props_dialog ignores height #68749