blender/blender-addons
19
43
Fork 96
Code Issues 629 Pull Requests 27 Projects 1 Releases Wiki Activity

space_view3d_pie_menus // pie_proportional_menu #70062

New Issue
Open
opened 2019-09-19 11:36:57 +02:00 by Konstantin · 15 comments
Konstantin commented 2019-09-19 11:36:57 +02:00
Copy Link

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.39

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: blender/blender@f6cb5f5449
Worked: 2.79

Short description of error
Connected cant toggle off from pie menu

Exact steps for others to reproduce the error

  1. Enter edit mode
  2. call pie O
  3. turn On proportional
  4. turn On connected
  5. cant disable connected from pie

Here is a fix:
Line 189 of pie_proportional_menu.py

ts.use_proportional_connected = True  >>>  ts.use_proportional_connected ^= 1
**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.39 **Blender Version** Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: `blender/blender@f6cb5f5449` Worked: 2.79 **Short description of error** Connected cant toggle off from pie menu **Exact steps for others to reproduce the error** 1. Enter edit mode 2. call pie O 3. turn On proportional 4. turn On connected 5. cant disable connected from pie Here is a fix: Line 189 of pie_proportional_menu.py ``` ts.use_proportional_connected = True >>> ts.use_proportional_connected ^= 1 ```
Konstantin commented 2019-09-19 11:36:58 +02:00
Author
Copy Link

Added subscriber: @youthatninja

Added subscriber: @youthatninja
Brendon Murphy commented 2019-09-20 03:34:44 +02:00
Member
Copy Link

Added subscriber: @BrendonMurphy

Added subscriber: @BrendonMurphy
Brendon Murphy commented 2019-09-20 03:34:44 +02:00
Member
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Brendon Murphy self-assigned this 2019-09-20 03:34:44 +02:00
Brendon Murphy commented 2019-09-20 03:34:44 +02:00
Member
Copy Link

Thanks for the report and fix, I have removed the proportional pies from the viewport pie menus in nightly builds shortly after 2.80 release. I found it was too close to the pies already built in to Blender. I also decided that it's much better served as a panel pop up rather than a pie. As you've demonstrated above, there's issues with toggles and elements from the header menu the user may really need are not available. I may look at a custom menu for this one day in the future. Thanks again. Closing as resolved as the addon no longer exists.

Thanks for the report and fix, I have removed the proportional pies from the viewport pie menus in nightly builds shortly after 2.80 release. I found it was too close to the pies already built in to Blender. I also decided that it's much better served as a panel pop up rather than a pie. As you've demonstrated above, there's issues with toggles and elements from the header menu the user may really need are not available. I may look at a custom menu for this one day in the future. Thanks again. Closing as resolved as the addon no longer exists.
Konstantin commented 2019-09-20 10:22:47 +02:00
Author
Copy Link

Oh NO! OMG what have i done. Please do not remove this addon.
Yes it similar to built in, but it has much better options. I can control proportional edit with single 'O' button with out menu diving and interface clicking.
Please do not remove. Just a little fix and we all be happy. (:

Oh NO! OMG what have i done. Please do not remove this addon. Yes it similar to built in, but it has much better options. I can control proportional edit with single 'O' button with out menu diving and interface clicking. Please do not remove. Just a little fix and we all be happy. (:
Konstantin commented 2019-12-07 19:01:21 +01:00
Author
Copy Link

Changed status from 'Resolved' to: 'Archived'

Changed status from 'Resolved' to: 'Archived'
Konstantin commented 2019-12-07 19:01:21 +01:00
Author
Copy Link

Hello!
Could you please bring back proportional pie?
Because now to start using 2.81 i need manually reinstall fixed addon.
Its just one py file with one string changed.
This is nonsense!

Hello! Could you please bring back proportional pie? Because now to start using 2.81 i need manually reinstall fixed addon. Its just one py file with one string changed. This is nonsense!
Brendon Murphy commented 2019-12-08 23:22:39 +01:00
Member
Copy Link

hi, as 2.80 brought about many built in pies, the viewport pies and official pies were merged and the menu's that duplicated the new built in functions were removed. The proportional edit pies fell into this category. The current behavior of 'O"key to turn on/off then the Shift/O to access the menu works well and if pretty fast. The "Issue" with the viewport proportional pies was that they were missing an ui element/falloff type. With the switch on off in the addon only 7 of the 8 falloff types were available in the custom pie. The secondary issue of there being extra elements in proportional edit mode, as you noted above, demonstrates to me that proportional editing should not be a pie menu at all as there's not enough room for all the required elements. Thanks.

hi, as 2.80 brought about many built in pies, the viewport pies and official pies were merged and the menu's that duplicated the new built in functions were removed. The proportional edit pies fell into this category. The current behavior of 'O"key to turn on/off then the Shift/O to access the menu works well and if pretty fast. The "Issue" with the viewport proportional pies was that they were missing an ui element/falloff type. With the switch on off in the addon only 7 of the 8 falloff types were available in the custom pie. The secondary issue of there being extra elements in proportional edit mode, as you noted above, demonstrates to me that proportional editing should not be a pie menu at all as there's not enough room for all the required elements. Thanks.
Konstantin commented 2019-12-09 10:49:56 +01:00
Author
Copy Link

So why others pies left? like shading Z pie.
Why it cant be a good alternative? With this pie i can manipulate all proportional settings with one key
image.png
Its just a 14KB file. No one will suffer if it remains.
I assume a lot of people use it.

So why others pies left? like shading Z pie. Why it cant be a good alternative? With this pie i can manipulate all proportional settings with one key ![image.png](https://archive.blender.org/developer/F8201519/image.png) Its just a 14KB file. No one will suffer if it remains. I assume a lot of people use it.
Brendon Murphy commented 2019-12-09 11:59:43 +01:00
Member
Copy Link

Changed status from 'Archived' to: 'Open'

Changed status from 'Archived' to: 'Open'
Brendon Murphy commented 2019-12-09 11:59:43 +01:00
Member
Copy Link

@youthatninja ok, let's look at this. do you have a file with the fix? I can take a look.

@youthatninja ok, let's look at this. do you have a file with the fix? I can take a look.
Konstantin commented 2019-12-09 14:38:22 +01:00
Author
Copy Link

@BrendonMurphy, Sure
I found that it missing one falloff type 'inverse square'
pie_proportional_menu.py

@BrendonMurphy, Sure I found that it missing one falloff type 'inverse square' [pie_proportional_menu.py](https://archive.blender.org/developer/F8202045/pie_proportional_menu.py)
Konstantin commented 2019-12-09 15:45:02 +01:00
Author
Copy Link

I added inverse square to edit menu,
but i stuck with this problem in obj mode
https://developer.blender.org/T65256
Also projected should be toggle too, same issue as with connected
pie_proportional_menu.py

ts.use_proportional_projected = True >>> ts.use_proportional_projected ^= 1
I added inverse square to edit menu, but i stuck with this problem in obj mode https://developer.blender.org/T65256 Also projected should be toggle too, same issue as with connected [pie_proportional_menu.py](https://archive.blender.org/developer/F8204778/pie_proportional_menu.py) ``` ts.use_proportional_projected = True >>> ts.use_proportional_projected ^= 1 ```
Brendon Murphy commented 2019-12-11 11:19:42 +01:00
Member
Copy Link

hi @miller. I've rewritten the object and edit mode menus, all entries are accounted for. I added the sub menu to object mode to achieve this.. I've also re-ordered per level left to right in the same order as the default falloff type menu with the remaining entries in order in the sub menus. the connected only and projected from view in edit mode have been moved up to top left and right respectively. they work well enough I think.
The hotkey is now shift/o, I have design rules i like to stick to with the pie menus. the o key is a fast toggle, the shift/o is by default a pie menu. i'm leaving the toggle alone and this pie menu serves as an alternative to the built in proportional falloff pie. The results are pretty good, everything works I think.
unless there's anything else this task should be closed.

hi @miller. I've rewritten the object and edit mode menus, all entries are accounted for. I added the sub menu to object mode to achieve this.. I've also re-ordered per level left to right in the same order as the default falloff type menu with the remaining entries in order in the sub menus. the connected only and projected from view in edit mode have been moved up to top left and right respectively. they work well enough I think. The hotkey is now shift/o, I have design rules i like to stick to with the pie menus. the o key is a fast toggle, the shift/o is by default a pie menu. i'm leaving the toggle alone and this pie menu serves as an alternative to the built in proportional falloff pie. The results are pretty good, everything works I think. unless there's anything else this task should be closed.
Konstantin commented 2019-12-11 13:31:45 +01:00
Author
Copy Link

Hello, @BrendonMurphy!
Sounds great, much appreciated.
If every thing works fine and correct, I think we done here.
But i just realize that this pie only work in mesh edit mode and object mode, but not in curve edit mode nor UV editor and Grease Pencil ?

Hello, @BrendonMurphy! Sounds great, much appreciated. If every thing works fine and correct, I think we done here. But i just realize that this pie only work in mesh edit mode and object mode, but not in curve edit mode nor UV editor and Grease Pencil ?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#70062
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?