A.N.T.Landscape line artifacts if seed is NOT 0 #70357

New Issue

vicbay · 2019-09-29T16:34:28+02:00

vicbay commented

2019-09-29 16:34:28 +02:00

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.30

Blender Version
Broken: version: 2.81 (sub 12), branch: master, commit date: 2019-09-29 06:28, hash: blender/blender@ba90d2efa5
Also broken in 2.80 release.

Addon Information
Name: A.N.T.Landscape (0, 1, 8)
Author: Jimmy Hazevoet

Short description of error
A.N.T.Landscape line artifacts if Random Seed is NOT 0.

Exact steps for others to reproduce the error
landscape_lines.blend

Add landscape mesh (Shift+A -> Mesh -> Landscape)
Increase "Subdivisions X" and "Subdivisions Y" to 1024x1024.
Change "Noise Base" to "Perlin".
Change "Random Seed" to 1.

**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.30 **Blender Version** Broken: version: 2.81 (sub 12), branch: master, commit date: 2019-09-29 06:28, hash: `blender/blender@ba90d2efa5` Also broken in 2.80 release. **Addon Information** Name: A.N.T.Landscape (0, 1, 8) Author: Jimmy Hazevoet **Short description of error** A.N.T.Landscape line artifacts if Random Seed is NOT 0. **Exact steps for others to reproduce the error** [landscape_lines.blend](https://archive.blender.org/developer/F7779845/landscape_lines.blend) 1. Add landscape mesh (Shift+A -> Mesh -> Landscape) 2. Increase "Subdivisions X" and "Subdivisions Y" to 1024x1024. 3. Change "Noise Base" to "Perlin". 4. Change "Random Seed" to 1. ![Зауваження 2020-02-15 063233.png](https://archive.blender.org/developer/F8340809/Зауваження_2020-02-15_063233.png)

vicbay commented

2019-09-29 16:34:28 +02:00

Added subscriber: @vicbay

Philipp Oeser commented

2019-09-30 10:44:00 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-09-30 10:44:00 +02:00

Can confirm.

Brendon Murphy commented

2019-10-01 04:58:27 +02:00

Added subscriber: @BrendonMurphy

Brendon Murphy self-assigned this 2019-10-01 04:58:27 +02:00

Brendon Murphy commented

2019-10-01 04:58:27 +02:00

Can also confirm, I'll need to do some more tests here and find where/when/if it was broken. In testing I'm finding not all noise types are affected.
@lichtwerk anything changed here that may be the cause?

Can also confirm, I'll need to do some more tests here and find where/when/if it was broken. In testing I'm finding not all noise types are affected. @lichtwerk anything changed here that may be the cause?

Brendon Murphy commented

2019-10-09 01:34:50 +02:00

Hi, I've been testing this some more, no answers really. I have tried in today's build and found a workaround I think.
@vicbay can you create a landscape then in the presets open the default preset, up the subdivisions to 512, 512, then adjust the random seed.
This seems to work fine and also adds the smoothing to the mesh.
It's interesting @lichtwerk to get this result, I disabled the smoothing from the actual default, not the preset, as the smooth was drawing the objects black. Interesting that it works with the preset and that the random seed also seems to work.

Hi, I've been testing this some more, no answers really. I have tried in today's build and found a workaround I think. @vicbay can you create a landscape then in the presets open the default preset, up the subdivisions to 512, 512, then adjust the random seed. This seems to work fine and also adds the smoothing to the mesh. It's interesting @lichtwerk to get this result, I disabled the smoothing from the actual default, not the preset, as the smooth was drawing the objects black. Interesting that it works with the preset and that the random seed also seems to work.

vicbay commented

2019-10-09 02:21:10 +02:00

@BrendonMurphy
I can confirm workaround, although the "Default" preset and actual defaults are different.
Actual defaults, that are used when you don't choose any preset, they use Perlin noise.
"Default" preset uses Blender noise.

I generated another landscape in 4096 subdivisions. I can't attach blend file, because it is 200mb even compessed.
In such subdivisions resolution it looks like landscape is generated in some square chunks.
Artifacts appear on the borders of that chunks, making almost perfect grid.
Wrong interpolation calculation that creates infinity approach?

@BrendonMurphy I can confirm workaround, although the "Default" preset and actual defaults are different. Actual defaults, that are used when you don't choose any preset, they use Perlin noise. "Default" preset uses Blender noise. I generated another landscape in 4096 subdivisions. I can't attach blend file, because it is 200mb even compessed. In such subdivisions resolution it looks like landscape is generated in some square chunks. Artifacts appear on the borders of that chunks, making almost perfect grid. Wrong interpolation calculation that creates infinity approach? ![screen3.jpg](https://archive.blender.org/developer/F7797836/screen3.jpg) ![landscape4k_2.png](https://archive.blender.org/developer/F7797840/landscape4k_2.png)

Brendon Murphy was unassigned by Dalai Felinto

2019-12-23 13:48:53 +01:00

Richard Antalik commented

2020-02-15 03:55:14 +01:00

Added subscriber: @iss

Richard Antalik commented

2020-02-15 03:55:14 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Richard Antalik commented

2020-02-15 03:55:14 +01:00

I have re-triaged this report and can not reproduce it.
Can you please check if this is still an issue in latest build?
https://builder.blender.org/download/

I have re-triaged this report and can not reproduce it. Can you please check if this is still an issue in latest build? https://builder.blender.org/download/

vicbay commented

2020-02-15 05:33:33 +01:00

New steps to reproduce:

Add landscape mesh (Shift+A -> Mesh -> Landscape)
Increase "Subdivisions X" and "Subdivisions Y" to 1024x1024.
Change "Noise Base" to "Perlin".
Change "Random Seed" to 1.

New steps to reproduce: 1. Add landscape mesh (Shift+A -> Mesh -> Landscape) 2. Increase "Subdivisions X" and "Subdivisions Y" to 1024x1024. 3. Change "Noise Base" to "Perlin". 4. Change "Random Seed" to 1. ![Зауваження 2020-02-15 063233.png](https://archive.blender.org/developer/F8340809/Зауваження_2020-02-15_063233.png)

Ankit Meel commented

2020-05-02 21:01:15 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-05-02 21:01:15 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Ankit Meel commented

2020-05-02 21:01:15 +02:00

since the sibdivs made earlier made changing other settings a pain, I did this:
add landscape
change noise base
change seed
change subdivs
blender/blender@7df51ca11a

![image.png](https://archive.blender.org/developer/F8507965/image.png) since the sibdivs made earlier made changing other settings a pain, I did this: add landscape change noise base change seed change subdivs blender/blender@7df51ca11a

Brendon Murphy self-assigned this 2020-05-03 04:14:02 +02:00

Brendon Murphy commented

2020-05-03 04:14:02 +02:00

Added subscriber: @JimHazevoet

Brendon Murphy commented

2020-05-03 04:14:02 +02:00

hi, I'm claiming this task as I've been responsible for ANT in the past.
I've been in contact with ANT Author @JimHazevoet and his new collaborator and I'm receiving updates for a new version/updated version which are not ready for commit at this stage.
@ankitm Thanks, I'll test if anything has changed with the commit you mentioned.
I'm looking into this issue atm in the most basic way. lich
From what addons devs understand, this issue is a Bug/Issue with the Perlin_Original noise type built into Blender and how it's interacting with random. I think. @lichtwerk
This leads to 3 options.:
1/ Fix the Built in Original_Perlin noise type in Blender and allocate core dev time to do this.
(is it worth it?)
2/ Remove the Original_Perlin noise type from ANT Landscape.
(I'm testing this atm/in progress) This answer hides and avoids the issue not fixes it but may be practical.
3/ Wait until the new version of ANT is complete. This may take some time.

If 2 is the answer I'll need to go through ANT landscape code and remove the references to the Original Perlin Type and check use and replace with appropriate type. This may cause a back compat issue with some files but they would be rare and I have a workaround. I'm checking all the presets too, some require adjustment, it's not hard to do a find/replace to swap out the removed noise type, then adjust the presets if needed.

I may just do this anyway and remove the issue from the addon.

hi, I'm claiming this task as I've been responsible for ANT in the past. I've been in contact with ANT Author @JimHazevoet and his new collaborator and I'm receiving updates for a new version/updated version which are not ready for commit at this stage. @ankitm Thanks, I'll test if anything has changed with the commit you mentioned. I'm looking into this issue atm in the most basic way. lich From what addons devs understand, this issue is a Bug/Issue with the Perlin_Original noise type built into Blender and how it's interacting with random. I think. @lichtwerk This leads to 3 options.: 1/ Fix the Built in Original_Perlin noise type in Blender and allocate core dev time to do this. (is it worth it?) 2/ Remove the Original_Perlin noise type from ANT Landscape. (I'm testing this atm/in progress) This answer hides and avoids the issue not fixes it but may be practical. 3/ Wait until the new version of ANT is complete. This may take some time. If 2 is the answer I'll need to go through ANT landscape code and remove the references to the Original Perlin Type and check use and replace with appropriate type. This may cause a back compat issue with some files but they would be rare and I have a workaround. I'm checking all the presets too, some require adjustment, it's not hard to do a find/replace to swap out the removed noise type, then adjust the presets if needed. I may just do this anyway and remove the issue from the addon.

Brendon Murphy commented

2020-05-04 04:23:45 +02:00

hi, Fix is incoming within a couple of days.
File for testing:
ant_landscape.zip

hi, Fix is incoming within a couple of days. File for testing: [ant_landscape.zip](https://archive.blender.org/developer/F8510699/ant_landscape.zip)

blender-admin commented

2020-05-07 02:44:18 +02:00

This issue was referenced by 7fd30539c6

This issue was referenced by 7fd30539c69ce4aa3363e0d7c5e00ff4ca13886b

blender-admin commented

2020-05-07 02:44:18 +02:00

This issue was referenced by 0af9a7b3c4

This issue was referenced by 0af9a7b3c440cb4ad039e791c7c3a1c248793c2e