Blender 2.81 - Crash when deleting scene from timers API #71422

New Issue

notallowed · 2019-11-08T12:46:26+01:00

notallowed commented

2019-11-08 12:46:26 +01:00

System Information
Operating system: Linux-5.0.0-32-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-06 20:48, hash: blender/blender@85637311c2

Short description of error
Blender crashes if scene is deleted from timers API

Exact steps for others to reproduce the error

Open blend file:
scene_remove_crash.blend
Run script.
Crash.

**System Information** Operating system: Linux-5.0.0-32-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21 **Blender Version** Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-06 20:48, hash: `blender/blender@85637311c2` **Short description of error** Blender crashes if scene is deleted from timers API **Exact steps for others to reproduce the error** 1. Open blend file: [scene_remove_crash.blend](https://archive.blender.org/developer/F7987704/scene_remove_crash.blend) 2. Run script. 3. Crash.

notallowed commented

2019-11-08 12:46:26 +01:00

Added subscriber: @simon_lusenc

Germano Cavalcante commented

2019-11-11 14:24:28 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-11-11 14:24:28 +01:00

I may be wrong, but I find it strange that CTX_wm_window(C) is NULL in this case.
Without getting into the real reason for the problem, this patch seems to solve the problem:

diff --git a/source/blender/makesrna/intern/rna_main_api.c b/source/blender/makesrna/intern/rna_main_api.c
index 2c42dba9131..23ceedd63d0 100644
--- a/source/blender/makesrna/intern/rna_main_api.c
+++ b/source/blender/makesrna/intern/rna_main_api.c
@@ -183,15 +183,15 @@ static void rna_Main_scenes_remove(
 
   if ((scene_new = scene->id.prev) || (scene_new = scene->id.next)) {
     if (do_unlink) {
-      wmWindow *win = CTX_wm_window(C);
+      Scene *scene_act = CTX_data_scene(C);
 
-      if (WM_window_get_active_scene(win) == scene) {
+      if (scene_act == scene) {
 
 #  ifdef WITH_PYTHON
         BPy_BEGIN_ALLOW_THREADS;
 #  endif
 
-        WM_window_set_active_scene(bmain, C, win, scene_new);
+        CTX_data_scene_set(C, scene_new);
 
 #  ifdef WITH_PYTHON
         BPy_END_ALLOW_THREADS;

But I will wait for a second opinion.

I may be wrong, but I find it strange that `CTX_wm_window(C)` is `NULL` in this case. Without getting into the real reason for the problem, this patch seems to solve the problem: ``` diff --git a/source/blender/makesrna/intern/rna_main_api.c b/source/blender/makesrna/intern/rna_main_api.c index 2c42dba9131..23ceedd63d0 100644 --- a/source/blender/makesrna/intern/rna_main_api.c +++ b/source/blender/makesrna/intern/rna_main_api.c @@ -183,15 +183,15 @@ static void rna_Main_scenes_remove( if ((scene_new = scene->id.prev) || (scene_new = scene->id.next)) { if (do_unlink) { - wmWindow *win = CTX_wm_window(C); + Scene *scene_act = CTX_data_scene(C); - if (WM_window_get_active_scene(win) == scene) { + if (scene_act == scene) { # ifdef WITH_PYTHON BPy_BEGIN_ALLOW_THREADS; # endif - WM_window_set_active_scene(bmain, C, win, scene_new); + CTX_data_scene_set(C, scene_new); # ifdef WITH_PYTHON BPy_END_ALLOW_THREADS; ``` But I will wait for a second opinion.

Philipp Oeser commented

2019-11-11 14:55:12 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-11-11 14:55:12 +01:00

Note there are similar reports open blender/blender#62074 (2.8: Python API: crash due to missing window context in Application timer), blender/blender#71383 (2.8: Python API: window's workspace can't be set in Application timer).

Workaround [before the main issue id fixed] [next to the solution @mano-wii provided] is to use an operator with a custom context:

import bpy

class TestOperator(bpy.types.Operator):
    bl_idname = "scene.test_operator"
    bl_label = "Test Operator"

    def execute(self, context):
        bpy.data.scenes.remove(context.scene)
        return {'FINISHED'}

bpy.utils.register_class(TestOperator)

def tick():
    window = bpy.context.window_manager.windows[0]
    ctx = {'window': window, 'screen': window.screen, 'scene': bpy.data.scenes['Scene.001']}  
    bpy.ops.scene.test_operator(ctx)
    
    return 5.0

bpy.app.timers.register(tick)

Note there are similar reports open blender/blender#62074 (2.8: Python API: crash due to missing window context in Application timer), blender/blender#71383 (2.8: Python API: window's workspace can't be set in Application timer). Workaround [before the main issue id fixed] [next to the solution @mano-wii provided] is to use an operator with a custom context: ``` import bpy class TestOperator(bpy.types.Operator): bl_idname = "scene.test_operator" bl_label = "Test Operator" def execute(self, context): bpy.data.scenes.remove(context.scene) return {'FINISHED'} bpy.utils.register_class(TestOperator) def tick(): window = bpy.context.window_manager.windows[0] ctx = {'window': window, 'screen': window.screen, 'scene': bpy.data.scenes['Scene.001']} bpy.ops.scene.test_operator(ctx) return 5.0 bpy.app.timers.register(tick) ```

Philipp Oeser commented

2019-11-11 14:59:31 +01:00

@mano-wii: think we should merge this into blender/blender#62074? (since the underlying problem is really the same here...)
(next to your solution which seems good to have anyways? -- but would be sure on this one either...)

@mano-wii: think we should merge this into blender/blender#62074? (since the underlying problem is really the same here...) (next to your solution which seems good to have anyways? -- but would be sure on this one either...)

Germano Cavalcante commented

2019-11-11 15:10:19 +01:00

Closed as duplicate of blender/blender#62074

Germano Cavalcante closed this issue

2019-11-11 15:10:19 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender 2.81 - Crash when deleting scene from timers API #71422