Add-on's and app-template installation ignores file permissions (execution flag) #73074
Labels
No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-addons#73074
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Extracting zip-files from Python ignores file permissions, see this report .
This causes issues for anyone including executable scripts or binaries in the add-ons.
Extracting the zip on the command line with
unzip
works as expected.This task proposes to to support only the executable bit when extracting files, ignoring all other permissions to avoid complications caused by non-default file permissions.
Original Report
System Information
Operating system: macOS Catalina
Graphics card: rx580
Blender Version
Broken: from 2.80 to 2.83
While importing an add-on (animationrender)
GitHub.com/thebadking/animationrender
The binary terminal-notifier gets destroyed and won't work. It will work fine if decompressed manually.
Path: /modules/pync/vendor/terminal-notifier-2.0.0/terminal-notifier.app
Added subscriber: @TheBadKing
Added subscriber: @ideasman42
Changed status from 'Needs Triage' to: 'Archived'
Closing as this isn't part of Blender and there is no evidence this a bug in Blender,
the issue should instead be reported to the add-on.
Did you read the part where I said decompressed manually does not break the binary?
Yes, since the report was vague, I didn't think it necessarily pointed to an error in Blender, when 3rd party add-ons are involved, there needs to details about why the issue is with Blender, not the add-on.
Looking into the differences between Python's zipfile support and manually extracting - this is caused by https://bugs.python.org/issue15795 there are some workarounds for this online, however I think we only want the execution mask to be set, since non-default permissions could cause issues later on.
Marking this as a TODO since it could be supported.
Changed status from 'Archived' to: 'Confirmed'
Blender breaks binary inside of zip file while importing.to Add-on's and app-template installation ignores file permissions (execution flag)