Add-on's and app-template installation ignores file permissions (execution flag) #73074

New Issue

André Ferreira · 2020-01-12T20:05:58+01:00

André Ferreira commented

2020-01-12 20:05:58 +01:00

Extracting zip-files from Python ignores file permissions, see this report .

This causes issues for anyone including executable scripts or binaries in the add-ons.

Extracting the zip on the command line with unzip works as expected.

This task proposes to to support only the executable bit when extracting files, ignoring all other permissions to avoid complications caused by non-default file permissions.

Original Report

System Information
Operating system: macOS Catalina
Graphics card: rx580

Blender Version
Broken: from 2.80 to 2.83

While importing an add-on (animationrender)
GitHub.com/thebadking/animationrender
The binary terminal-notifier gets destroyed and won't work. It will work fine if decompressed manually.

Path: /modules/pync/vendor/terminal-notifier-2.0.0/terminal-notifier.app

Extracting zip-files from Python ignores file permissions, see [this report ](https://bugs.python.org/issue15795). This causes issues for anyone including executable scripts or binaries in the add-ons. Extracting the zip on the command line with `unzip` works as expected. This task proposes to to support only the executable bit when extracting files, ignoring all other permissions to avoid complications caused by non-default file permissions. ---- *Original Report* **System Information** Operating system: macOS Catalina Graphics card: rx580 **Blender Version** Broken: from 2.80 to 2.83 While importing an add-on (animationrender) GitHub.com/thebadking/animationrender The binary terminal-notifier gets destroyed and won't work. It will work fine if decompressed manually. Path: /modules/pync/vendor/terminal-notifier-2.0.0/terminal-notifier.app

André Ferreira commented

2020-01-12 20:05:58 +01:00

Added subscriber: @TheBadKing

Campbell Barton commented

2020-01-13 06:59:51 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2020-01-13 06:59:51 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Campbell Barton closed this issue

2020-01-13 06:59:51 +01:00

Campbell Barton self-assigned this 2020-01-13 06:59:51 +01:00

Campbell Barton commented

2020-01-13 06:59:51 +01:00

Closing as this isn't part of Blender and there is no evidence this a bug in Blender,
the issue should instead be reported to the add-on.

Closing as this isn't part of Blender and there is no evidence this a bug in Blender, the issue should instead be reported to the add-on.

André Ferreira commented

2020-01-13 07:35:20 +01:00

Did you read the part where I said decompressed manually does not break the binary?

Campbell Barton commented

2020-01-14 07:46:45 +01:00

Yes, since the report was vague, I didn't think it necessarily pointed to an error in Blender, when 3rd party add-ons are involved, there needs to details about why the issue is with Blender, not the add-on.

Looking into the differences between Python's zipfile support and manually extracting - this is caused by https://bugs.python.org/issue15795 there are some workarounds for this online, however I think we only want the execution mask to be set, since non-default permissions could cause issues later on.

Marking this as a TODO since it could be supported.

Yes, since the report was vague, I didn't think it necessarily pointed to an error in Blender, when 3rd party add-ons are involved, there needs to details about why the issue is with Blender, not the add-on. Looking into the differences between Python's zipfile support and manually extracting - this is caused by https://bugs.python.org/issue15795 there are some workarounds for this online, however I think we only want the execution mask to be set, since non-default permissions could cause issues later on. Marking this as a TODO since it could be supported.

Campbell Barton commented

2020-01-14 07:48:22 +01:00

Changed status from 'Archived' to: 'Confirmed'

Campbell Barton reopened this issue

2020-01-14 07:48:22 +01:00

Campbell Barton changed title from ~~Blender breaks binary inside of zip file while importing.~~ to Add-on's and app-template installation ignores file permissions (execution flag)

2020-01-14 07:53:24 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Add-on's and app-template installation ignores file permissions (execution flag) #73074