Blender crash when disabling BlenderKit addon while viewport is in "solid" shading mode #73467

Closed
opened 2020-01-28 22:11:05 +01:00 by Casey Connor · 10 comments

(There are other bugs with BlenderKit that I'll report, but since this one crashes Blender, I assumed this is a Blender bug?)

System Information
Operating system: Linux-4.18.0-25-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116

Blender Version
Broken: version: 2.83 (sub 1), branch: master, commit date: 2020-01-28 16:02, hash: blender/blender@a5790b2656

Short description of error

Blender crashes when enabling BlenderKit and then disabling it, e.g. if clicking a few times on the enable/disable checkbox

Exact steps for others to reproduce the error

  • start blender with fresh config directory
  • open prefs, go to Add-Ons, enter "blenderkit" in the filter field
  • enable addon with the checkbox, then disable it
  • Blender crashes:

Blender 2.83 (sub 1), Commit date: 2020-01-28 16:02, Hash a5790b26563c

bpy.data.window_managers["WinMan"].addon_search = "blenderkit" # Property

backtrace

/path/to/blender/blender-2.83-a5790b26563c-linux-glibc217-x86_64/blender(BLI_system_backtrace+0x1d) [0x6fc38ad]
/path/to/blender/blender-2.83-a5790b26563c-linux-glibc217-x86_64/blender() [0x16582a2]
/lib/x86_64-linux-gnu/libc.so.6(+0x41100) [0x7ff241d23100]
[0x7ff20ee48070]


Update: this seems to happen only in "solid" shading mode in the viewport. If I switch to e.g. Material Preview, the crash doesn't seem to happen.

(There are other bugs with BlenderKit that I'll report, but since this one crashes Blender, I assumed this is a Blender bug?) **System Information** Operating system: Linux-4.18.0-25-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116 **Blender Version** Broken: version: 2.83 (sub 1), branch: master, commit date: 2020-01-28 16:02, hash: `blender/blender@a5790b2656` **Short description of error** Blender crashes when enabling BlenderKit and then disabling it, e.g. if clicking a few times on the enable/disable checkbox **Exact steps for others to reproduce the error** * start blender with fresh config directory * open prefs, go to Add-Ons, enter "blenderkit" in the filter field * enable addon with the checkbox, then disable it * Blender crashes: # Blender 2.83 (sub 1), Commit date: 2020-01-28 16:02, Hash a5790b26563c bpy.data.window_managers["WinMan"].addon_search = "blenderkit" # Property # backtrace /path/to/blender/blender-2.83-a5790b26563c-linux-glibc217-x86_64/blender(BLI_system_backtrace+0x1d) [0x6fc38ad] /path/to/blender/blender-2.83-a5790b26563c-linux-glibc217-x86_64/blender() [0x16582a2] /lib/x86_64-linux-gnu/libc.so.6(+0x41100) [0x7ff241d23100] [0x7ff20ee48070] --------------------------------- Update: this seems to happen only in "solid" shading mode in the viewport. If I switch to e.g. Material Preview, the crash doesn't seem to happen.
Author

Added subscriber: @clepsydrae

Added subscriber: @clepsydrae
Casey Connor changed title from Blender crash when disabling BlenderKit addon to Blender crash when disabling BlenderKit addon while viewport is in "solid" shading mode 2020-01-28 22:24:23 +01:00
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Member

Tried, but was not able to reproduce this, even with given commit. Even with ASan enabled, which should definitely cause a crash or warning on illegal memory usage.

Tried, but was not able to reproduce this, even with given commit. Even with ASan enabled, which should definitely cause a crash or warning on illegal memory usage.
Author

I can't reproduce it on my other Linux system either (old/slow Lubuntu netbook) but it happens every time on my Kubuntu desktop... anything else I can do to help explore this?

I don't think this will help given what I've heard from devs, and I don't know anything about all this, but following some online instructions I went down this gdb hole, in case there are any clues in here somewhere: blenderkitcrash.txt

I can't reproduce it on my other Linux system either (old/slow Lubuntu netbook) but it happens every time on my Kubuntu desktop... anything else I can do to help explore this? I don't think this will help given what I've heard from devs, and I don't know anything about all this, but following some online instructions I went down this gdb hole, in case there are any clues in here somewhere: [blenderkitcrash.txt](https://archive.blender.org/developer/F8312421/blenderkitcrash.txt)
Member

Added subscriber: @VilemDuha

Added subscriber: @VilemDuha
Member

I actually experienced this bug too and I hope I already fixed it in BlenderKit.

But it's actually some registration bug that is specific to Blender. I found out that it happens due to un-registation unregistering BlenderKit properties before unregistering the UI - then a menu draw call crashed Blender. Now I check in the ui draw code if the addon is registered - this hopefully fixed the problem.

I actually experienced this bug too and I hope I already fixed it in BlenderKit. But it's actually some registration bug that is specific to Blender. I found out that it happens due to un-registation unregistering BlenderKit properties before unregistering the UI - then a menu draw call crashed Blender. Now I check in the ui draw code if the addon is registered - this hopefully fixed the problem.
Author

Yeah, downloaded the latest (cad09e5227df) and no more crash! Thanks!

Yeah, downloaded the latest (cad09e5227df) and no more crash! Thanks!

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'
Member

After 2 days of testing, I can now assume I fixed this bug successfully (committed to 2.82 master). If you experience it again, please reopen.

After 2 days of testing, I can now assume I fixed this bug successfully (committed to 2.82 master). If you experience it again, please reopen.
Member

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'
Vilem Duha self-assigned this 2020-02-08 10:51:39 +01:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#73467
No description provided.