Node wrangler's node previewer not working with ProRender #73882

New Issue

Le Giang · 2020-02-16T14:33:42+01:00

Le Giang commented

2020-02-16 14:33:42 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Radeon (TM) RX 470 Graphics ATI Technologies Inc. 4.5.13586 Core Profile Context 20.1.3 26.20.15015.1007

Blender Version
Broken: version: 2.82 (sub 7), branch: master, commit date: 2020-02-12 16:20, hash: blender/blender@77d23b0bd7
Worked: (optional)

Addon Information
Name: Node Wrangler (3, 36)
Author: Bartek Skorupa, Greg Zaal, Sebastian Koenig, Christian Brinkmann, Florian Meyer

Short description of error
Materials previewer not working with ProRender

Exact steps for others to reproduce the error

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: Radeon (TM) RX 470 Graphics ATI Technologies Inc. 4.5.13586 Core Profile Context 20.1.3 26.20.15015.1007 **Blender Version** Broken: version: 2.82 (sub 7), branch: master, commit date: 2020-02-12 16:20, hash: `blender/blender@77d23b0bd7` Worked: (optional) **Addon Information** Name: Node Wrangler (3, 36) Author: Bartek Skorupa, Greg Zaal, Sebastian Koenig, Christian Brinkmann, Florian Meyer **Short description of error** Materials previewer not working with ProRender **Exact steps for others to reproduce the error** ![bug_report.gif](https://archive.blender.org/developer/F8343084/bug_report.gif)

Le Giang commented

2020-02-16 14:33:42 +01:00

Added subscriber: @jangst.1024

Philipp Oeser commented

2020-02-17 11:42:48 +01:00

Added subscribers: @GregZaal, @BartekSkorupa, @sebastian_k, @brecht, @lichtwerk

Philipp Oeser commented

2020-02-17 11:42:48 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2020-02-17 11:42:48 +01:00

Well, nodewrangler is explicitly checking for Cycles or Eevee in a couple of places (for example this exact operator has it in its poll() function, so wont do anything here if not Cycles or Eevee).
Not sure if we should open up for other render engines here?
Could be that they dont support ShaderNodeEmission, what then?

Maybe we can check https://docs.blender.org/api/master/bpy.types.RenderEngine.html#bpy.types.RenderEngine.bl_use_shading_nodes_custom here, but I recall this is not used consistently, see blender/blender#68473 (Custom RenderEngine: Shader Editor issues)

Assume this is is not considered a bug, but would like other opinions here...
CC @brecht
CC @BartekSkorupa
CC @sebastian_k
CC @GregZaal

Well, nodewrangler is explicitly checking for Cycles or Eevee in a couple of places (for example this exact operator has it in its poll() function, so wont do anything here if not Cycles or Eevee). Not sure if we should open up for other render engines here? Could be that they dont support `ShaderNodeEmission`, what then? Maybe we can check https://docs.blender.org/api/master/bpy.types.RenderEngine.html#bpy.types.RenderEngine.bl_use_shading_nodes_custom here, but I recall this is not used consistently, see blender/blender#68473 (Custom RenderEngine: Shader Editor issues) Assume this is is not considered a bug, but would like other opinions here... CC @brecht CC @BartekSkorupa CC @sebastian_k CC @GregZaal

blender-admin commented

2020-03-04 08:53:39 +01:00

This issue was referenced by 9896bbdb4e

This issue was referenced by 9896bbdb4e2f786a2bb3c649a17a9659471140c1

Brecht Van Lommel commented

2020-03-04 08:59:44 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Brecht Van Lommel closed this issue

2020-03-04 08:59:44 +01:00

Brecht Van Lommel self-assigned this 2020-03-04 08:59:44 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node wrangler's node previewer not working with ProRender #73882