blender/blender-addons
19
43
Fork 96
Code Issues 628 Pull Requests 27 Projects 1 Releases Wiki Activity

Crash when ctrl-shift-click with node-wrangler in pinned window #76226

New Issue
Closed
opened 2020-04-29 12:29:27 +02:00 by user1 · 11 comments
user1 commented 2020-04-29 12:29:27 +02:00
Copy Link

System Information
Operating system: Linux-5.3.0-46-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GT 630/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116

Blender Version
Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-04-26 22:57, hash: blender/blender@13abd3784a
Worked: (newest version of Blender that worked as expected)

Short description of error
Crash when ctrl-shift-click with node-wrangler in pinned window

Exact steps for others to reproduce the error
Select an object which has nodes in the materials.
Pin the shading editor window,
(Select another object. -- @lichtwerk : wasnt neccessary in my tests...)
Ctrl-shift-click onto a node in the pinned view.
Crash?screen.png
Pinned-view-crash.blend

**System Information** Operating system: Linux-5.3.0-46-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GT 630/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116 **Blender Version** Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-04-26 22:57, hash: `blender/blender@13abd3784a` Worked: (newest version of Blender that worked as expected) **Short description of error** Crash when ctrl-shift-click with node-wrangler in pinned window **Exact steps for others to reproduce the error** Select an object which has nodes in the materials. Pin the shading editor window, (Select another object. -- @lichtwerk : wasnt neccessary in my tests...) Ctrl-shift-click onto a node in the pinned view. Crash?![screen.png](https://archive.blender.org/developer/F8500917/screen.png) [Pinned-view-crash.blend](https://archive.blender.org/developer/F8500919/Pinned-view-crash.blend)
user1 commented 2020-04-29 12:29:27 +02:00
Author
Copy Link

Added subscriber: @user1

Added subscriber: @user1
Philipp Oeser commented 2020-04-29 13:00:49 +02:00
Member
Copy Link

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser commented 2020-04-29 13:00:49 +02:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Philipp Oeser commented 2020-04-29 13:00:49 +02:00
Member
Copy Link

Confirmed, checking...

Confirmed, checking...
Alaska commented 2020-04-29 13:02:49 +02:00
Member
Copy Link

Added subscriber: @Alaska

Added subscriber: @Alaska
Alaska commented 2020-04-29 13:02:49 +02:00
Member
Copy Link

Can also recreate this same bug with 2.90 3ea67e08fe8e on Linux with a GTX 1050ti 440.64.

Can also recreate this same bug with 2.90 3ea67e08fe8e on Linux with a GTX 1050ti 440.64.
Philipp Oeser commented 2020-04-29 13:55:11 +02:00
Member
Copy Link

Added subscribers: @hlorus, @JacquesLucke, @GregZaal

Added subscribers: @hlorus, @JacquesLucke, @GregZaal
Philipp Oeser commented 2020-04-29 13:55:11 +02:00
Member
Copy Link

Looks like this is caused by 8dbd8a8d92

(havent looked at code, seems like it exposes some blender bug?)

snode->id is NULL here

1 node_area_refresh                    space_node.c      497 0x3b02831 
2 ED_area_do_refresh                   area.c            182 0x3551e48 
3 wm_event_do_refresh_wm_and_depsgraph wm_event_system.c 380 0x2eb5bdb 
4 wm_event_do_notifiers                wm_event_system.c 550 0x2eb6354 
5 WM_main                              wm.c              453 0x2eb19eb 
6 main                                 creator.c         524 0x2a6eba0

CC @JacquesLucke
CC @hlorus
CC @GregZaal

Looks like this is caused by 8dbd8a8d92 (havent looked at code, seems like it exposes some blender bug?) `snode->id` is NULL here ``` 1 node_area_refresh space_node.c 497 0x3b02831 2 ED_area_do_refresh area.c 182 0x3551e48 3 wm_event_do_refresh_wm_and_depsgraph wm_event_system.c 380 0x2eb5bdb 4 wm_event_do_notifiers wm_event_system.c 550 0x2eb6354 5 WM_main wm.c 453 0x2eb19eb 6 main creator.c 524 0x2a6eba0 ``` CC @JacquesLucke CC @hlorus CC @GregZaal
David Friedli commented 2020-04-29 15:57:44 +02:00
Copy Link

The crash happens because the operator tries to set the nodetree and path of the shader editor space. This was used because nodes were removed by calling the operator nodes.delete which was rather hacky.

D7567 should fix this. Would be great if someone could double check.

The crash happens because the operator tries to set the nodetree and path of the shader editor space. This was used because nodes were removed by calling the operator nodes.delete which was rather hacky. [D7567](https://archive.blender.org/developer/D7567) should fix this. Would be great if someone could double check.
blender-admin commented 2020-04-29 16:05:08 +02:00
Copy Link

This issue was referenced by 1bc96468a1

This issue was referenced by 1bc96468a144750348ea6b134d4aaf457d7cc6cf
Jacques Lucke commented 2020-04-29 16:07:41 +02:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Jacques Lucke self-assigned this 2020-04-29 16:07:41 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Jacques Lucke
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#76226
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?