.WRL imports without material fix #76656

New Issue

Adam · 2020-05-11T22:08:15+02:00

Adam commented

2020-05-11 22:08:15 +02:00

System Information
Operating system: Windows 10 Pro 64-bit
Graphics card: NVIDIA GeForce RTX 2070

Blender Version
Broken: 2.8+
.wrl file import does not show colors.
Working: 2.79

Short description of error
The cause of that is return in 2699th line of code in import_x3d.py which returns the method. Moreover, the color vectors need alpha value to be added.
fix:

def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol):
    bpymat = bpy.data.materials.new(vrmlname)
    diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry)
    
    if(len(diff_color) == 3):
        # .wrl does not have alpha, we need to add 4th element
        diff_color = diff_color+[1]
    bpymat.diffuse_color = diff_color

    bpymat.specular_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0], ancestry)

    if False and is_vcol:
        bpymat.use_vertex_color_paint = True
    return bpymat

**System Information** Operating system: Windows 10 Pro 64-bit Graphics card: NVIDIA GeForce RTX 2070 **Blender Version** Broken: 2.8+ .wrl file import does not show colors. Working: 2.79 **Short description of error** The cause of that is return in 2699th line of code in import_x3d.py which returns the method. Moreover, the color vectors need alpha value to be added. fix: ``` def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol): bpymat = bpy.data.materials.new(vrmlname) diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry) if(len(diff_color) == 3): # .wrl does not have alpha, we need to add 4th element diff_color = diff_color+[1] bpymat.diffuse_color = diff_color bpymat.specular_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0], ancestry) if False and is_vcol: bpymat.use_vertex_color_paint = True return bpymat ```

Adam commented

2020-05-11 22:08:16 +02:00

Added subscriber: @adammak

Germano Cavalcante commented

2020-05-11 22:21:01 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-05-11 22:21:01 +02:00

Is this a suggestion to fix #71232?
If so, you should submit a diff through the https://developer.blender.org/differential/diff/create/
or just add a comment there.

Is this a suggestion to fix #71232? If so, you should submit a diff through the https://developer.blender.org/differential/diff/create/ or just add a comment there.

Adam commented

2020-05-11 23:08:19 +02:00

In #76656#929238, @mano-wii wrote:
Is this a suggestion to fix #71232?
If so, you should submit a diff through the https://developer.blender.org/differential/diff/create/
or just add a comment there.

Thanks! i did that, i know this might not be right place to ask, but should i specify a reviewers for it or i don't have to?

> In #76656#929238, @mano-wii wrote: > Is this a suggestion to fix #71232? > If so, you should submit a diff through the https://developer.blender.org/differential/diff/create/ > or just add a comment there. Thanks! i did that, i know this might not be right place to ask, but should i specify a reviewers for it or i don't have to?

Ankit Meel commented

2020-05-12 09:02:15 +02:00

Added subscriber: @ankitm