Addon: Tri-lighting is broken on redo [if no camera was present to begin with] #76900

Closed
opened 2020-05-20 02:54:56 +02:00 by Julian Mohr · 7 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.90 (sub 2), branch: master, commit date: 2020-05-18 11:29, hash: blender/blender@18dd289e1a
Worked: (newest version of Blender that worked as expected)

Short description of error
tri-lightning Addon will mess up if no camera was previous definded.

Exact steps for others to reproduce the error
delete the camera activate tri-lighting then change the settings.
2020-05-20 02-42-30.mp4

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87 **Blender Version** Broken: version: 2.90 (sub 2), branch: master, commit date: 2020-05-18 11:29, hash: `blender/blender@18dd289e1a` Worked: (newest version of Blender that worked as expected) **Short description of error** tri-lightning Addon will mess up if no camera was previous definded. **Exact steps for others to reproduce the error** delete the camera activate tri-lighting then change the settings. [2020-05-20 02-42-30.mp4](https://archive.blender.org/developer/F8544083/2020-05-20_02-42-30.mp4)
Author

Added subscriber: @Jewls

Added subscriber: @Jewls
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Note this has nothing to do with the imported object (can be reproduced with the default Cube).

This only fails when there is no Camera in the scene already.
Then the Addon adds a camera, calls camera_to_viewand goes into top view [this all works as expected].

On redo, the Camera aligns with the top view [this should not happen], thus the following code does senseless things [3 point lighting depends on the camera].
So looks like camera_to_view is called again... needs further investigation.

Note this has nothing to do with the imported object (can be reproduced with the default Cube). This only fails when there is no Camera in the scene already. Then the Addon adds a camera, calls `camera_to_view`and goes into top view [this all works as expected]. On redo, the Camera aligns with the top view [this should not happen], thus the following code does senseless things [3 point lighting depends on the camera]. So looks like `camera_to_view` is called again... needs further investigation.
Philipp Oeser changed title from Addon: Tri-lighting is broken after importing objects to Addon: Tri-lighting is broken on redo [if no camera was present to begin with] 2020-05-20 12:31:43 +02:00
Author

have updated task description to bring it back to the right track

have updated task description to bring it back to the right track

This issue was referenced by 084eec3697

This issue was referenced by 084eec36977c9a084aa020031f4a1aa0f0352170
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Jacques Lucke self-assigned this 2020-06-03 10:56:41 +02:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#76900
No description provided.