blender/blender-addons
19
43
Fork 96
Code Issues 629 Pull Requests 27 Projects 1 Releases Wiki Activity

Unable to add extra objects if an empty is selected #82405

New Issue
Closed
opened 2020-11-04 18:34:14 +01:00 by Antti Katajamäki · 8 comments
Antti Katajamäki commented 2020-11-04 18:34:14 +01:00
Copy Link

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.09

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-04 00:13, hash: blender/blender@101c3d4ce4
Worked: 2.82

Addon Information
Name: Extra Objects (0, 3, 7)
Author: Multiple Authors

Short description of error
If an empty object is selected (active) one cannot add roundcube, torus objects, gears, pipe joints, diamonds or extras.

Exact steps for others to reproduce the error

  1. Open blender
  2. Enable extra objects add on
  3. Add empty
  4. Try to add roundcube, torus objects, gears, pipe joints, diamonds or extras.

extra_objects_issue.blend

blender_debug_output.txt

blender_system_info.txt

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.09 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-04 00:13, hash: `blender/blender@101c3d4ce4` Worked: 2.82 **Addon Information** Name: Extra Objects (0, 3, 7) Author: Multiple Authors **Short description of error** If an empty object is selected (active) one cannot add roundcube, torus objects, gears, pipe joints, diamonds or extras. **Exact steps for others to reproduce the error** 1. Open blender 2. Enable extra objects add on 3. Add empty 4. Try to add roundcube, torus objects, gears, pipe joints, diamonds or extras. [extra_objects_issue.blend](https://archive.blender.org/developer/F9197818/extra_objects_issue.blend) [blender_debug_output.txt](https://archive.blender.org/developer/F9197820/blender_debug_output.txt) [blender_system_info.txt](https://archive.blender.org/developer/F9197822/blender_system_info.txt)
Antti Katajamäki commented 2020-11-04 18:34:14 +01:00
Author
Copy Link

Added subscriber: @Antti-1

Added subscriber: @Antti-1
Robert Guetzkow commented 2020-11-04 18:54:44 +01:00
Member
Copy Link

Added subscriber: @rjg

Added subscriber: @rjg
Robert Guetzkow commented 2020-11-04 18:54:44 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Robert Guetzkow commented 2020-11-04 18:54:44 +01:00
Member
Copy Link

I can confirm this issue. This is caused by the check ('some-string-here' in context.active_object.data.keys()) and (self.change == True):, because an Empty doesn't have data and you can't call keys() on None. This bug can be found in:

  • add_mesh_beam_builder.py
  • add_mesh_gears.py
  • add_mesh_gemstones.py
  • add_mesh_honeycomb.py
  • add_mesh_pipe_joint.py
  • add_mesh_pyramid.py
  • add_mesh_round_cube.py
  • add_mesh_star.py
  • add_mesh_supertoroid.py
  • add_mesh_torus_knot.py
  • add_mesh_twisted_torus.py
  • Wallfactory.py

This also affects the Bolt Factory add-on:

  • BoldFactory.py

This also affects Geodesic Domes:

  • third_domes_panel_271.py
I can confirm this issue. This is caused by the check `('some-string-here' in context.active_object.data.keys()) and (self.change == True):`, because an *Empty* doesn't have `data` and you can't call `keys()` on `None`. This bug can be found in: - add_mesh_beam_builder.py - add_mesh_gears.py - add_mesh_gemstones.py - add_mesh_honeycomb.py - add_mesh_pipe_joint.py - add_mesh_pyramid.py - add_mesh_round_cube.py - add_mesh_star.py - add_mesh_supertoroid.py - add_mesh_torus_knot.py - add_mesh_twisted_torus.py - Wallfactory.py This also affects the Bolt Factory add-on: - BoldFactory.py This also affects Geodesic Domes: - third_domes_panel_271.py
Robert Guetzkow self-assigned this 2020-11-04 19:01:09 +01:00
Vladimir Spivak commented 2020-11-04 20:17:51 +01:00
Member
Copy Link

Added subscriber: @cwolf3d

Added subscriber: @cwolf3d
Robert Guetzkow was unassigned by Vladimir Spivak 2020-11-05 20:28:37 +01:00
Vladimir Spivak commented 2020-11-05 20:28:37 +01:00
Member
Copy Link

I tested this patch, everything works. You can apply it. Thanks for your work.

I tested this patch, everything works. You can apply it. Thanks for your work.
Robert Guetzkow was assigned by Vladimir Spivak 2020-11-05 20:30:10 +01:00
blender-admin commented 2020-11-06 11:47:35 +01:00
Copy Link

This issue was referenced by 6975199131

This issue was referenced by 69751991311a165e97a48ea67ed60e2c6022ee63
Robert Guetzkow commented 2020-11-06 11:56:41 +01:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Robert Guetzkow
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#82405
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?