blender/blender-addons
19
43
Fork 96
Code Issues 631 Pull Requests 27 Projects 1 Releases Wiki Activity

Icon Viewer: No button on console header #82453

New Issue
Closed
opened 2020-11-06 08:10:21 +01:00 by Ryan Inch · 18 comments
Ryan Inch commented 2020-11-06 08:10:21 +01:00
Member
Copy Link

System Information
Operating system: Linux-5.8.7-arch1-1-x86_64-with-arch 64 Bits
Graphics card: GeForce GTX 660M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.66

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-05 22:40, hash: blender/blender@02677ec4e0
Worked: 2.90
Caused by blender/blender@4b20eebb85

  • apparently the Addon misused the API though, so needs changes in the Addon

Addon Information
Name: Icon Viewer (1, 4, 0)
Author: roaoao

Short description of error
The button on the python console header is missing.

Exact steps for others to reproduce the error

  • Enable the Icon Viewer addon.
  • Make sure the Show Header preference is enabled (it's on by default).
  • Switch the Timeline editor to a Console editor.
  • Observe the missing button.
**System Information** Operating system: Linux-5.8.7-arch1-1-x86_64-with-arch 64 Bits Graphics card: GeForce GTX 660M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.66 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-05 22:40, hash: `blender/blender@02677ec4e0` Worked: 2.90 Caused by blender/blender@4b20eebb85 - > apparently the Addon misused the API though, so needs changes in the Addon **Addon Information** Name: Icon Viewer (1, 4, 0) Author: roaoao **Short description of error** The button on the python console header is missing. **Exact steps for others to reproduce the error** * Enable the Icon Viewer addon. * Make sure the Show Header preference is enabled (it's on by default). * Switch the Timeline editor to a Console editor. * Observe the missing button.
Ryan Inch commented 2020-11-06 08:10:21 +01:00
Author
Member
Copy Link

Added subscriber: @Imaginer

Added subscriber: @Imaginer
blender-admin commented 2020-11-06 08:10:21 +01:00
Copy Link

#84146 was marked as duplicate of this issue

#84146 was marked as duplicate of this issue
Ryan Inch commented 2020-11-06 09:22:36 +01:00
Author
Member
Copy Link

This doesn't seem to be limited to this addon. It seems like it affects any addon that attempts to add stuff to headers in this way (maybe all ways?).

This doesn't seem to be limited to this addon. It seems like it affects any addon that attempts to add stuff to headers in this way (maybe all ways?).
Philipp Oeser commented 2020-11-16 16:05:26 +01:00
Member
Copy Link

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser commented 2020-11-16 16:05:26 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Philipp Oeser commented 2020-11-16 16:05:26 +01:00
Member
Copy Link

Can confirm

Can confirm
Philipp Oeser commented 2020-11-16 16:32:27 +01:00
Member
Copy Link

Added subscriber: @ideasman42

Added subscriber: @ideasman42
Philipp Oeser commented 2020-11-16 16:32:27 +01:00
Member
Copy Link

Caused by blender/blender@4b20eebb85

But reading this:

In blender/blender#60195#1017405, @ideasman42 wrote:
Registering multiple headers for the same region isn't supported, I've committed blender/blender@4b20eebb85 because it's only going to cause problems.

If you want to add a button to a header you can append it to the existing headers.

Closing.

I think we have to alter the Addon way we add the button (not registering, but appending)

Caused by blender/blender@4b20eebb85 But reading this: > In blender/blender#60195#1017405, @ideasman42 wrote: > Registering multiple headers for the same region isn't supported, I've committed blender/blender@4b20eebb85 because it's only going to cause problems. > > If you want to add a button to a header you can append it to the existing headers. > > Closing. I think we have to alter the Addon way we add the button (not registering, but appending)
Yevgeny Makarov commented 2020-11-16 16:54:37 +01:00
Member
Copy Link

Added subscriber: @jenkm

Added subscriber: @jenkm
Yevgeny Makarov commented 2020-11-16 16:54:37 +01:00
Member
Copy Link

I would first ask the question - why Icon Viewer in the console?

I would first ask the question - why Icon Viewer in the console?
Philipp Oeser self-assigned this 2020-11-16 16:59:37 +01:00
blender-admin commented 2020-11-16 17:02:44 +01:00
Copy Link

This issue was referenced by 483cdf6e91

This issue was referenced by 483cdf6e916279dedb674dfdffd4cac360dc0a62
Philipp Oeser commented 2020-11-16 17:06:19 +01:00
Member
Copy Link

In #82453#1055708, @jenkm wrote:
I would first ask the question - why Icon Viewer in the console?

One possible place to do development and thus needing them?

> In #82453#1055708, @jenkm wrote: > I would first ask the question - why Icon Viewer in the console? One possible place to do development and thus needing them?
Yevgeny Makarov commented 2020-11-16 17:13:03 +01:00
Member
Copy Link

In the Text Editor you can edit scripts and there you may need to copy the icon, but in the console...
It's not that I'm against it it's just not clear.

In the Text Editor you can edit scripts and there you may need to copy the icon, but in the console... It's not that I'm against it it's just not clear.
Philipp Oeser commented 2020-11-16 17:23:13 +01:00
Member
Copy Link

In #82453#1055740, @jenkm wrote:
In the Text Editor you can edit scripts and there you may need to copy the icon, but in the console...
It's not that I'm against it it's just not clear.

Tbh, I havent thought about this much either.
But I assume someone has [the authors]. Dont have a strong opinion here, just wanted to make it work again ;) Not here to ask questions :)

> In #82453#1055740, @jenkm wrote: > In the Text Editor you can edit scripts and there you may need to copy the icon, but in the console... > It's not that I'm against it it's just not clear. Tbh, I havent thought about this much either. But I assume someone has [the authors]. Dont have a strong opinion here, just wanted to make it work again ;) Not here to ask questions :)
Ryan Inch commented 2020-11-17 02:09:41 +01:00
Author
Member
Copy Link

I use it exclusively from the console button. I develop addons with external editors, but often use the console to dig into blender's internal python structures for the correct properties/operators I need to work with. Also, I find the popup from the button much easier to work with than the squished UI in the text editor panel.

I think we have to alter the Addon way we add the button (not registering, but appending)

Lol, I usually append stuff, but after seeing this addon I thought I was doing it wrong, but apparently not. :)

I use it exclusively from the console button. I develop addons with external editors, but often use the console to dig into blender's internal python structures for the correct properties/operators I need to work with. Also, I find the popup from the button much easier to work with than the squished UI in the text editor panel. > I think we have to alter the Addon way we add the button (not registering, but appending) Lol, I usually append stuff, but after seeing this addon I thought I was doing it wrong, but apparently not. :)
Philipp Oeser commented 2020-11-26 18:17:49 +01:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Ryan Inch commented 2020-12-04 07:01:08 +01:00
Author
Member
Copy Link

Thanks for the fix @lichtwerk. Much appreciated.

Thanks for the fix @lichtwerk. Much appreciated.
Ankit Meel commented 2020-12-26 12:51:39 +01:00
Member
Copy Link

Added subscriber: @APEC

Added subscriber: @APEC
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Philipp Oeser
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#82453
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?