blender/blender-addons
19
43
Fork 96
Code Issues 628 Pull Requests 27 Projects 1 Releases Wiki Activity

WRL import #83428

New Issue
Open
opened 2020-12-05 12:46:23 +01:00 by Hanna Makowska · 14 comments
Hanna Makowska commented 2020-12-05 12:46:23 +01:00
Copy Link

System Information
Not relevant

Blender Version
Broken: version:

  • 2.92.0 Alpha, branch: master, commit date: 2020-11-29 08:04, hash: blender/blender@13c820d87b
  • 2.91.0
    Worked: 2.79

Addon Information
Name: Web3D X3D/VRML2 format (2, 2, 5)
Author: Campbell Barton, Bart, Bastien Montagne, Seva Alekseyev

Short description of error
Importing wrl file does not work properly.

The same file imported fine in 2.79, but gives back this error when importing in 2.91

  File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\__init__.py", line 78, in execute
    return import_x3d.load(context, **keywords)
  File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 3639, in load
    global_matrix=global_matrix,
  File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 3535, in load_web3d
    importShape(bpycollection, node, ancestry, global_matrix)
  File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 3141, in importShape
    is_vcol)
  File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 2968, in importShape_LoadAppearance
    (bpymat, bpyima, tex_has_alpha) = appearance_Create(vrmlname, material, tex_node, ancestry, node, is_vcol)
  File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 2876, in appearance_Create
    bpyima = appearance_LoadTexture(tex_node, ancestry, node)
  File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 2825, in appearance_LoadTexture
    bpyima.use_clight_x = not repeat_s
AttributeError: 'Image' object has no attribute 'use_clight_x'

location: <unknown location>:-1
**System Information** Not relevant **Blender Version** Broken: version: - 2.92.0 Alpha, branch: master, commit date: 2020-11-29 08:04, hash: `blender/blender@13c820d87b` - 2.91.0 Worked: 2.79 **Addon Information** Name: Web3D X3D/VRML2 format (2, 2, 5) Author: Campbell Barton, Bart, Bastien Montagne, Seva Alekseyev **Short description of error** Importing wrl file does not work properly. The same file imported fine in 2.79, but gives back this error when importing in 2.91 ``` File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\__init__.py", line 78, in execute return import_x3d.load(context, **keywords) File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 3639, in load global_matrix=global_matrix, File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 3535, in load_web3d importShape(bpycollection, node, ancestry, global_matrix) File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 3141, in importShape is_vcol) File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 2968, in importShape_LoadAppearance (bpymat, bpyima, tex_has_alpha) = appearance_Create(vrmlname, material, tex_node, ancestry, node, is_vcol) File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 2876, in appearance_Create bpyima = appearance_LoadTexture(tex_node, ancestry, node) File "C:\Program Files\Blender Foundation\Blender 2.91\2.91\scripts\addons\io_scene_x3d\import_x3d.py", line 2825, in appearance_LoadTexture bpyima.use_clight_x = not repeat_s AttributeError: 'Image' object has no attribute 'use_clight_x' location: <unknown location>:-1 ```
Hanna Makowska commented 2020-12-05 12:46:23 +01:00
Author
Copy Link

Added subscriber: @Hybryda

Added subscriber: @Hybryda
Robert Guetzkow commented 2020-12-05 13:27:31 +01:00
Member
Copy Link

Added subscriber: @rjg

Added subscriber: @rjg
Robert Guetzkow commented 2020-12-05 13:27:31 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Robert Guetzkow commented 2020-12-05 13:27:31 +01:00
Member
Copy Link

This error was introduced in 6aa8e130ef in 2018 when renaming lamp to light, which also unintentionally modified clamp to clight.

This error was introduced in 6aa8e130ef in 2018 when renaming `lamp` to `light`, which also unintentionally modified `clamp` to `clight`.
Robert Guetzkow self-assigned this 2020-12-05 13:33:49 +01:00
blender-admin commented 2020-12-09 12:19:13 +01:00
Copy Link

This issue was referenced by ff83176c7f

This issue was referenced by ff83176c7f46ec16666bec79bbda5d0147b5ed7c
blender-admin commented 2020-12-09 12:29:16 +01:00
Copy Link

This issue was referenced by blender/blender-addons-contrib@d71985e901

This issue was referenced by blender/blender-addons-contrib@d71985e901986970dfc86c3d5d1124d0f8c27518
Robert Guetzkow commented 2020-12-09 14:42:49 +01:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Dave Arendash commented 2021-08-14 09:23:01 +02:00
Copy Link

Added subscriber: @DaveA

Added subscriber: @DaveA
Dave Arendash commented 2021-08-14 09:23:01 +02:00
Copy Link

This is not fixed in 2.93

image.png

Barrel.wrl

This is not fixed in 2.93 ![image.png](https://archive.blender.org/developer/F10280587/image.png) [Barrel.wrl](https://archive.blender.org/developer/F10280591/Barrel.wrl)
Robert Guetzkow commented 2021-08-14 10:01:36 +02:00
Member
Copy Link

Changed status from 'Resolved' to: 'Confirmed'

Changed status from 'Resolved' to: 'Confirmed'
Robert Guetzkow commented 2021-08-14 10:01:36 +02:00
Member
Copy Link

@DaveA You're right the Python API changed and use_clamp_x is no longer available. The commit only fixed the incorrect renaming. Thank you for noticing and providing a test file.

If there are more parts of the add-on that haven't been updated to the current Python API, then this might take some time.

Edit: The model can be imported when removing the outdated code, but the add-on definitely has to be checked for other instances of incorrect API usage. Additionally, use_clamp_x and use_clamp_y don't seem to have a direct replacement. The clamping/clipping may need to be recreated with nodes.

@DaveA You're right the Python API changed and `use_clamp_x` is no longer available. The commit only fixed the incorrect renaming. Thank you for noticing and providing a test file. If there are more parts of the add-on that haven't been updated to the current Python API, then this might take some time. Edit: The model can be imported when removing the outdated code, but the add-on definitely has to be checked for other instances of incorrect API usage. Additionally, `use_clamp_x` and `use_clamp_y` don't seem to have a direct replacement. The clamping/clipping may need to be recreated with nodes.
Robert Guetzkow commented 2021-08-15 17:00:58 +02:00
Member
Copy Link

The add-on appears to depend on the old API in multiple areas. This will not be a quick fix.

The add-on appears to depend on the old API in multiple areas. This will not be a quick fix.
Robert Guetzkow removed their assignment 2021-08-15 18:36:58 +02:00
blender-admin commented 2021-10-27 12:23:39 +02:00
Copy Link

This issue was referenced by 0573bc7dae

This issue was referenced by 0573bc7daeb1e5fc1e0d0e6a37c5efc043aebb13
Cedric Steiert commented 2024-07-20 03:28:19 +02:00
Copy Link

The attached file works in blender 4.2 with extension version 2.3.3. Seems to be resolved by now.

The attached file works in blender 4.2 with extension version 2.3.3. Seems to be resolved by now.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#83428
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?