CTest/Addons: Blenderkit adds 4+ minutes to the script_load_addons test #84391
Labels
No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-addons#84391
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows+Linux
Broken: current master
Worked: "a while ago"
I noticed a while ago (but thought it was just me), but @Sergey noticed today as well so I took a closer look, when running
ctest -C Release -VV -R script_load_addons
it balloons the time required for this test by a good 245sec.with blenderkit in the addons folder
1/1 Test #2: script_load_addons ............... Passed 250.24 sec
without blenderkit in the addons folder
1/1 Test #2: script_load_addons ............... Passed 4.45 sec
to see what was going on i dumped a print statement in the
reload
function in2.92\python\lib\importlib\__init__.py
blenderkit seems to trigger an avalanche of modules reloading each other, partial log below but it kept going for "quite a while" after that.
P1866: (An Untitled Masterwork)
Also not the root cause, but if you're doing maintenance may as well fix it while you are at it in
2.92\scripts\addons\blenderkit\ui.py
tasks_queue = importlib.reload(tasks_queue)
tasks_queue = importlib.reload(ui_panels)```
Added subscribers: @Sergey, @VilemDuha, @LazyDodo
Changed status from 'Needs Triage' to: 'Confirmed'
Will look into this asap.
The reload functions need a cleanup, sorry for that.
This issue was referenced by
82e528ea36
Changed status from 'Confirmed' to: 'Resolved'
Should be resolved:
82e528ea36