DXF Import Error - TypeError '<' not supported between instances of 'tuple' and 'NoneType' #84936

New Issue

Salim Hbeiliny · 2021-01-21T17:00:42+01:00

Salim Hbeiliny commented

2021-01-21 17:00:42 +01:00

System Information
Operating system: Mac OS 10.15.7

Blender Version
Broken: 2.83.1

Addon Information
Name: Import AutoCAD DXF Format (.dxf) (0, 9, 6)
Author: Lukas Treyer, Manfred Moitzi (support + dxfgrabber library), Vladimir Elistratov, Bastien Montagne, Remigiusz Fiedler (AKA migius)

Short description of error
Importing a certain DXF file fails with the error:

TypeError '<' not supported between instances of 'tuple' and 'NoneType'

Exact steps for others to reproduce the error

Start Blender
Enable Addon: Import AutoCAD DXF format
Import attached DXF file
test_blender_import.dxf

I managed to fix this error in /Applications/Blender.app/Contents/Resources/2.83/scripts/addons/io_import_dxf/dxfimport/groupsort.py
by changing this line 86 (https://developer.blender.org/diffusion/BA/browse/master/io_import_dxf/dxfimport/groupsort.py$86)
from:

if entity.dxftype in {"LINE", "POINT"}

to:

if entity.dxftype in {"LINE", "POINT"} or extrusion == None:

**System Information** Operating system: Mac OS 10.15.7 **Blender Version** Broken: 2.83.1 **Addon Information** Name: Import AutoCAD DXF Format (.dxf) (0, 9, 6) Author: Lukas Treyer, Manfred Moitzi (support + dxfgrabber library), Vladimir Elistratov, Bastien Montagne, Remigiusz Fiedler (AKA migius) **Short description of error** Importing a certain DXF file fails with the error: ``` TypeError '<' not supported between instances of 'tuple' and 'NoneType' ``` **Exact steps for others to reproduce the error** 1. Start Blender 2. Enable Addon: Import AutoCAD DXF format 3. Import attached DXF file [test_blender_import.dxf](https://archive.blender.org/developer/F9591122/test_blender_import.dxf) I managed to fix this error in /Applications/Blender.app/Contents/Resources/2.83/scripts/addons/io_import_dxf/dxfimport/groupsort.py by changing this line 86 (https://developer.blender.org/diffusion/BA/browse/master/io_import_dxf/dxfimport/groupsort.py$86) from: ``` if entity.dxftype in {"LINE", "POINT"} ``` to: ``` if entity.dxftype in {"LINE", "POINT"} or extrusion == None: ```

Salim Hbeiliny commented

2021-01-21 17:00:42 +01:00

Added subscriber: @salim-1

Germano Cavalcante commented

2021-01-22 15:25:42 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-01-22 15:25:42 +01:00

This is so since the original code (82a00ee2)

The proposed fix seems harmless since the function is used only as a key for sort.
But why should the None extrusion be (0.0, 0.0, 1.0) and not ()?
Is the result of the sort really as expected?

We may have to contact the original authors of the addon :\

This is so since the original code (82a00ee2) The proposed fix seems harmless since the function is used only as a key for sort. But why should the `None` `extrusion` be `(0.0, 0.0, 1.0)` and not `()`? Is the result of the sort really as expected? We may have to contact the original authors of the addon :\

Salim Hbeiliny commented

2021-01-25 09:33:28 +01:00

I didn't notice issues with the result, then again, I might miss some minor details. However () would make more sense. It also works for me.

I wasn't sure where else I can report this. Is there a separate repository from the original authors?

I didn't notice issues with the result, then again, I might miss some minor details. However `()` would make more sense. It also works for me. I wasn't sure where else I can report this. Is there a separate repository from the original authors?

Germano Cavalcante commented

2021-01-25 15:00:30 +01:00

Added subscriber: @cnd

Germano Cavalcante commented

2021-01-25 15:00:30 +01:00

The problem is that we cannot apply this correction blindly.
Either the original author needs to take a look or these questions need to be studied and answered:

Why should the None extrusion be (0.0, 0.0, 1.0)?
Is the result of the sort really as expected?

The problem is that we cannot apply this correction blindly. Either the original author needs to take a look or these questions need to be studied and answered: - Why should the `None` `extrusion` be `(0.0, 0.0, 1.0)`? - Is the result of the sort really as expected?

Salim Hbeiliny commented

2021-01-25 15:30:33 +01:00

Indeed, I agree. My suggestion is just to avoid the complete failure during import. I can't confirm that the expected result is 100% correct. However, I didn't notice any obvious issue myself.

Perhaps @cnd, the author of (82a00ee2) can take a look at this issue?

Indeed, I agree. My suggestion is just to avoid the complete failure during import. I can't confirm that the expected result is 100% correct. However, I didn't notice any obvious issue myself. Perhaps @cnd, the author of (82a00ee2) can take a look at this issue?

Germano Cavalcante commented

2021-02-01 18:39:37 +01:00

Since none of the original authors gave their opinion, and the proposed correction appears to be harmless, I will step forward and commit the solution.
I will also add a comment explaining that it is a workaround.
It is better than leaving the import failing.

Since none of the original authors gave their opinion, and the proposed correction appears to be harmless, I will step forward and commit the solution. I will also add a comment explaining that it is a workaround. It is better than leaving the import failing.

Salim Hbeiliny commented

2021-02-01 19:15:04 +01:00

Thanks, I think that it's better to go with your suggestion of using (), so the code would become:

        if entity.dxftype in {"LINE", "POINT"}:
            extrusion = (0.0, 0.0, 1.0)
        if extrusion == None:
            extrusion = ()

where the last 2 lines are the addition. I tested it and got the same results.

Thanks, I think that it's better to go with your suggestion of using `()`, so the code would become: ``` if entity.dxftype in {"LINE", "POINT"}: extrusion = (0.0, 0.0, 1.0) if extrusion == None: extrusion = () ``` where the last 2 lines are the addition. I tested it and got the same results.

blender-admin commented

2021-02-01 19:25:40 +01:00

This issue was referenced by efbcbb2665

This issue was referenced by efbcbb2665b7763463e58d1f36514c48bb43b44e

Germano Cavalcante commented

2021-02-01 19:26:49 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'