Collection manager - remove empty collection not working corectly (not deleting empty in full) #89070

Closed
opened 2021-06-11 20:31:36 +02:00 by ManBlender · 15 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1650 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: blender/blender@84da05a8b8
Worked: (newest version of Blender that worked as expected)

Short description of error
Collection manager - remove empty collection not working corectly (not deleting empty in full)

Exact steps for others to reproduce the error
collection manager bug.png
collection manager bug 2.png
collection manager bug 3.png

remove collections bug.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1650 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: `blender/blender@84da05a8b8` Worked: (newest version of Blender that worked as expected) **Short description of error** Collection manager - remove empty collection not working corectly (not deleting empty in full) **Exact steps for others to reproduce the error** ![collection manager bug.png](https://archive.blender.org/developer/F10167335/collection_manager_bug.png) ![collection manager bug 2.png](https://archive.blender.org/developer/F10167337/collection_manager_bug_2.png) ![collection manager bug 3.png](https://archive.blender.org/developer/F10167338/collection_manager_bug_3.png) [remove collections bug.blend](https://archive.blender.org/developer/F10167341/remove_collections_bug.blend)
Author

Added subscriber: @ManBlender

Added subscriber: @ManBlender
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Can confirm.

Can confirm.
Member

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'
Member

Added subscriber: @Imaginer

Added subscriber: @Imaginer
Member

I think current algorithm does not remove parent of empty child collection on single attempt. One more attempt to Remove empty Collections will delete this parent(if it's empty).

I misunderstood the logic initially. So far this seems intended behavior. @Imaginer , do you want to mention something (or want to correct my words)?

I think current algorithm does not remove parent of empty child collection on single attempt. One more attempt to `Remove empty Collections` will delete this parent(if it's empty). I misunderstood the logic initially. So far this seems intended behavior. @Imaginer , do you want to mention something (or want to correct my words)?
Author

I can add that, if more collections and objects this work in more unpredictable way - leaving randomly collections or something like this.

I can add that, if more collections and objects this work in more unpredictable way - leaving randomly collections or something like this.
Member

I can add that, if more collections and objects this work in more unpredictable way - leaving randomly collections or something like this.

@ManBlender , great! Before submitting the patch I think Ryan's call will be useful.

>I can add that, if more collections and objects this work in more unpredictable way - leaving randomly collections or something like this. @ManBlender , great! Before submitting the patch I think Ryan's call will be useful.
Member

From the screenshots I can see that it's working as intended. If you look at the tooltip it says that it will remove any collections that don't have objects and do not contain any subcollections. If you check the before screenshot, the two collections that are left both contain subcollections, and so aren't empty. To remove all collections that don't contain objects (regardless of whether they have subcollections or not) use Purge All Collections Without Objects (if that doesn't clear them, then that's a bug ;) ).

Thanks for using the Collection Manager @ManBlender. :)

From the screenshots I can see that it's working as intended. If you look at the tooltip it says that it will remove any collections that don't have objects and do not contain any subcollections. If you check the before screenshot, the two collections that are left both contain subcollections, and so aren't empty. To remove all collections that don't contain objects (regardless of whether they have subcollections or not) use `Purge All Collections Without Objects` (if that doesn't clear them, then that's a bug ;) ). Thanks for using the Collection Manager @ManBlender. :)
Member

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'
Ryan Inch was assigned by Pratik Borhade 2021-06-14 20:33:01 +02:00
Member

@Imaginer , thanks for the clarification :)

Closing the task. thanks again for the report!

@Imaginer , thanks for the clarification :) Closing the task. thanks again for the report!
Member

@PratikPB2123 Welcome :)

@PratikPB2123 Welcome :)
Author

Ok, I understand now. I not included the situation that clicking many times Remove empty Collections deleting child like recursion process, by this I recognized the random.
Thx for explanation.

Ok, I understand now. I not included the situation that clicking many times ` Remove empty Collections` deleting child like recursion process, by this I recognized the random. Thx for explanation.
Member

@ManBlender
Your welcome. :)
Yes, you can achieve the same result as Purge All Collections Without Objects by clicking Remove Empty Collections multiple times. I received feedback that it was important to have both options, so both are included :)

@ManBlender Your welcome. :) Yes, you can achieve the same result as `Purge All Collections Without Objects` by clicking `Remove Empty Collections` multiple times. I received feedback that it was important to have both options, so both are included :)
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#89070
No description provided.