mesh_tissue missing icon warning #90681

New Issue

Cezary Kopias · 2021-08-15T12:24:26+02:00

Cezary Kopias commented

2021-08-15 12:24:26 +02:00

System Information
Operating system:
Graphics card:

Blender Version
Broken:
2.93.2

Short description of error
simple add-on missing icon warning at:

developer.blender.org/diffusion/BA/browse/master/mesh_tissue/tessellate_numpy.py$2716

**System Information** Operating system: Graphics card: **Blender Version** Broken: 2.93.2 **Short description of error** simple add-on missing icon warning at: developer.blender.org/diffusion/BA/browse/master/mesh_tissue/tessellate_numpy.py$2716

Cezary Kopias commented

2021-08-15 12:24:26 +02:00

Added subscriber: @kopias

Jesse Yurkovich commented

2021-08-15 13:05:06 +02:00

Added subscribers: @rjg, @deadpin

Jesse Yurkovich commented

2021-08-15 13:05:06 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jesse Yurkovich commented

2021-08-15 13:05:06 +02:00

@rjg Do we need to poke the Tissue addon author again so he will submit his latest code? Or we can checkin the referenced commit here as a quick stop-gap.

Robert Guetzkow commented

2021-08-15 14:29:16 +02:00

Added subscriber: @AlessandroZomparelli

Robert Guetzkow commented

2021-08-15 14:29:16 +02:00

@deadpin That is a good question. I think we could apply your patch to Blender 2.93.x for a future LTS. Generally the add-on maintainer should be on top of these things though. We should definitely get an updated version of the add-on by the maintainer for 3.0 otherwise the code may start to deviate or we might do duplicated work if we implement fixes in parallel with the actual add-on development. You may want to check with someone more senior (@ideasman42 ?) than me though.

@AlessandroZomparelli Could you please review the linked patch and submit a patch to include a current version of your add-on in the master branch of the Blender add-ons repository.

@deadpin That is a good question. I think we could apply your patch to Blender 2.93.x for a future LTS. Generally the add-on maintainer should be on top of these things though. We should definitely get an updated version of the add-on by the maintainer for 3.0 otherwise the code may start to deviate or we might do duplicated work if we implement fixes in parallel with the actual add-on development. You may want to check with someone more senior (@ideasman42 ?) than me though. @AlessandroZomparelli Could you please review the linked patch and submit a patch to include a current version of your add-on in the master branch of the Blender add-ons repository.

Robert Guetzkow commented

2021-08-16 11:17:17 +02:00

Added subscriber: @ideasman42

Alessandro Zomparelli commented

2021-08-23 01:11:08 +02:00

Hi @rjg you are right, I should personally maintain it on the official repository and I apologize if it is taking so long. In my spare time, I'm trying to understand the correct procedure, but my knowledge of github is really basic just regular commits on my Github repositories.
I will get there eventually, but so far I have a local version of the repository: git://git.blender.org/blender.git where I changed the add-on code. I'm now trying to make a Diff, since I understood that I must upload a Diff file instead of doing a commit. Is it correct?
Thanks for your patience.

Hi @rjg you are right, I should personally maintain it on the official repository and I apologize if it is taking so long. In my spare time, I'm trying to understand the correct procedure, but my knowledge of github is really basic just regular commits on my Github repositories. I will get there eventually, but so far I have a local version of the repository: git://git.blender.org/blender.git where I changed the add-on code. I'm now trying to make a Diff, since I understood that I must upload a Diff file instead of doing a commit. Is it correct? Thanks for your patience.

Robert Guetzkow commented

2021-08-23 09:26:24 +02:00

@AlessandroZomparelli Yes that is correct. The usual workflow is the following:

Make sure you are on the master branch and update it (it will automatically update submodules as well)

git checkout master
make update

Create a branch for your new feature / updated add-on. The add-ons are in a subdirectory that have their own repository. The following commands assume you are in the top most directory of the cloned repository

cd release/scripts/addons
git checkout -b name-of-your-branch

Make your changes to the files of your add-on, test that it works, then store the changes with a commit. Please always make sure to add files individually as git add . can add submodules to the commit you don't want to include.

git add /path/to/changed/file
...
git commit -m "Your commit message"

Create the diff for review. This can either be done as a plain diff file or through arcanist, the latter is preferred but can be a bit complicated to setup if your on Windows.

Plain diff

git diff -U1000 master..name-of-your-branch > name-of-your-branch.diff

Then upload the diff file through the web form.

Arcanist

arc diff

This will already create the diff/review task on this website for you.

Then return to the master branch when you're done

git checkout master

For more information see our wiki page on the topic. For more help with git see this wiki article. If you have questions, people in the #blender-coders channel will be happy to help.

@AlessandroZomparelli Yes that is correct. The usual workflow is the following: 1. Make sure you are on the master branch and update it (it will automatically update submodules as well) ``` git checkout master make update ``` 2. Create a branch for your new feature / updated add-on. The add-ons are in a subdirectory that have their own repository. The following commands assume you are in the top most directory of the cloned repository ``` cd release/scripts/addons git checkout -b name-of-your-branch ``` 3. Make your changes to the files of your add-on, test that it works, then store the changes with a commit. Please always make sure to add files individually as `git add .` can add submodules to the commit you don't want to include. ``` git add /path/to/changed/file ... git commit -m "Your commit message" ``` 4. Create the diff for review. This can either be done as a plain diff file or through arcanist, the latter is preferred but can be a bit complicated to setup if your on Windows. Plain diff ``` git diff -U1000 master..name-of-your-branch > name-of-your-branch.diff ``` Then upload the diff file through the [web form](https://developer.blender.org/differential/diff/create/). Arcanist ``` arc diff ``` This will already create the diff/review task on this website for you. Then return to the master branch when you're done ``` git checkout master ``` For more information see our [wiki page on the topic](https:*wiki.blender.org/wiki/Tools/CodeReview). For more help with git see [this wiki article](https:*wiki.blender.org/wiki/Tools/Git). If you have questions, people in the [#blender-coders channel ](https://blender.chat/channel/blender-coders) will be happy to help.

Alessandro Zomparelli commented

2021-08-24 00:02:07 +02:00

Thank you so much for the support @rjg , I just sent it using the file upload method. I hope that everything is fine :-)

Robert Guetzkow commented

2021-08-24 09:35:05 +02:00

@AlessandroZomparelli I don't see a revision associated with your profile. Do you have a link?

Alessandro Zomparelli commented

2022-02-28 14:31:29 +01:00

hi @rjg I am a bit tight with the time before the next release. Would it that possible to get some help updating Tissue on the Blender's repository?
I wanted to take care of that personally, but I don't think I will be able to do that in time. This is the latest release: https://github.com/alessandro-zomparelli/tissue/releases/tag/v0-3-52

Just a couple of notes:

I guess that the readme file should be removed since it is not necessary for the addon and contains a link to my Patreon page.
The wiki_urlis pointing to the GitHub page, while it should point to the Blender's manual instead: https://docs.blender.org/manual/en/3.1/addons/mesh/tissue.html . At the moment it is not updated yet, but I sent a differential for that, I hope that the process works fine. In the near future, I will make sure that the documentation is complete and updated.

hi @rjg I am a bit tight with the time before the next release. Would it that possible to get some help updating Tissue on the Blender's repository? I wanted to take care of that personally, but I don't think I will be able to do that in time. This is the latest release: https://github.com/alessandro-zomparelli/tissue/releases/tag/v0-3-52 Just a couple of notes: 1) I guess that the readme file should be removed since it is not necessary for the addon and contains a link to my Patreon page. 2) The *wiki_url*is pointing to the GitHub page, while it should point to the Blender's manual instead: https://docs.blender.org/manual/en/3.1/addons/mesh/tissue.html . At the moment it is not updated yet, but I sent a differential for that, I hope that the process works fine. In the near future, I will make sure that the documentation is complete and updated.

Aaron Carlisle commented

2022-03-01 17:05:35 +01:00

Added subscriber: @Blendify

Aaron Carlisle commented

2022-03-01 17:05:35 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Aaron Carlisle closed this issue

2022-03-01 17:05:35 +01:00

Aaron Carlisle self-assigned this 2022-03-01 17:05:35 +01:00

Aaron Carlisle commented

2022-03-01 17:05:35 +01:00

Fixed with da9a50a46e

Fixed with da9a50a46e

Robert Guetzkow commented

2022-03-02 10:32:28 +01:00

@AlessandroZomparelli I'm sorry that I haven't replied. I'm currently writing essential parts of my thesis and didn't have time to check my mentions.

@Blendify Thank you for taking care of this.

@AlessandroZomparelli I'm sorry that I haven't replied. I'm currently writing essential parts of my thesis and didn't have time to check my mentions. @Blendify Thank you for taking care of this.

Sign in to join this conversation.