Node Preset Addon crashes when used with Geometry Nodes #90845

Closed
opened 2021-08-22 12:23:59 +02:00 by Oliver Reischl · 16 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68

Blender Version
Broken: version: 2.93.3, branch: master, commit date: 2021-08-17 18:30, hash: blender/blender@8b80d19f36
Worked: I think this never worked.

Addon Information
Name: Node Presets (1, 1)
Author: Campbell Barton

Short description of error
Node Preset Addon is missing support for Geometry Nodes

Exact steps for others to reproduce the error

  • Store a geometry node group in the preset folder for the plugin (and restart blender to make the plugin read the folder data again)
  • In a new scene, create a geometry node graph
  • Add the geometry node preset to the node graph (Add => Template => Geometry Node Group)

You should get this error:

Python: Traceback (most recent call last):
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\node_presets.py", line 152, in invoke
    node_template_add(context, self.filepath, self.group_name, event.shift, self.report)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\node_presets.py", line 84, in node_template_add
    node_type_string = {
KeyError: 'GeometryNodeTree'

location: <unknown location>:-1

Script seems to miss only one line:

    node_type_string = {
        "ShaderNodeTree": "ShaderNodeGroup",
        "CompositorNodeTree": "CompositorNodeGroup",
        "TextureNodeTree": "TextureNodeGroup",
        "GeometryNodeTree": "GeometryNodeGroup", # <--- When i add this, it seems to work.
    }[type(node_tree).__name__]
**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68 **Blender Version** Broken: version: 2.93.3, branch: master, commit date: 2021-08-17 18:30, hash: `blender/blender@8b80d19f36` Worked: I think this never worked. **Addon Information** Name: Node Presets (1, 1) Author: Campbell Barton **Short description of error** Node Preset Addon is missing support for Geometry Nodes **Exact steps for others to reproduce the error** - Store a geometry node group in the preset folder for the plugin (and restart blender to make the plugin read the folder data again) - In a new scene, create a geometry node graph - Add the geometry node preset to the node graph (Add => Template => Geometry Node Group) You should get this error: ``` Python: Traceback (most recent call last): File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\node_presets.py", line 152, in invoke node_template_add(context, self.filepath, self.group_name, event.shift, self.report) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\node_presets.py", line 84, in node_template_add node_type_string = { KeyError: 'GeometryNodeTree' location: <unknown location>:-1 ``` Script seems to miss only one line: ``` node_type_string = { "ShaderNodeTree": "ShaderNodeGroup", "CompositorNodeTree": "CompositorNodeGroup", "TextureNodeTree": "TextureNodeGroup", "GeometryNodeTree": "GeometryNodeGroup", # <--- When i add this, it seems to work. }[type(node_tree).__name__] ```
Author

Added subscriber: @clawjelly

Added subscriber: @clawjelly

#96022 was marked as duplicate of this issue

#96022 was marked as duplicate of this issue

#94831 was marked as duplicate of this issue

#94831 was marked as duplicate of this issue

#92846 was marked as duplicate of this issue

#92846 was marked as duplicate of this issue

Added subscriber: @AditiaA.Pratama

Added subscriber: @AditiaA.Pratama
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Added subscriber: @Lutzi

Added subscriber: @Lutzi

Added subscriber: @muzikermammoth

Added subscriber: @muzikermammoth

Tried the solution and it works

Tried the solution and it works
Member

Added subscriber: @valentinlechene

Added subscriber: @valentinlechene
Member
Hi @clawjelly, please submit the patch of your fix: https://developer.blender.org/maniphest/task/edit/form/3/

This issue was referenced by e7b7134696

This issue was referenced by e7b7134696f51e5be814a45503c1b93149caf525

This issue was referenced by e56895f5e4

This issue was referenced by e56895f5e48c6cc3be45caad8058535186bd4809

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Campbell Barton self-assigned this 2022-02-17 07:37:52 +01:00
Member

Added subscriber: @aplus

Added subscriber: @aplus
Sign in to join this conversation.
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#90845
No description provided.