Python exception while importing glb #91217

New Issue

Julien · 2021-09-06T14:10:25+02:00

Julien commented

2021-09-06 14:10:25 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.93.1, branch: master, commit date: 2021-06-22 05:57, hash: blender/blender@1b8d33b18c
Worked: unknown (not 2.82)

Short description of error
Here is the stacktrace:

Data are loaded, start creating Blender stuff
Python: Traceback (most recent call last):
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\__init__.py", line 1050, in execute
    return self.import_gltf2(context)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\__init__.py", line 1064, in import_gltf2
    if self.unit_import(path, import_settings) == {'FINISHED'}:
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\__init__.py", line 1084, in unit_import
    BlenderGlTF.create(gltf_importer)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_gltf.py", line 42, in create
    BlenderGlTF._create(gltf)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_gltf.py", line 49, in _create
    BlenderScene.create(gltf)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_scene.py", line 40, in create
    BlenderNode.create_vnode(gltf, 'root')
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 51, in create_vnode
    BlenderNode.create_vnode(gltf, child)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 51, in create_vnode
    BlenderNode.create_vnode(gltf, child)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 38, in create_vnode
    BlenderNode.create_object(gltf, vnode_id)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 58, in create_object
    obj = BlenderNode.create_mesh_object(gltf, vnode)
  File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 187, in create_mesh_object
    pymesh = gltf.data.meshes[pynode.mesh]
IndexError: list index out of range

location: <unknown location>:-1

Exact steps for others to reproduce the error
Unfortunatly, I can not provide the file I tried to import.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 2.93.1, branch: master, commit date: 2021-06-22 05:57, hash: `blender/blender@1b8d33b18c` Worked: unknown (not 2.82) **Short description of error** Here is the stacktrace: ``` Data are loaded, start creating Blender stuff Python: Traceback (most recent call last): File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\__init__.py", line 1050, in execute return self.import_gltf2(context) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\__init__.py", line 1064, in import_gltf2 if self.unit_import(path, import_settings) == {'FINISHED'}: File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\__init__.py", line 1084, in unit_import BlenderGlTF.create(gltf_importer) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_gltf.py", line 42, in create BlenderGlTF._create(gltf) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_gltf.py", line 49, in _create BlenderScene.create(gltf) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_scene.py", line 40, in create BlenderNode.create_vnode(gltf, 'root') File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 51, in create_vnode BlenderNode.create_vnode(gltf, child) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 51, in create_vnode BlenderNode.create_vnode(gltf, child) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 38, in create_vnode BlenderNode.create_object(gltf, vnode_id) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 58, in create_object obj = BlenderNode.create_mesh_object(gltf, vnode) File "C:\Program Files\Blender Foundation\Blender 2.93\2.93\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 187, in create_mesh_object pymesh = gltf.data.meshes[pynode.mesh] IndexError: list index out of range location: <unknown location>:-1 ``` **Exact steps for others to reproduce the error** Unfortunatly, I can not provide the file I tried to import.

Julien commented

2021-09-06 14:10:26 +02:00

Added subscriber: @Ping

Scurest commented

2021-09-06 14:14:51 +02:00

Added subscriber: @scurest

Scurest commented

2021-09-06 14:14:51 +02:00

The .glb might be invalid. Try it in one of these.

glTF Validator: https://github.khronos.org/glTF-Validator/
glTF Viewer: https://gltf-viewer.donmccurdy.com/

The .glb might be invalid. Try it in one of these. glTF Validator: https://github.khronos.org/glTF-Validator/ glTF Viewer: https://gltf-viewer.donmccurdy.com/

Philipp Oeser commented

2021-09-06 14:27:27 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-09-06 14:27:27 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2021-09-06 14:27:27 +02:00

Unfortunatly, I can not provide the file I tried to import

Without this, it is very unlikely this will be reproduced.
Will set to Needs Information from User until some sharable .glb can be provided that show this issue.

> Unfortunatly, I can not provide the file I tried to import Without this, it is very unlikely this will be reproduced. Will set to Needs Information from User until some sharable .glb can be provided that show this issue.

Julien commented

2021-09-06 14:46:36 +02:00

Ok, I have Unresolved references in the file. Isn't it possible to ignore those references in the importer ?

Philipp Oeser commented

2021-09-06 15:05:35 +02:00

In #91217#1216706, @Ping wrote:
Ok, I have Unresolved references in the file. Isn't it possible to ignore those references in the importer ?

Think so, could you still share a minimal example .blend (or multiple if neccessary -- references are linked libraries here?)?

> In #91217#1216706, @Ping wrote: > Ok, I have Unresolved references in the file. Isn't it possible to ignore those references in the importer ? Think so, could you still share a minimal example .blend (or multiple if neccessary -- references are linked libraries here?)?

Scurest commented

2021-09-06 15:16:06 +02:00

@lichtwerk "Unresolved reference" is the error the glTF validator gives for invalid glTF files that do stuff like this

  // JSON data inside the .glb...
  "meshes" : [
      { ... }, // mesh 0
      { ... }, // mesh 1
      { ... }, // mesh 2
  ],
  "nodes" : [
      {
          "mesh" : 3, // there is no mesh 3! UNRESOLVED_REFERENCE
      }
  ]

This is a bug in the software the created the .glb.

@lichtwerk "Unresolved reference" is the error the glTF validator gives for invalid glTF files that do stuff like this ``` // JSON data inside the .glb... "meshes" : [ { ... }, // mesh 0 { ... }, // mesh 1 { ... }, // mesh 2 ], "nodes" : [ { "mesh" : 3, // there is no mesh 3! UNRESOLVED_REFERENCE } ] ``` This is a bug in the software the created the .glb.

Julien commented

2021-09-06 15:21:05 +02:00

Yes, this is exactly the problem (in a glb file not in json but the problem is the same) but I don't need the unresolved meshes and it will be great to get the file opened by discarding those parts. I can try to produce a file having this problem to submit it but it probably will be easier for me to provide a patch of the code.

Scurest commented

2021-09-06 15:29:23 +02:00

I don't think the importer should try to handle this, whatever program produced the .glb should get fixed instead.

@Ping You can probably throw this quick hack onto it to get this one .glb file to work if you want to though.

diff --git a/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py b/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py
index 041bf1eb..867ec367 100644
--- a/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py
+++ b/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py
@@ -184,6 +184,8 @@ class BlenderNode():
     @staticmethod
     def create_mesh_object(gltf, vnode):
         pynode = gltf.data.nodes[vnode.mesh_node_idx]
+        if not (0 <= pynode.mesh < len(gltf.data.meshes)):
+            return bpy.data.objects.new(vnode.name or mesh.name, None)
         pymesh = gltf.data.meshes[pynode.mesh]
 
         # Key to cache the Blender mesh by.

I don't think the importer should try to handle this, whatever program produced the .glb should get fixed instead. @Ping You can probably throw this quick hack onto it to get this one .glb file to work if you want to though. ``` diff --git a/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py b/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py index 041bf1eb..867ec367 100644 --- a/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py +++ b/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py @@ -184,6 +184,8 @@ class BlenderNode(): @staticmethod def create_mesh_object(gltf, vnode): pynode = gltf.data.nodes[vnode.mesh_node_idx] + if not (0 <= pynode.mesh < len(gltf.data.meshes)): + return bpy.data.objects.new(vnode.name or mesh.name, None) pymesh = gltf.data.meshes[pynode.mesh] # Key to cache the Blender mesh by. ```

Philipp Oeser commented

2021-09-06 15:43:55 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-09-06 15:43:55 +02:00

Added subscriber: @JulienDuroure

Philipp Oeser commented

2021-09-06 15:43:55 +02:00

Thx for the info reg. Unresolved Reference.

I don't think the importer should try to handle this, whatever program produced the .glb should get fixed instead.

True, sometimes it might make sense to handle this more gracefully though (see recent 4e30cfd306})

Will leave up to @JulienDuroure to decide.

Thx for the info reg. Unresolved Reference. > I don't think the importer should try to handle this, whatever program produced the .glb should get fixed instead. True, sometimes it might make sense to handle this more gracefully though (see recent 4e30cfd306}) Will leave up to @JulienDuroure to decide.

Julien commented

2021-09-06 15:49:44 +02:00

@scurest (scurest) Thanks a not.
But I still think it's a good choice for a sofware to get rid of errors in user inputs if possible rather than only show a stacktrace.
Thanks again

@scurest (scurest) Thanks a not. But I still think it's a good choice for a sofware to get rid of errors in user inputs if possible rather than only show a stacktrace. Thanks again

Julien Duroure commented

2021-09-07 13:28:05 +02:00

I agree that importer can't handle all errors raised by invalid file.
But because there is, for this particular issue, a quick check that can be performed to avoid traceback, it is worth adding it

I agree that importer can't handle all errors raised by invalid file. But because there is, for this particular issue, a quick check that can be performed to avoid traceback, it is worth adding it

Julien Duroure self-assigned this 2021-09-07 13:29:54 +02:00

Julien Duroure commented

2021-09-08 12:18:18 +02:00

Proposed PR: https://github.com/KhronosGroup/glTF-Blender-IO/pull/1464