Sapling Addon now broken because of "SPDX-License-Identifier" header #95962

New Issue

Adrian Sausenthaler · 2022-02-22T18:10:58+01:00

2022-02-22 18:10:58 +01:00

System Information
Operating system: Linux-5.16.9-arch1-1-x86_64-with-glibc2.35 64 Bits
Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.54

Blender Version
Broken: version: 3.2.0 Alpha, branch: makepkg (modified), commit date: 2022-02-17 12:14, hash: blender/blender@433fad50d8
Worked: Probably before the commit

Addon Information
Name: Sapling Tree Gen (0, 3, 4)
Author: Andrew Hale (TrumanBlending), Aaron Buchler, CansecoGPC

Short description of error
Python: "SyntaxError: invalid syntax" on adding tree

Exact steps for others to reproduce the error
View3D -> Add -> Curve -> Sapling Tree Gen

Problem
This commit added a new first line into callistemon.py: Diff

The addon code on line 185 (https://git.blender.org/gitweb/gitweb.cgi/blender-addons.git/blob/HEAD:/add_curve_sapling/init.py#l185) now reads the comment: SPDX-License-Identifier: GPL-2.0-or-later from file blender/3.2/scripts/addons/add_curve_sapling/presets/callistemon.py instead of the prior JSON string, which fails at the ast parser.

Stacktrace

location: /usr/share/blender/3.2/scripts/modules/bpy/ops.py:116
Error: Python: Traceback (most recent call last):
  File "/usr/share/blender/3.2/scripts/addons/add_curve_sapling/__init__.py", line 188, in execute
    settings = ast.literal_eval(settings)
  File "/usr/lib/python3.10/ast.py", line 62, in literal_eval
    node_or_string = parse(node_or_string.lstrip(" \t"), mode='eval')
  File "/usr/lib/python3.10/ast.py", line 50, in parse
    return compile(source, filename, mode, flags,
  File "<unknown>", line 1
    # SPDX-License-Identifier: GPL-2.0-or-later
SyntaxError: invalid syntax

**System Information** Operating system: Linux-5.16.9-arch1-1-x86_64-with-glibc2.35 64 Bits Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.54 **Blender Version** Broken: version: 3.2.0 Alpha, branch: makepkg (modified), commit date: 2022-02-17 12:14, hash: `blender/blender@433fad50d8` Worked: Probably before the commit **Addon Information** Name: Sapling Tree Gen (0, 3, 4) Author: Andrew Hale (TrumanBlending), Aaron Buchler, CansecoGPC **Short description of error** Python: "SyntaxError: invalid syntax" on adding tree **Exact steps for others to reproduce the error** View3D -> Add -> Curve -> Sapling Tree Gen **Problem** This commit added a new first line into callistemon.py: [Diff ](https://git.blender.org/gitweb/gitweb.cgi/blender-addons.git/blobdiff/90fbd177c9850e21bae2238faba791815be566f0..a5587f5223f65843e7d4c52088d782e3075a0df7:/add_curve_sapling/presets/callistemon.py) The addon code on line 185 (https://git.blender.org/gitweb/gitweb.cgi/blender-addons.git/blob/HEAD:/add_curve_sapling/__init__.py#l185) now reads the comment: `SPDX-License-Identifier: GPL-2.0-or-later` from file `blender/3.2/scripts/addons/add_curve_sapling/presets/callistemon.py` instead of the prior JSON string, which fails at the ast parser. **Stacktrace** ``` location: /usr/share/blender/3.2/scripts/modules/bpy/ops.py:116 Error: Python: Traceback (most recent call last): File "/usr/share/blender/3.2/scripts/addons/add_curve_sapling/__init__.py", line 188, in execute settings = ast.literal_eval(settings) File "/usr/lib/python3.10/ast.py", line 62, in literal_eval node_or_string = parse(node_or_string.lstrip(" \t"), mode='eval') File "/usr/lib/python3.10/ast.py", line 50, in parse return compile(source, filename, mode, flags, File "<unknown>", line 1 # SPDX-License-Identifier: GPL-2.0-or-later SyntaxError: invalid syntax ```

Adrian Sausenthaler commented

2022-02-22 18:10:58 +01:00

Added subscriber: @AdrianSausenthaler