Node wrangler doesn't work right for the principled bsdf node #98246

New Issue

ronald johnson · 2022-05-19T08:43:59+02:00

ronald johnson commented

2022-05-19 08:43:59 +02:00

Blender Version 3.1.2Short description of errorusing lazy connect to connect anything starting from the metallic value and down on the principled bsdf node either doesnt work or it connects to the wrong valueExact steps for others to reproduce the error**
Based on the default startup or an attached .blend file (as simple as possible).

with node wrangle enabled,
Shift + alt + rmb and drag the rgb node to anything on the bsdf node starting from the metallic down

untitled.blend

**Blender Version 3.1.2**Short description of error**using lazy connect to connect anything starting from the metallic value and down on the principled bsdf node either doesnt work or it connects to the wrong value**Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). with node wrangle enabled, Shift + alt + rmb and drag the rgb node to anything on the bsdf node starting from the metallic down [untitled.blend](https://archive.blender.org/developer/F13088306/untitled.blend)

ronald johnson commented

2022-05-19 08:43:59 +02:00

Added subscriber: @billyand

Damien Picard commented

2022-05-22 21:03:55 +02:00

Added subscriber: @pioverfour

Damien Picard commented

2022-05-22 21:03:55 +02:00

Can confirm on latest master. Some subsurface inputs are disabled and thus the count gets offset (Subsurface IOR and Subsurface Anisotropy). I believe this fixes it:

diff --git a/node_wrangler.py b/node_wrangler.py
index ba0b33c2..776aa537 100644
--- a/node_wrangler.py
+++ b/node_wrangler.py
@@ -4414,7 +4414,7 @@ class NWConnectionListInputs(Menu, NWBase):
                 op = layout.operator(NWMakeLink.bl_idname, text=i.name, icon="FORWARD")
                 op.from_socket = context.scene.NWSourceSocket
                 op.to_socket = index
-                index+=1
+            index+=1
 
 
 class NWMergeMathMenu(Menu, NWBase):

Can confirm on latest master. Some subsurface inputs are disabled and thus the count gets offset (Subsurface IOR and Subsurface Anisotropy). I believe this fixes it: ``` diff --git a/node_wrangler.py b/node_wrangler.py index ba0b33c2..776aa537 100644 --- a/node_wrangler.py +++ b/node_wrangler.py @@ -4414,7 +4414,7 @@ class NWConnectionListInputs(Menu, NWBase): op = layout.operator(NWMakeLink.bl_idname, text=i.name, icon="FORWARD") op.from_socket = context.scene.NWSourceSocket op.to_socket = index - index+=1 + index+=1 class NWMergeMathMenu(Menu, NWBase): ```

Omar Emara commented

2022-05-23 09:45:22 +02:00

Added subscriber: @OmarEmaraDev