blender/blender-addons
19
43
Fork 96
Code Issues 632 Pull Requests 27 Projects 1 Releases Wiki Activity

IO: Option to import each 3DS file on a new collection #105232

Merged
Sebastian Sille merged 6 commits from :roblop-patch-new-collection into main 2024-03-13 13:34:08 +01:00
Conversation 1 Commits 6 Files Changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 98e970577c - Show all commits

2
io_scene_3ds/import_3ds.py
View File

@ -1781,7 +1781,7 @@ def load(operator, context, files=None, directory="", filepath="", constrain_siz
# Load each selected file
for file in files:
# Create new collections if activated (collection name = 3ds file name)
NRGSille marked this conversation as resolved
Sebastian Sille commented 2024-03-13 11:22:19 +01:00
Review
Copy Link

found a little error in line 1784 (below) must be replaced with if use_collection:

found a little error in line 1784 (below) must be replaced with `if use_collection:`
👍 1
RobLop commented 2024-03-13 13:20:42 +01:00
Review
Copy Link

Yes, I forgot this fix.

Yes, I forgot this fix.
if new_collection:
if use_collection:
RobLop marked this conversation as resolved Outdated
Sebastian Sille commented 2024-03-13 09:38:58 +01:00
Outdated
Review
Copy Link

Looks better if we- use it without suffix. Can be achieved with file.name.split(".")[0]

Looks better if we- use it without suffix. Can be achieved with `file.name.split(".")[0]`
👍 1
RobLop commented 2024-03-13 10:49:59 +01:00
Outdated
Review
Copy Link

Ok, achieved with Path().stem (modern way).

Ok, achieved with Path().stem (modern way).
👍 1
collection = bpy.data.collections.new(Path(file.name).stem)
bpy.context.scene.collection.children.link(collection)
bpy.context.view_layer.active_layer_collection = bpy.context.view_layer.layer_collection.children[collection.name]
RobLop marked this conversation as resolved Outdated
Sebastian Sille commented 2024-03-13 09:40:10 +01:00
Outdated
Review
Copy Link

Here is a little error, it must be os.path.join(directory, file.name)

Here is a little error, it must be `os.path.join(directory, file.name)`
👍 1
RobLop commented 2024-03-13 10:50:35 +01:00
Outdated
Review
Copy Link

Ok, corrected with the Path().

Ok, corrected with the Path().
👍 1