blender/blender-asset-tracer
2
5
Fork 5
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Add Support for Geometry Node Cache #92890

Open
Jonas Dichelle wants to merge 14 commits from JonasDichelle/blender-asset-tracer:geonodes_support into main
pull from: JonasDichelle/blender-asset-tracer:geonodes_support
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 14 Files Changed 6 +3 -1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6160c422b0 - Show all commits

4
blender_asset_tracer/trace/modifier_walkers.py
View File

@ -376,9 +376,11 @@ def modifier_nodes(
if use_custom_directory: if use_custom_directory:
directory_ptr = bake_directory_ptr directory_ptr = bake_directory_ptr
field = bake_directory_field field = bake_directory_field
block = bake
else: else:
directory_ptr = mod_directory_ptr directory_ptr = mod_directory_ptr
field = mod_directory_field field = mod_directory_field
block = modifier
if directory_ptr == 0: if directory_ptr == 0:
JonasDichelle marked this conversation as resolved
Sybren A. Stüvel commented 2024-09-05 11:31:49 +02:00
Review
Copy Link

I think it's slightly nicer to not compare to a concrete value, and just use if not directory_ptr:

I think it's slightly nicer to not compare to a concrete value, and just use `if not directory_ptr:`
continue continue
@ -390,7 +392,7 @@ def modifier_nodes(
bake_block_name = block_name + b".bakes[%d]" % bake_idx bake_block_name = block_name + b".bakes[%d]" % bake_idx
yield result.BlockUsage( yield result.BlockUsage(
modifier, block,
bpath, bpath,
block_name=bake_block_name, block_name=bake_block_name,
path_full_field=field, path_full_field=field,