blender/blender-developer-docs
7
8
Fork 38
Code Issues 3 Pull Requests 6 Activity

Update "Commiting Test Data" section to include build bot testing #77

Merged
Alaska merged 8 commits from Alaska/blender-developer-docs:test-updates-guide into main 2024-10-07 14:56:31 +02:00
Conversation 2 Commits 8 Files Changed 1 +43 -1
1 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
docs/handbook/testing/setup.md
View File

@ -148,7 +148,7 @@ Commit test files to the main branch of the test data repository.
``` bash ``` bash
cd tests/data cd tests/data
git checkout main git checkout main
.. make any changes .. .. make your changes ..
git commit testfile1 testfile2 git commit testfile1 testfile2
``` ```
@ -166,3 +166,45 @@ cd ../..
git push origin main git push origin main
``` ```
Alaska marked this conversation as resolved Outdated
Weizhen Huang commented 2024-10-02 13:05:14 +02:00
Outdated
Review
Copy Link

Should be in the same paragraph as "create a pull request". We can also add a link to the bot https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md

Should be in the same paragraph as "create a pull request". We can also add a link to the bot https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md
> NOTE: **Make sure the tests pass before committing to main**
>
> You should run your tests to make sure they pass before commiting them to main.
This can be done [locally](#running-tests), or using [Blender Bot](https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md) from Gitea
to ensure they pass on all platforms.
The steps for testing on the build bot are as follows:
>
> Commit changes in the `tests/data` repository to a new branch rather than main.
Sergey Sharybin commented 2024-10-02 11:35:56 +02:00
Outdated
Review
Copy Link

There should be something like

git checkout main
git merge --ff-only add-x-tests
git push origin main

And then land the PR from the Gita interface.
Maybe would be good to have @weizhen, @Sirgienko, or @LukasStockner have a look. They were working with tests more recently than me.

There should be something like ``` git checkout main git merge --ff-only add-x-tests git push origin main ``` And then land the PR from the Gita interface. Maybe would be good to have @weizhen, @Sirgienko, or @LukasStockner have a look. They were working with tests more recently than me.
``` bash
cd tests/data
git checkout -B add-x-tests
.. make your changes ..
git commit testfile1 testfile2
Alaska marked this conversation as resolved Outdated
Weizhen Huang commented 2024-10-02 12:53:18 +02:00
Outdated
Review
Copy Link

It's more straightforward to merge your PR from gitea, that would also close the PR.

It's more straightforward to merge your PR from gitea, that would also close the PR.
git push origin add-x-tests
```
>
> Commit the new `tests/data` submodule hash to your fork of the Blender repository.
``` bash
cd ../..
git checkout -B add-x-tests-blender
git commit tests/data
git push me add-x-tests-blender
```
> [Create a pull request](/docs/handbook/contributing/pull_requests/#create-a-pull-request) from the
link printed in the console,
and comment `@blender-bot build` to get the build bot to test the changes. Alternatively,
`@blender-bot build +gpu` can be used to trigger additional GPU tests (these aren't tested regularly,
so some GPU tests you haven't modified may fail).
>
> If the tests pass, then you can push your changes in the `tests/data`
repository to the main branch.
``` bash
cd tests/data
git checkout main
# Use --ff-only to keep the submodule hash unchanged.
git merge --ff-only add-x-tests
git push origin main
```
>
> From the Gitea interface, merge the pull request you just created in the Blender repository.