Donation Prompt Blocks Interaction with Bottom of Pages After Being Dismissed #104653

New Issue

MagnusVesper · 2023-12-07T08:07:13+01:00

MagnusVesper commented

2023-12-07 08:07:13 +01:00

Page Information
File: fund.blender.org/static/js/donation-box.js (not in this repo)
Blender Version: 4.0
Documentation Language: en
Permanent Link

Short description of error
The donation prompt will continue to block interaction with the page after it has been dismissed. This happens even in new tabs that remember you hiding it previously.
It prevents viewers from clicking the "Next" and "Previous" links on most manual pages along with all links on the blender.org footer. So I suspect many people think the websites are broken from this.

It could be fixed by adding 2 lines to the donationBoxMessageShow function defined in fund.blender.org/static/js/donation-box.js:

function donationBoxMessageShow() {
  if (donationBoxMessage == null) {
  } else {
    if (checkCookie('donationBoxMessageIsDismissed') || checkCookie('donatedAt')) {
      donationBoxMessage.classList.remove('show');
/*+*/ donationBoxMessage.classList.add('d-none'); /* added */
    } else {
      donationBoxMessage.classList.add('show');
/*+*/ donationBoxMessage.classList.remove('d-none'); /* added */
    }
  }
}

That function is run after clicking "I already donated", "Remind me later", and on page load.
d-none is defined with

.dfdb .d-none {
  display:none !important
}

in inline css included in the donationBoxMessage's parent. I checked this on blender.org and docs.blender.org

I'm not sure the proper place to submit this report. The source to this is not in the blender-manual repo. The problem also exists on blender.org. But this is the only public repo that I could find having anything to do with a website.

**Page Information** File: `fund.blender.org/static/js/donation-box.js` (not in this repo) Blender Version: `4.0` Documentation Language: `en` [Permanent Link](https://fund.blender.org/static/js/donation-box.js) **Short description of error** The donation prompt will continue to block interaction with the page after it has been dismissed. This happens even in new tabs that remember you hiding it previously. It prevents viewers from clicking the "Next" and "Previous" links on most manual pages along with all links on the blender.org footer. So I suspect many people think the websites are broken from this. It could be fixed by adding 2 lines to the `donationBoxMessageShow` function defined in `fund.blender.org/static/js/donation-box.js`: ```js function donationBoxMessageShow() { if (donationBoxMessage == null) { } else { if (checkCookie('donationBoxMessageIsDismissed') || checkCookie('donatedAt')) { donationBoxMessage.classList.remove('show'); /*+*/ donationBoxMessage.classList.add('d-none'); /* added */ } else { donationBoxMessage.classList.add('show'); /*+*/ donationBoxMessage.classList.remove('d-none'); /* added */ } } } ``` That function is run after clicking "I already donated", "Remind me later", and on page load. `d-none` is defined with ```css .dfdb .d-none { display:none !important } ``` in inline css included in the `donationBoxMessage`'s parent. I checked this on blender.org and docs.blender.org I'm not sure the proper place to submit this report. The source to this is not in the blender-manual repo. The problem also exists on blender.org. But this is the only public repo that I could find having anything to do with a website.

MagnusVesper added the

labels 2023-12-07 08:07:14 +01:00

Thomas Dinges added

Status

Confirmed

and removed