Version Switch is not basing the lang links off the current version in url #56420

Closed
opened 2018-08-16 19:28:48 +02:00 by Aaron Carlisle · 4 comments
Member

The language switch should only be changing the but it seems to be also changing the version to whatever is the first in the json

The language switch should only be changing the <lang> but it seems to be also changing the version to whatever is the first in the json
Tobias Heinke was assigned by Aaron Carlisle 2018-08-16 19:28:48 +02:00
Author
Member

Added subscriber: @Blendify

Added subscriber: @Blendify
Member

the JS works as intended, it's the JSON:
the version is extracted from the second column, because the theme var is a number (and not 'latest').
so there can't be '2.79' two times - it will take the first match.

((could be solved better by concating the label in the script - speed, etc.))

current:

   "latest": "Latest (2.79)",
   "2.79": "2.79",
   "2.8": "Dev 2.8"

right:

   "2.78": "2.78",
   "latest": "Latest 2.79",
   "dev": "Dev 2.8"
the JS works as intended, it's the JSON: the version is extracted from the second column, because the theme var is a number (and not 'latest'). so there can't be '2.79' two times - it will take the first match. ((could be solved better by concating the label in the script - speed, etc.)) current: ``` "latest": "Latest (2.79)", "2.79": "2.79", "2.8": "Dev 2.8" ``` right: ``` "2.78": "2.78", "latest": "Latest 2.79", "dev": "Dev 2.8" ```

This issue was referenced by 4437

This issue was referenced by 4437
Author
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#56420
No description provided.